2011-08-03, 00:35
Thanks for the feedback guys, keep it coming
Some responses:
fanart.image
I'll hold off on this one until the case it's being used for is eliminated. It's a tricky one as technically does the ".." item represent the parent? Not sure!
isequal(info.label,foo)
This will be used wherever there's an existing info label available to be compared to. A simple example is skin.hastheme(foo). We already have skin.currenttheme available, so you can already do isequal(skin.currenttheme,foo). Thus, skin.hastheme(foo) is unnecessary, we can drop it.
videoplayer.time etc.
These are all just wrappers (have been for a long time) to player.time etc. We're just cleaning up here. Long term I'd quite like to eliminate the videoplayer/musicplayer distinction as you shouldn't have to care about it.
window.isnext(id)
This one is tricky, I admit. It could be done a bunch of ways:
isequal(window.next, id)
window(id).isnext
isequal(gui.nextwindow, id)
etc. The key is that "next" isn't really a property of the window object: the window object doesn't know that it's the next window to be shown. I kinda prefer the last one to be honest because of this.
The idea is to keep things logically consistent from an API perspective - foo.bar should always mean that bar is a property of foo.
The advantage of the isequal technique here is, as pieh points out, it allows you to use integergreaterthan for comparison, and later on we could add more useful comparison techniques.
I definitely think a script can be written to take care of MOST this for you - don't worry, we won't be forcing this on you without it automatically being taken care of as much as possible. The ones that can't be done automatically are highlighted in the first post. Basically just the ones that are being deleted, as well as the change from player.rewinding2x -> player.rewindspeed. We'll see if we can arrange the script to detect and highlight these for you.
@pieh/ronie: would greatly appreciate if you could take some time to do a script for this I'll TRY and add backward compatibility when we change things anyway, but note that the backward compat code will NOT be available in Eden.
Cheers,
Jonathan
Some responses:
fanart.image
I'll hold off on this one until the case it's being used for is eliminated. It's a tricky one as technically does the ".." item represent the parent? Not sure!
isequal(info.label,foo)
This will be used wherever there's an existing info label available to be compared to. A simple example is skin.hastheme(foo). We already have skin.currenttheme available, so you can already do isequal(skin.currenttheme,foo). Thus, skin.hastheme(foo) is unnecessary, we can drop it.
videoplayer.time etc.
These are all just wrappers (have been for a long time) to player.time etc. We're just cleaning up here. Long term I'd quite like to eliminate the videoplayer/musicplayer distinction as you shouldn't have to care about it.
window.isnext(id)
This one is tricky, I admit. It could be done a bunch of ways:
isequal(window.next, id)
window(id).isnext
isequal(gui.nextwindow, id)
etc. The key is that "next" isn't really a property of the window object: the window object doesn't know that it's the next window to be shown. I kinda prefer the last one to be honest because of this.
The idea is to keep things logically consistent from an API perspective - foo.bar should always mean that bar is a property of foo.
The advantage of the isequal technique here is, as pieh points out, it allows you to use integergreaterthan for comparison, and later on we could add more useful comparison techniques.
I definitely think a script can be written to take care of MOST this for you - don't worry, we won't be forcing this on you without it automatically being taken care of as much as possible. The ones that can't be done automatically are highlighted in the first post. Basically just the ones that are being deleted, as well as the change from player.rewinding2x -> player.rewindspeed. We'll see if we can arrange the script to detect and highlight these for you.
@pieh/ronie: would greatly appreciate if you could take some time to do a script for this I'll TRY and add backward compatibility when we change things anyway, but note that the backward compat code will NOT be available in Eden.
Cheers,
Jonathan