Feeding back changes (python 2.7, portability, pkgsrc)

  Thread Rating:
  • 0 Votes - 0 Average
  • 1
  • 2
  • 3
  • 4
  • 5
Post Reply
abs0 Offline
Junior Member
Posts: 12
Joined: Jun 2011
Reputation: 0
Location: London
Post: #1
I'm looking at adding support to build xbmc to pkgsrc, initially for Linux and potentially for other platforms.

What would be the recommended way to feed back changes - one set of patches per feature/adjustment?

Assuming so I've started with the following, all against the 10.1 source:

Once I have a clean Linux build I hope to look at some BSD support, potentially trying to cleanup some of the ifdefs to make them more generic.

If anyone has any suggestions or pointers they would be most appreciated.

Thanks
find quote
spiff Offline
Retired Developer
Posts: 12,386
Joined: Nov 2003
Post: #2
yeah, please one patch, one feature/change/fix.

it would also be highly appreciated if you used pull requests on github instead.
find quote
spiff Offline
Retired Developer
Posts: 12,386
Joined: Nov 2003
Post: #3
also, your patches are against 10.1. python has been severly changed in master, and those diffs are not needed any longer.
find quote
abs0 Offline
Junior Member
Posts: 12
Joined: Jun 2011
Reputation: 0
Location: London
Post: #4
Thanks - have forked at github and will be submitting pull requests
find quote