[dev] Project Free TV

Eldorado Wrote:Take out the %20's and replace them with spaces or plus signs, then give er a go

This is the exact url that I'm passing from my logs:

Code:

15:10:09 T:772   DEBUG: Project Free TV: adding dir: 1960's And Earlier - plugin://plugin.video.projectfreetv/?url=http%3A%2F%2Fwww.free-tv-video-online.me%2Fmovies%2F1960%27s+and+earlier&section=movies&mode=movieslist

ah, it's not getting url encoded enough times. the path part of the url needs to be valid and urlencoded before passing it to add_video_item() (looks like you are passing "http://www.free-tv-video-online.me/movies/1960's and earlier"?) - is it not urlencoded where you are scraping it from? if it is already urlencoded there is a bug somewhere in my code - can you post the code that causes this to fail and i'll take a look.

edit: guess it is not properly encoded on the site:
very sloppy!

running just that bit through urllib.quote() before appending it to the rest of the URL should do the trick!



t0mm0

That did the job! Yep, I was surprised by that link!

For anyone following along I've sent v0.0.4 to my repo, most of everything is playable

Things I would like to clean up:

- order the source links in the popup dialog box
- tv shows sources currently list sources for all episodes instead of just the one you clicked on
- Latest sections for both movies and tv shows have same problem as above

Adding metadata support would be nice too, maybe my next project I can pull the metadata piece out of icefilms

Eldorado Wrote:That did the job! Yep, I was surprised by that link!

cool, some websites are pretty badly coded - browsers are far too lenient and silently fix up too many mistakes so web devs get lazy

Eldorado Wrote:For anyone following along I've sent v0.0.4 to my repo, most of everything is playable

Things I would like to clean up:

- order the source links in the popup dialog box

i'm currently working on a branch of urlresolver which will hopefully fix this and the hoster/videoid issue, nothing in my github yet but should have something for comments in the next few days

Eldorado Wrote:Adding metadata support would be nice too, maybe my next project I can pull the metadata piece out of icefilms

that sounds like it would be another useful building block to go alongside urlresolver and t0mm0.common....

great work on this addon, getting someone else to put my modules through their paces and come up with suggestions has really helped me think about how to make stuff better before their first stable release. i can't wait to get them finalised enough for a release so that we can get this stuff out to a wider audience. hopefully the changes i make to fix the stuff mentioned above won't cause too much work for you to update!

thanks,

t0mm0.

t0mm0 Wrote:i'm currently working on a branch of urlresolver which will hopefully fix this and the hoster/videoid issue, nothing in my github yet but should have something for comments in the next few days

that sounds like it would be another useful building block to go alongside urlresolver and t0mm0.common....

great work on this addon, getting someone else to put my modules through their paces and come up with suggestions has really helped me think about how to make stuff better before their first stable release. i can't wait to get them finalised enough for a release so that we can get this stuff out to a wider audience. hopefully the changes i make to fix the stuff mentioned above won't cause too much work for you to update!

thanks,

t0mm0.

Your common class and urlresolver has made this one very easy! And I chose a rather simple site as my first go

I finally got my tv show sources fixed up, I had to create a new add_video method that accepts an optional dict of queries.. when I create a video item for an episode, I pass the episode name so that when I user clicks on the episode, I am then able to grab only the html portion containing source links for just that episode - unique way this site lays out it's tv show content

This might be useful for others, should I submit a patch to update your add_video_item() and add_item() methods?

Eldorado Wrote:I finally got my tv show sources fixed up, I had to create a new add_video method that accepts an optional dict of queries.. when I create a video item for an episode, I pass the episode name so that when I user clicks on the episode, I am then able to grab only the html portion containing source links for just that episode - unique way this site lays out it's tv show content

This might be useful for others, should I submit a patch to update your add_video_item() and add_item() methods?

yeah, please do, as long as it's generic enough that you can pass anything around - maybe it will be useful in other situations too.

t0mm0

t0mm0 Wrote:yeah, please do, as long as it's generic enough that you can pass anything around - maybe it will be useful in other situations too.

t0mm0

Will do, I created a fork for myself and will put in this change as well as my Zshare plugin

Eldorado Wrote:Will do, I created a fork for myself and will put in this change as well as my Zshare plugin

great! look forward to the pull request

i promise i will try and fix the sorting (and videoid) stuff this weekend

t0mm0

Eldorado, have you played around with any of the metadata yet?

rogerthis Wrote:Eldorado, have you played around with any of the metadata yet?

I have, but nothing substantial yet..

I grabbed the latest from the Icefilms master branch, moved it into it's own script folder all setup to be it's own script addon

The fun part now is stripping all Icefilms specific coding as well as some items that were left on their to-do list

I was wondering if I should throw it up on my git repository for all to start working on, or pass it over to t0mm0 to host as he seems to have a much better understanding of python..?

Also, seems that it can only scrape tmdb and tvdb using IMDB id's.. would need to add in scraping based on just movie or tv show name, not sure how difficult it will be to add that in

Not sure if it would help but have you seen the modified icefilms that comes with a 5gb meta data collection. It can be found here http://forum.xbmc.org/showthread.php?p=8...post879777