[RELEASE] KNX Commander or how to control KNX home with XBMC video player

panzaeron · 2012-06-01 21:19

I would say, ab big thank you for your great plugin.

My Platform is OpenELEC PVR and it works without any problems. It is a nice feeling, when the movie starts and the lights dimm down and at the movie end up again Smile

adm1024 · 2012-08-13 22:52

New version
A new version released : 0.1.0
The changes are :

Debug mode
verbosity reduction
return to the normal icon (not xmas icon)
preFrodo compatible

Regards

adm1024 · 2012-09-04 18:25

[NEW VERSION]
VERSION 0.1.1 : real debug option to reduce info in xbmc.log
The previous version didn't use the function correctly.

leechguy · 2012-11-09 01:03

I had a peek into the code (v.0.1.1) and noticed the following:

Code:

my_xevstop = __addon__.getSetting("XEVSTART")

'XEVSTART' should be 'XEVSTOP'.

Code:

while (xbmc.abortRequested):

    #Execute XBMC STOP Event settings on Device

    if my_xevend=="true":

    linknx_send(my_ip,my_port,my_xevstopcmd,my_xevstopval)

    xbmc.log('KNX-Commander: Bye')

Should the 'while' not be a simple 'if' statement instead? When shutting down, xbmc.abortRequested will be true so the 'while' will loop until the script gets killed by XBMC. The 'KNX-Commander: Bye' message appears multiple times in you log I guess..
Thinking about it... you don't need the while (or an if for that matter) at all.

Also, there seems to be only one reference to the 'my_xevend' variable. Basically you are comparing an uninitialized variable with the word "true". The result of this compare will be false so the linknx_send() statement will never be executed. (When disabling the addon, XBMC also complains and writes the error message to the xbmc.log)
When looking at the code I reckon the 'my_xevend' should be 'my_xevstop'.

In the English strings.xml "<string id="69500">LinKNX serveur</string>" should be "<string id="69500">LinKNX Server</string>".

Other than that, cool stuff Smile

Now if only this KNX stuff wasn't so @#$# expensive... I haven't decided yet what technology to use, but I'm leaning towards z-wave.

adm1024 · 2012-11-09 15:00

Hello Leechguy and thanks a lot for your feedback.

I have considered your suggestions and they will be incorporated in the next version with your name.
For information, I started the addon by using the 'X10 Commander' and changing only the X10 part to KNX/LinKNX one. I have not seen the code completely. About Stop XBMC for part I do not use it personally, so I did not tested it. I'll do in the future.

I made some improvements in the FRODO Xbmc alpha version and the future version of the addon will be launch only after FRODO Release Candidate.

Regards

panzaeron Junior Member Posts: 38 Joined: Jun 2009 Reputation: 0	2012-06-01 21:19 Post: #11 I would say, ab big thank you for your great plugin. My Platform is OpenELEC PVR and it works without any problems. It is a nice feeling, when the movie starts and the lights dimm down and at the movie end up again
	find quote

adm1024 Junior Member Posts: 16 Joined: Apr 2009 Reputation: 0 Location: FR	2012-08-13 22:52 Post: #12 New version A new version released : 0.1.0 The changes are : Debug mode verbosity reduction return to the normal icon (not xmas icon) preFrodo compatible Regards XBMC AddOn to control your lights with XBMC KNX Commander (This post was last modified: 2012-08-13 22:53 by adm1024.)
	find quote

adm1024 Junior Member Posts: 16 Joined: Apr 2009 Reputation: 0 Location: FR	2012-09-04 18:25 Post: #13 [NEW VERSION] VERSION 0.1.1 : real debug option to reduce info in xbmc.log The previous version didn't use the function correctly. XBMC AddOn to control your lights with XBMC KNX Commander
	find quote