Posts: 833
Joined: Sep 2010
Reputation:
3
2011-11-15, 19:08
(This post was last modified: 2011-11-15, 19:15 by hentai23.)
huh ? what did i say , btw i dont think spiff meant me , never said anything about his work in a negative manner did i now ....-.-' , except that hes doing a killer job and that maybe i wanted my weather working again , wich it is except for the 4day forecast xD
Posts: 12,706
Joined: Nov 2003
Reputation:
129
spiff
Team-Kodi Member
Posts: 12,706
yes, it was directed at others, in particular mr fish or whatever it was on the xbmc.org comment section.
Posts: 833
Joined: Sep 2010
Reputation:
3
ohhh thank god ..that was close ...lol xD
funny people asuming as soon as people talk about negative comments it being me automatically ...lol ... all i do is contribute constructive feedback some people dont understand that it seems they should point theyre fingers to emselfes for a change -.-'
p.s: keep up da good work spiff you da man !
Posts: 12,706
Joined: Nov 2003
Reputation:
129
spiff
Team-Kodi Member
Posts: 12,706
to be fair, it was due to my ffs post earlier in the thread i think.
Posts: 35
Joined: Apr 2010
Reputation:
0
Good job, weather now works for me. Unfortunately I cannot use Git version right now because stream listening is broken in it but listening internet-radio is one of main purposes to use XBMC in my case so I've did rollback to working 10.1.
Posts: 136
Joined: Jun 2011
Reputation:
4
2011-11-26, 18:07
(This post was last modified: 2011-11-27, 11:45 by ReducedToZero.)
Thank you Spiff.
One last request (promise),
As strtol() returns a '0' if no conversion occurred it's currently impossible to unset some weather related window properties. Skinners are using a !IsEmpty test in the visibility conditions for many weather labels (Current temp, high temp etc) which is always going to pass.
Would it be possible to add tests in weather.cpp around the various strtol()'s for a value of -999 (as 0 is a valid value and -999 should never legitimately occur) which would set the relevant window property to a null string?
Use case is for weather Addons which can't or don't provide the full 4 days minimum data most Skins expect.
Alternatively I could ask skinners to support a day[0-4].isHidden window property but that seems a bit hacky as they are already checking against the various properties directly.
'Zero
-----
XBMC Dharma (Taking a look at Eden) | Windows Vista | Aeon Nox 1.7
-----
On a long enough timeline. The survival rate for everyone drops to zero.
Posts: 12,706
Joined: Nov 2003
Reputation:
129
spiff
Team-Kodi Member
Posts: 12,706
i'm only taking input in patch form from now on.