[Release] Artwork Downloader

PunkyMatt · 2011-11-15 20:52

Hi !

Machine-Sanctum Wrote:Thank you all for your comments.

So no issues so far

Now I am surprised

so you're asking for troubles ?

I have one for you !

actually I have the same problem with the old extrafanart downloader script.

I have configured the addon to download only TV show extrafanart (and I limited the number of downloaded extrafanart to 20).

When I launch it (bulk mode, but the problem seems to be the same if I launch it via skin integration), I have an immediate error.

Here's what I have in xbmc.log:

Code:

19:44:48 T:140483762075392  NOTICE: -->Python Interpreter Initialized<--

19:44:49 T:140483762075392   ERROR: Error Type: <type 'exceptions.ValueError'>

19:44:49 T:140483762075392   ERROR: Error Contents: invalid literal for int() with base 10: '20,'

19:44:49 T:140483762075392   ERROR: Traceback (most recent call last):

                                              File "/home/xbmc/.xbmc/addons/script.artwork.downloader/default.py", line 460, in <module>

                                                Main()

                                              File "/home/xbmc/.xbmc/addons/script.artwork.downloader/default.py", line 65, in __init__

                                                initial_vars(self)

                                              File "/home/xbmc/.xbmc/addons/script.artwork.downloader/default.py", line 112, in initial_vars

                                                self.filters = apply_filters()

                                              File "/home/xbmc/.xbmc/addons/script.artwork.downloader/resources/lib/apply_filters.py", line 14, in __init__

                                                self.settings._get()

                                              File "/home/xbmc/.xbmc/addons/script.artwork.downloader/resources/lib/settings.py", line 50, in _get

                                                self.limit_extrafanart_max = int(__addon__.getSetting("limit_extrafanart_max").rstrip('0').rstrip('.'))

                                            ValueError: invalid literal for int() with base 10: '20,'

any idea why this is happening ?

I'm using XBMC pre-Eden on Ubuntu 10.10

and here's some other info, don't know if it helps:

Code:

xbmc@xbmc:~$ python --version

Python 2.6.6

xbmc@xbmc:~$ dpkg -l|grep xbmc

ii  plymouth-theme-xbmc-logo             1.0.2                                             graphical boot animation and logger - xbmc-logo theme

ii  xbmc                                 2:11.0~git20111113.993e6d2-0ubuntu1~ppa1~maverick XBMC Media Center (arch-independent data package)

ii  xbmc-bin                             2:11.0~git20111113.993e6d2-0ubuntu1~ppa1~maverick XBMC Media Center (binary data package)

xbmc@xbmc:~$

paddycarey · 2011-11-15 20:53

Machine-Sanctum Wrote:NOTE:
Remember if you have used Extrafanart Downloader: remove all existing "extrafanart" because of some file naming changes. Else they will all appear double.

If you're on linux then this is as simple as:

Code:

find /path/to/your/tvlibrary -type d -name "extrafanart" | while read x; do rm -rfv "$x"; done

careful though, rm's dangerous when not used responsibly (as i found out just the other day Confused

)

PunkyMatt · 2011-11-15 20:56

paddycarey Wrote:If you're on linux then this is as simple as:

Code:

find /path/to/your/tvlibrary -type d -name "extrafanart" | while read x; do rm -rfv "$x"; done

careful though, rm's dangerous when not used responsibly (as i found out just the other day )

even simpler:

Code:

find /path/to/your/tvlibrary -type d -name "extrafanart" -exec rm -rf {} \;

paddycarey · 2011-11-15 20:56

PunkyMatt Wrote:Hi !
so you're asking for troubles ?

I have one for you !

actually I have the same problem with the old extrafanart downloader script.

looks like a problems with your settings, can you post your settings.xml too please?

PunkyMatt · 2011-11-15 20:58

paddycarey Wrote:looks like a problems with your settings, can you post your settings.xml too please?

Code:

<settings>

    <setting id="background" value="false" />

    <setting id="cache_directory" value="" />

    <setting id="centralfolder_movies" value="" />

    <setting id="centralfolder_tvshows" value="" />

    <setting id="centralize_enable" value="false" />

    <setting id="limit_artwork" value="true" />

    <setting id="limit_extrafanart_max" value="20,000000" />

    <setting id="limit_extrafanart_rating" value="5,000000" />

    <setting id="limit_language" value="true" />

    <setting id="limit_notext" value="true" />

    <setting id="limit_size_moviefanart" value="720" />

    <setting id="limit_size_tvshowfanart" value="720" />

    <setting id="movie_discart" value="false" />

    <setting id="movie_enable" value="false" />

    <setting id="movie_extrafanart" value="false" />

    <setting id="movie_extrathumbs" value="false" />

    <setting id="movie_fanart" value="false" />

    <setting id="movie_logo" value="false" />

    <setting id="movie_poster" value="false" />

    <setting id="notify" value="true" />

    <setting id="tvshow_characterart" value="false" />

    <setting id="tvshow_clearart" value="false" />

    <setting id="tvshow_enable" value="true" />

    <setting id="tvshow_extrafanart" value="true" />

    <setting id="tvshow_fanart" value="false" />

    <setting id="tvshow_logo" value="false" />

    <setting id="tvshow_poster" value="false" />

    <setting id="tvshow_seasonbanner" value="false" />

    <setting id="tvshow_seasonposter" value="false" />

    <setting id="tvshow_seasonthumbs" value="false" />

    <setting id="tvshow_showbanner" value="false" />

    <setting id="tvshow_thumb" value="false" />

    <setting id="use_cache" value="false" />

</settings>

**Martijn** · 2011-11-15 21:06

Problem like paddycarey sayd.

Could you try this one:
https://github.com/downloads/Machine-San...loader.zip

paddycarey · 2011-11-15 21:07

PunkyMatt Wrote:

Code:

<setting id="limit_extrafanart_max" value="20,000000" /> <setting id="limit_extrafanart_rating" value="5,000000" />

This looks like the problem right there. Your locale uses "," instead of "." as a decimal separator. Should be a simple fix, thanks for reporting.

PunkyMatt · 2011-11-15 21:14

Machine-Sanctum Wrote:There should be any

Code:

,
in your settings. Strange.

Could you try this one:
https://github.com/downloads/Machine-San...loader.zip

paddycarey Wrote:This looks like the problem right there. Your locale uses "," instead of "." as a decimal separator. Should be a simple fix, thanks for reporting.

yeah that "," seemed strange to me when I looked into settings.xml to paste it here. I've checked settings for another script (cinema experience), and it has the same "," for decimal number so I tought it was normal.

But now I remember that cinema experience stopped working recently too, must be the same problem.

Thanks, I'm gonna try your new version as soon as my girlfriend has stopped playing with the Wii Wink

and report back here.

Do you think it's someting that needs to be fixed at script level, XBMC settings level (I'm using French as international settings) or is it something to fix systemwide ?

**Martijn** · 2011-11-15 21:22

PunkyMatt Wrote:Do you think it's someting that needs to be fixed at script level, XBMC settings level (I'm using French as international settings) or is it something to fix systemwide ?

Well if it fixes it it should stay in there just in case. Wasn't a major thing so.
Just set my nightly build to french (luckely i know a little) and i had no problems so it might by something else.
Seems to me that this can cause more problems somewhere so maybe post your problem in the right section (maybe the PVR section) to get this looked at by the dev's.

paddycarey · 2011-11-15 21:24

Should be something we can easily fix in the script. It's normal for some locales to use , instead of .

Not sure if it's always been this way or it was recently changed in xbmc.

PunkyMatt Junior Member Posts: 33 Joined: Aug 2009 Reputation: 0 Location: France, IdF	2011-11-15 20:56 Post: #13 paddycarey Wrote:If you're on linux then this is as simple as: Code: `find /path/to/your/tvlibrary -type d -name "extrafanart" \| while read x; do rm -rfv "$x"; done` careful though, rm's dangerous when not used responsibly (as i found out just the other day ) even simpler: Code: `find /path/to/your/tvlibrary -type d -name "extrafanart" -exec rm -rf {} \;`
	find quote

paddycarey Senior Member Posts: 246 Joined: Sep 2009 Reputation: 8	2011-11-15 20:56 Post: #14 PunkyMatt Wrote:Hi ! so you're asking for troubles ? I have one for you ! actually I have the same problem with the old extrafanart downloader script. looks like a problems with your settings, can you post your settings.xml too please? Add-ons: Artwork Downloader, MMA Browser, MMAFighting.com, The Joe Rogan Experience, FightCasts, Deathsquad.tv, Vice.com
	find quote

paddycarey Senior Member Posts: 246 Joined: Sep 2009 Reputation: 8	2011-11-15 21:24 Post: #20 Should be something we can easily fix in the script. It's normal for some locales to use , instead of . Not sure if it's always been this way or it was recently changed in xbmc. Add-ons: Artwork Downloader, MMA Browser, MMAFighting.com, The Joe Rogan Experience, FightCasts, Deathsquad.tv, Vice.com
	find quote