[Release] Artwork Downloader

paddycarey · 2011-11-15 21:26

Machine-Sanctum Wrote:Just set my nightly build to french (luckely i know a little) and i had no problems so it might by something else.

did you change your settings after the language switch? if you didn't then you won't have noticed a difference i don't think.

PunkyMatt · 2011-11-15 21:28

Machine-Sanctum Wrote:Well if it fixes it it should stay in there just in case. Wasn't a major thing so.
Just set my nightly build to french (luckely i know a little) and i had no problems so it might by something else.

Seems like a big problem for me, I've just checked I have these "," everywhere, even in xbmc guisettings.xml.

I compared it with my backed up guisettings.xml from before I upgrade to pre-Eden, and the Dharma one doesn't have the ","

for example

Code:

Dharma guisettings.xml

...

   <defaultvideosettings>

        <interlacemethod>0</interlacemethod>

        <scalingmethod>1</scalingmethod>

        <noisereduction>0.000000</noisereduction>

        <sharpness>0.000000</sharpness>

        <viewmode>0</viewmode>

        <zoomamount>1.000000</zoomamount>

        <pixelratio>1.000000</pixelratio>

...

   <locale>

        <charset>DEFAULT</charset>

        <country>France</country>

        <language>French</language>

        <timezone>Europe/Paris</timezone>

        <timezonecountry>France</timezonecountry>

    </locale>

...

Eden guisettings:

...

    <defaultvideosettings>

        <deinterlacemode>0</deinterlacemode>

        <interlacemethod>1</interlacemethod>

        <scalingmethod>1</scalingmethod>

        <noisereduction>0,000000</noisereduction>

        <postprocess>false</postprocess>

        <sharpness>0,000000</sharpness>

        <viewmode>0</viewmode>

        <zoomamount>1,000000</zoomamount>

        <pixelratio>1,000000</pixelratio>

...

    <locale>

        <charset>DEFAULT</charset>

        <country>France</country>

        <language>French</language>

        <timezone>Europe/Paris</timezone>

        <timezonecountry>France</timezonecountry>

    </locale>

...

So this must be an XBMC problem, not a script problem.

**Martijn** · 2011-11-15 21:34

PunkyMatt Wrote:Seems like a big problem for me, I've just checked I have these "," everywhere, even in xbmc guisettings.xml.

I compared it with my backed up guisettings.xml from before I upgrade to pre-Eden, and the Dharma one doesn't have the ","

So this must be an XBMC problem, not a script problem.

So you should definitely post this bug somewhere or create a trac bug ticket for this. Does this happen to only that build version or several?

Did it fix the issue for you or haven't you got the chance to try?

PunkyMatt · 2011-11-15 21:41

Machine-Sanctum Wrote:So you should definitely post this bug somewhere or create a trac bug ticket for this. Does this happen to only that build version or several?

Did it fix the issue for you or haven't you got the chance to try?

didn't try yet, I can't get my girlfriend to stop playing on the Wii Wink

It's the first pre Eden build I try, I installed it yesterday

PunkyMatt · 2011-11-15 22:03

I just did a quick test, and everything's working fine if I change my XBMC languages to english.

I'll investigate further when I'll have some time and post a bug report when I'm sure the problem is not caused by me.

Rastan · 2011-11-15 22:39

Machine-Sanctum Wrote:Thank you all for your comments.

So no issues so far

Now I am surprised

Thanks for the amazing plugin. Love all the new aditions you guys are making. One thing I noticed almost immediately after scraping is that I have posters unticked under movie settings, but it still downloads the poster.jpg anyway. Its not that big of a deal for me but thought I shoudl let you know.

**Martijn** · 2011-11-15 22:41

Rastan Wrote:Thanks for the amazing plugin. Love all the new aditions you guys are making. One thing I noticed almost immediately after scraping is that I have posters unticked under movie settings, but it still downloads the poster.jpg anyway. Its not that big of a deal for me but thought I shoudl let you know.

Will look into that. It may just be a glitch of the dialog but none the less should be fixed.

EDIT:
You are right. Will fix.

**Martijn** · 2011-11-16 01:05

Artwork Downloader - Eden11.0 ONLY: version 0.4.2.RC2
Available from download section.

Bug fixes:

fixes downloading artwork not enabled for that mediatype
Possible localization error (dot or comma). This a XBMC bug http://trac.xbmc.org/ticket/12215

rich_stwrt · 2011-11-16 05:17

Have not had a chance to try this yet, will try a little later tonight when i can reclaim the TV from the family.

But, based on the features you have listed, I see one more that would be incredibly useful.

As far as TV shows, XBMC will always default to 'folder.jpg' as the artwork for the show. Some skins (like confluence) assume this is a banner, and let you set an option to use 'poster.jpg' as the artwork. Conversely, some skins (simplicity is the one i am familiar with) assume 'folder.jpg' is a poster and allow you to set an option to use 'banner.jpg'.

Since it does not appear the base code is going to move away from using 'folder.jpg' anytime in the near future, it would be useful as I am downloading the artwork to be able to either name the banner or the poster files 'folder.jpg' as they are downloaded. Even better would be to make a copy of the selected file (banner or poster) and name the copy 'folder.jpg'.

Or (and I'm really dreaming big here) how about the ability to bulk change the 'folder.jpg' to either a banner or poster.

Interestingly, I don't think there is an external scraper out there that has this functionality... if you could accomplish this you would be on the cutting edge.

Thanks for listening.

**Martijn** · 2011-11-16 11:46

rich_stwrt Wrote:But, based on the features you have listed, I see one more that would be incredibly useful.
....
Interestingly, I don't think there is an external scraper out there that has this functionality... if you could accomplish this you would be on the cutting edge.

Thanks for listening.

It was already planned just not yet implemented. It will eventually, i just need to find the best way on how to do this and how this option needs to be shown in the settings.

Ember can do this in bulk mode.

PunkyMatt Junior Member Posts: 33 Joined: Aug 2009 Reputation: 0 Location: France, IdF	2011-11-15 22:03 Post: #25 I just did a quick test, and everything's working fine if I change my XBMC languages to english. I'll investigate further when I'll have some time and post a bug report when I'm sure the problem is not caused by me.
	find quote