script favourites - new features

  Thread Rating:
  • 1 Votes - 5 Average
  • 1
  • 2
  • 3
  • 4
  • 5
Post Reply
« Next Oldest | Next Newest»
pecinko Offline
Member+
 Posts: 3,067
Joined: Dec 2008
Reputation: 29
Location: Prague / Belgrade
Big Grin  2012-01-16 20:58   Post: #51
Hitcher Wrote:I know this is a big request but the ability to use a script to select any item - be it a Favourite, Addon, Playlist, etc (just like in your Xperience Metro home screen) - would be pretty damn awesome. It would also allow users to change the name and/or image easily if they so desired.

Thanks.

Not that it would not be useful and that I disagree but I was thinking that it might be better overal to improve built in favourites. My reasoning was:

- You can already put any type of shourtcut there.
- you have overview of items there

Lacking ATM

- ability to change/assign custom icon (made a ticket but it did not make it for Eden, was accepted)
- renaming items
- dialog pop up when adding playlists askin if default should be open or play
- system support for assigning favourite instead of using script ( like what we now have for addons )

Don't know what the others think, though.
My skins:

Quartz
Amber
find quote
Hitcher Offline
Skilled Skinner
 Posts: 9,976
Joined: Aug 2007
Reputation: 67
Location: Eastleigh, UK
2012-01-16 21:18 Post: #52
Totally agree and I'd go so far ask for it to to be a made window instead of a dialog so we can use different view types easily.
[Image: sig_zps3af3b48e.jpg]
find quote
`Black Offline
Skilled Skinner
 Posts: 2,070
Joined: Apr 2009
Reputation: 51
Location: Germany
2012-01-16 23:17 Post: #53
Hitcher Wrote:I know this is a big request but the ability to use a script to select any item - be it a Favourite, Addon, Playlist, etc (just like in your Xperience Metro home screen) - would be pretty damn awesome. It would also allow users to change the name and/or image easily if they so desired.

Thanks.

Maybe not as good as with a script or native support but I found a way to set those values with SetAddon. Check my latest commit for details.
[Image: xp1080-21.png]
find quote
pecinko Offline
Member+
 Posts: 3,067
Joined: Dec 2008
Reputation: 29
Location: Prague / Belgrade
2012-02-04 01:07 Post: #54
Guys

Correct me if I'm wrong but there seems to be a problem with latest version of script.

If I add smart playlist as home menu item, the script the old way, playlist plays instead of open.

Code:
<onfocus>RunScript(script.favourites,playlists=window)</onfocus>

If I use the new way

Code:
<onclick>RunScript(script.favourites,property=CustomMovies.7)</onclick>

I'm being asked to choose between play and open. Good, I choose open. However, when I click on this newly created item, nothing happens.

I have always used this

Code:
<onclick>$INFO[Skin.String(CustomMovies.7.Path)]</onclick>

to open item from Home page.

Just tested it in Xeebo Nightly 2.7.0 - same thing happens.

Any thoughts?

EDIT:

Seems that problem is related to non english smart playlist names. Here's the log:

Code:
00:09:25 T:2895274688   DEBUG: ExecuteXBMCAction : To ActivateWindow(10025,"special://profile/playlists/video/720 vy\xcc\x81be\xcc\x8cr.xsp",return)
00:09:25 T:2895274688   DEBUG: Activating window ID: 10025
00:09:25 T:2895274688   DEBUG: ------ Window Deinit (Home.xml) ------
00:09:25 T:2895274688   DEBUG: ------ Window Init (MyVideoNav.xml) ------
00:09:25 T:2895274688    INFO: Loading skin file: MyVideoNav.xml
00:09:25 T:2895274688   DEBUG: Load MyVideoNav.xml: 136.94ms
00:09:25 T:2895274688   DEBUG: Alloc resources: 140.00ms (137.02 ms skin load)
00:09:25 T:2895274688   DEBUG: CGUIMediaWindow::GetDirectory (special://profile/playlists/video/720 vy\xcc\x81be\xcc\x8cr.xsp)
00:09:25 T:2895274688   DEBUG:   ParentPath = [special://profile/playlists/video/720 vy/xcc/x81be/xcc/x8cr.xsp/]
00:09:25 T:2895274688   ERROR: Error loading Smart playlist special://profile/playlists/video/720 vy\xcc\x81be\xcc\x8cr.xsp (failed to read file)
00:09:25 T:2895274688   ERROR: Previous line repeats 1 times.
00:09:25 T:2895274688   ERROR: GetDirectory - Error getting special://profile/playlists/video/720 vy\xcc\x81be\xcc\x8cr.xsp
00:09:25 T:2895274688   ERROR: CGUIMediaWindow::GetDirectory(special://profile/playlists/video/720 vy\xcc\x81be\xcc\x8cr.xsp) failed
00:09:27 T:2895274688   DEBUG: SDLKeyboard: scancode: 35, sym: 001b, unicode: 001b, modifier: 0
00:09:27 T:2895274688   DEBUG: OnKey: escape (f01b) pressed, action is PreviousMenu
00:09:27 T:2895274688   DEBUG: CGUIWindowManager::PreviousWindow: Deactivate
00:09:27 T:2895274688   DEBUG: ------ Window Deinit (MyVideoNav.xml) ------
00:09:27 T:2895274688   DEBUG: CGUIWindowManager::PreviousWindow: Activate new
00:09:27 T:2895274688   DEBUG: ------ Window Init (Home.xml) ------

actual smart playlist name is "720 výběr".

BTW, thanks a lot for improving it Black. I still hate it that I have to edit a bunch of code to make it work the new way, but it is so much easier to use that it was before your changes.
My skins:

Quartz
Amber
(This post was last modified: 2012-02-04 01:15 by pecinko.)
find quote
pecinko Offline
Member+
 Posts: 3,067
Joined: Dec 2008
Reputation: 29
Location: Prague / Belgrade
2012-02-05 20:57 Post: #55
If it helps troubleshooting somehow, the very same playlist opens up nicely from Favourites.
My skins:

Quartz
Amber
find quote
Sharpe Offline
Skilled Skinner
 Posts: 975
Joined: Jul 2006
Reputation: 12
Location: North West England
2012-02-05 21:39 Post: #56
pecinko -try it without ,playlists=window - the old way works for me in that it opens a window instead.
BACK ROW - DOWNLOADS
find quote
`Black Offline
Skilled Skinner
 Posts: 2,070
Joined: Apr 2009
Reputation: 51
Location: Germany
2012-02-05 22:13 Post: #57
I will look at it when I have the time but for now rename the playlist and it should work.
[Image: xp1080-21.png]
find quote
pecinko Offline
Member+
 Posts: 3,067
Joined: Dec 2008
Reputation: 29
Location: Prague / Belgrade
2012-02-05 23:43 Post: #58
Sharpe Wrote:pecinko -try it without ,playlists=window - the old way works for me in that it opens a window instead.

Thanks for the tip but it's too late, I recoded everything to new way already.

It's better and easier to use and code and it works as supposed except for minor glitch with NON ASCII named playlists. I can tell users to rename them or wait for fix.
My skins:

Quartz
Amber
find quote
pecinko Offline
Member+
 Posts: 3,067
Joined: Dec 2008
Reputation: 29
Location: Prague / Belgrade
2012-03-26 16:22 Post: #59
(2011-11-21 14:16)`Black Wrote:  Thanks, will be added in the next update.

@pecinko
DeInit problem seems to be a bug with python, I already created a trac ticket... same problem with logo downloader.

If I'm not mistaken, this problem seems to be back in final release. It reappeared somewhere between RC2 and Eden. I'm getting same borked window after DialogSelect.xml deinit as before.

EDIT: I have added open/close animation to dialog select and it seems to help...



One more problem. Could this problem in log

Code:
12:08:54 T:2900   DEBUG: script.favourites: script version 3.2.2 started
12:08:54 T:2900   DEBUG: script.favourites: ### params: {'property': 'CustomTV.1'}
12:08:54 T:3060   DEBUG: ------ Window Init (C:\Users\HTä\AppData\Roaming\XBMC\addons\skin.quartz\720p\DialogSelect.xml) ------
12:08:54 T:3060    INFO: Loading skin file: C:\Users\HTä\AppData\Roaming\XBMC\addons\skin.quartz\720p\DialogSelect.xml
12:08:54 T:3060   DEBUG: unable to load C:\Users\HTä\AppData\Roaming\XBMC\addons\script.favourites\resources\language\En​glish (US)\strings.xml: Failed to open file at line 0
12:08:54 T:3060   ERROR: Control 3 in window 13000 has been asked to focus, but it can't
12:08:54 T:2900   DEBUG: unable to load C:\Users\HTä\AppData\Roaming\XBMC\addons\script.favourites\resources\language\En​glish (US)\strings.xml: Failed to open file at line 0

be related to issue with non ASCII characters? (as in http://forum.xbmc.org/showthread.php?tid...id1008785)

I'm not able to reproduce problem at my side but user is unable to assign custom shortcut on his system.
My skins:

Quartz
Amber
(This post was last modified: 2012-03-26 16:27 by pecinko.)
find quote
Pikselli Offline
Junior Member
 Posts: 23
Joined: Dec 2011
Reputation: 0
2012-04-27 01:03 Post: #60
Where can i Download this`?
find quote
Post Reply
Contact Us | XBMC Home | Return to Top | Return to Content | Lite (Archive) Mode | RSS Syndication