[RELEASE] Artwork Downloader - Skin support

  Thread Rating:
  • 3 Votes - 4.67 Average
  • 1
  • 2
  • 3
  • 4
  • 5
Post Reply
ekim232 Offline
Posting Freak
Posts: 1,206
Joined: Nov 2008
Reputation: 5
Location: Chicago, IL
Post: #91
Martijn Wrote:Yes i know Smile

Please try this one:
script.artwork.downloader-Eden(1.0.3)-RC2.zip

Fixes:
- downloading artwork specific for movies

That worked perfect! Thanks for the fix up.
find quote
Martijn Offline
Team-XBMC
Posts: 10,997
Joined: Jul 2011
Reputation: 158
Location: Dawn of time
Post: #92
Call to skinners:
I did some code cleanup and would like some feedback if all still functions like it should
downloads

Please let me know.


Just heads up what is coming when new http://fanart.tv site goes live. We still needs a lot more images so any help is much appreciated.
[Image: avatar4ee3dae9cf677.png]
[Image: avatarss.png]

EDIT:
What filename should the file be named?

Posibilities:
Quote:cdart.png
cdart1.png & cdart2.png (because multidisc are supported maybe always add the disc number)
disc.png
disc1.png & disc2.png (because multidisc are supported maybe always add the disc number)

Always read the XBMC online-manual, FAQ and search the forums before posting.
Do NOT e-mail Team-XBMC members asking for support. Read/follow the forum rules.
For troubleshooting and bug reporting, make sure you read this first

For your mediacenter artwork go to
[Image: fanarttv.png]
(This post was last modified: 2012-01-05 21:12 by Martijn.)
find quote
ekim232 Offline
Posting Freak
Posts: 1,206
Joined: Nov 2008
Reputation: 5
Location: Chicago, IL
Post: #93
On 1.0.3 and I am using the below code for tvshows. I am not sure if this is normal behavior or not. When I click the button it activates the progessdialog as normal, but then I noticed that the dialogselect comes in behind it and becomes focused dialog, but not the top layed window. I cannot see what is is showing since it is not the top most dialog. I guess my question is if the script is set to pop up the dialogselect if there are several choices for a logo or whatever you are trying to grab. Or is this a skin/xbmc bug?

RunScript(script.artwork.downloader,mode=custom,mediatype=tvshow,medianame=$INFO​[ListItem.TVShowTitle],clearlogo)

[Image: screenshot003ca.png]

Uploaded with ImageShack.us
find quote
Martijn Offline
Team-XBMC
Posts: 10,997
Joined: Jul 2011
Reputation: 158
Location: Dawn of time
Post: #94
ekim232 Wrote:On 1.0.3 and I am using the below code for tvshows. I am not sure if this is normal behavior or not. When I click the button it activates the progessdialog as normal, but then I noticed that the dialogselect comes in behind it and becomes focused dialog, but not the top layed window. I cannot see what is is showing since it is not the top most dialog. I guess my question is if the script is set to pop up the dialogselect if there are several choices for a logo or whatever you are trying to grab. Or is this a skin/xbmc bug?

RunScript(script.artwork.downloader,mode=custom,mediatype=tvshow,medianame=$INFO​[ListItem.TVShowTitle],clearlogo)

It was requested that when you run it like that and more than one artwork was available the dialog select (DialogSelect.xml) pops-up and let the user decide.
Same like Logo-Downloader worked.
The 'searching for artwork' procesdialog should close first and then open the dialogselect.
Could you post the link (or PM) were i can find the skin source so i could test it out were it goes wrong?

Always read the XBMC online-manual, FAQ and search the forums before posting.
Do NOT e-mail Team-XBMC members asking for support. Read/follow the forum rules.
For troubleshooting and bug reporting, make sure you read this first

For your mediacenter artwork go to
[Image: fanarttv.png]
(This post was last modified: 2011-12-18 00:39 by Martijn.)
find quote
`Black Offline
Team-XBMC Member
Posts: 2,386
Joined: Apr 2009
Reputation: 66
Location: Germany
Post: #95
Looks like a modded version of a not recent version of my skin. Very likely a skin problem, doesn't have that problem with the latest version of my skin. Check out the zorder of the dialog windows.

[Image: xp1080-21.png]
find quote
Martijn Offline
Team-XBMC
Posts: 10,997
Joined: Jul 2011
Reputation: 158
Location: Dawn of time
Post: #96
Movie fix:
In case you had multiple versions of the same movie with the exact same title it would download the artwork to the first movie it encountered from the database query.
For example when you have the bluray and DVD version of 'Avatar'.
This is meant for movies so no need to apply this on tvshow because there's little chance they'll have the same name (it can be done though but have not tested this)

How-to use for movies:
Add extra argument to runscript
PHP Code:
mediapath=$INFO[ListItem.Path
Full example code:
PHP Code:
<onclick>XBMC.RunScript(script.artwork.downloader,mode=custom,mediatype=movie,medianame=$INFO[ListItem.Title],mediapath=$INFO[ListItem.Path],extrathumbs)</onclick
When no
PHP Code:
mediapath=$INFO[ListItem.Path
is provided script will still function normally. Can be applied to custom & gui mode when downloading for a single movie.

script.artwork.downloader-Eden(1.0.3)-RC5.zip

Note:
Skins can already be adapted to new version without causing any problem because the 'old' version will just ignore that extra argument.

As usual: If you find some bug, let me know. If you don't, still let me know Smile

Fixes 1.0.3
- Fixed: Error below limit check
- Fixed: Custom download for specific movie artwork only
- Fixed: Downloads artwork for selected movie when multiple exist with same name
Needs extra argument from skin.
- Fixed: Did not run service when set to 00->09
- Added: Try conversion of non standard IMDB Id

Always read the XBMC online-manual, FAQ and search the forums before posting.
Do NOT e-mail Team-XBMC members asking for support. Read/follow the forum rules.
For troubleshooting and bug reporting, make sure you read this first

For your mediacenter artwork go to
[Image: fanarttv.png]
(This post was last modified: 2011-12-20 00:43 by Martijn.)
find quote
ZombieRobot Offline
Fan
Posts: 710
Joined: May 2010
Reputation: 4
Location: Mount Maunganui , New Zealand
Post: #97
Martijn Wrote:Call to skinners:
I did some code cleanup and would like some feedback if all still functions like it should
script.artwork.downloader-Eden(1.0.3)-RC3.zip

Please let me know.


Just heads up what is coming when new http://fanart.tv site goes live. We still needs a lot more images so any help is much appreciated.
[Image: avatar4ee3dae9cf677.png]
[Image: avatarss.png]

EDIT:
What filename should the file be named?

Posibilities:


Awesome been wanting this for ages nice!!
find quote
Martijn Offline
Team-XBMC
Posts: 10,997
Joined: Jul 2011
Reputation: 158
Location: Dawn of time
Post: #98
Ronie,

What filename do you use for the movie cdart?
Because Artwork Downloader will be supporting those soon i'm looking for the best filename to use.

Always read the XBMC online-manual, FAQ and search the forums before posting.
Do NOT e-mail Team-XBMC members asking for support. Read/follow the forum rules.
For troubleshooting and bug reporting, make sure you read this first

For your mediacenter artwork go to
[Image: fanarttv.png]
find quote
mikebzh44 Offline
Posting Freak
Posts: 1,711
Joined: Nov 2011
Reputation: 47
Location: Nantes - France
Post: #99
Martijn Wrote:Call to skinners:
I did some code cleanup and would like some feedback if all still functions like it should
script.artwork.downloader-Eden(1.0.3)-RC3.zip

Please let me know.


Just heads up what is coming when new http://fanart.tv site goes live. We still needs a lot more images so any help is much appreciated.
[Image: avatar4ee3dae9cf677.png]
[Image: avatarss.png]

EDIT:
What filename should the file be named?

Posibilities:

cdart.png
cdart1.png & cdart2.png (because multidisc are supported maybe always add the disc number)
disc.png
disc1.png & disc2.png (because multidisc are supported maybe always add the disc number)
Hello.

Great job !!

For naming files, you should use film-cdart.png because, for people who have all movies in the same directory, only one cdart will be available Sad
find quote
Martijn Offline
Team-XBMC
Posts: 10,997
Joined: Jul 2011
Reputation: 158
Location: Dawn of time
Post: #100
mikebzh44 Wrote:Hello.

Great job !!

For naming files, you should use film-cdart.png because, for people who have all movies in the same directory, only one cdart will be available Sad

Sorry but no can do. Extrafanart/extrathumbs wil also only work when they have separate subfolders.
The same is for logo.png and clearart.png
Music cdart also works this way and i don't plan deviating from that.

You just will have to place every movie in it's own folder.

Always read the XBMC online-manual, FAQ and search the forums before posting.
Do NOT e-mail Team-XBMC members asking for support. Read/follow the forum rules.
For troubleshooting and bug reporting, make sure you read this first

For your mediacenter artwork go to
[Image: fanarttv.png]
(This post was last modified: 2011-12-20 08:49 by Martijn.)
find quote
mikebzh44 Offline
Posting Freak
Posts: 1,711
Joined: Nov 2011
Reputation: 47
Location: Nantes - France
Post: #101
OK. It's not a problem for me because I have a directory by film.

It was just a question.
find quote
Martijn Offline
Team-XBMC
Posts: 10,997
Joined: Jul 2011
Reputation: 158
Location: Dawn of time
Post: #102
mikebzh44 Wrote:OK. It's not a problem for me because I have a directory by film.

It was just a question.
No problem Wink
Every one should do that Big Grin

Always read the XBMC online-manual, FAQ and search the forums before posting.
Do NOT e-mail Team-XBMC members asking for support. Read/follow the forum rules.
For troubleshooting and bug reporting, make sure you read this first

For your mediacenter artwork go to
[Image: fanarttv.png]
find quote
fmronan Offline
Fan
Posts: 600
Joined: Dec 2010
Reputation: 4
Post: #103
If the name is avatar.png that's work with folder and subfolder
find quote
Martijn Offline
Team-XBMC
Posts: 10,997
Joined: Jul 2011
Reputation: 158
Location: Dawn of time
Post: #104
fmronan Wrote:If the name is avatar.png that's work with folder and subfolder

yes but for what artwork?
logo
cdart
clearart

You can't name them all the same and how are skins gonna handle that?
Why deviated on how tvshow are done. If you do it the same that saves skinners a lot of trouble.
We should at least do it all the same so that's why i started this discussion Smile
What do other skinners think (even when you are not gonna use it)?

Always read the XBMC online-manual, FAQ and search the forums before posting.
Do NOT e-mail Team-XBMC members asking for support. Read/follow the forum rules.
For troubleshooting and bug reporting, make sure you read this first

For your mediacenter artwork go to
[Image: fanarttv.png]
(This post was last modified: 2011-12-20 10:31 by Martijn.)
find quote
ronie Offline
Team-XBMC Member
Posts: 9,096
Joined: Jan 2009
Reputation: 157
Post: #105
Martijn Wrote:Ronie,

What filename do you use for the movie cdart?
Because Artwork Downloader will be supporting those soon i'm looking for the best filename to use.
T! currently uses disc.png, so imo it would be best to stick with that

Always read the XBMC online-manual, FAQ and search the forum before posting.
Do not PM or e-mail Team-XBMC members directly asking for support. Read/follow the forum rules.
For troubleshooting and bug reporting please make sure you read this first.
(This post was last modified: 2011-12-21 02:11 by ronie.)
find quote
Post Reply