[RELEASE] Artwork Downloader - Skin support

  Thread Rating:
  • 3 Votes - 4.67 Average
  • 1
  • 2
  • 3
  • 4
  • 5
Post Reply
Martijn Online
Team-XBMC
Posts: 7,698
Joined: Jul 2011
Reputation: 114
Location: Dawn of time
Post: #11
@Black & BigNoid
When using with the GUI dialog the cached version of the artwork will be replaced (hopefully). The skin reset is needed to reload all images so the new one will show up.
In the case of Aeon Nox for example most of the images are directly retrieved from the xbmc (thumbnail)database. This will require me to do some hacking to push those images into it. I haven't got around to that and I will need to make absolutely sure we don't crash the database of users while doing this.

This actually is the same method like Logo-Downloader uses. I copied that part of the code from it (thanks ppic Smile )

Problem still exists when user scraped with XBMC without any local NFO/artwork files present they won't be picked up. That is where the database hacking must come in. Or they will have to use the built-in 'get fanart/set thumbnail' and choose the local stored file.

Always read the XBMC online-manual, FAQ and search the forums before posting.
Do NOT e-mail Team-XBMC members asking for support. Read/follow the forum rules.
For troubleshooting and bug reporting, make sure you read this first


For your mediacenter artwork go to
[Image: fanarttv.png]
(This post was last modified: 2011-11-28 19:24 by Martijn.)
find quote
`Black Offline
Skilled Skinner
Posts: 2,002
Joined: Apr 2009
Reputation: 49
Location: Germany
Post: #12
I don't want to use the gui mode in my skin. I have buttons in settings where you can download e.g. landscape thumbs for the tv guide or extra fanart for all movies / tv shows if enabled. In the video info I have a custom dialog with get thumb / get fanart buttons from XBMC and additionally (if enabled) extra fanart, for tv shows also banner, logo and showthumb. Can't do this with artwork downloader or did I miss something?

So my requests are:
  • Don't force the user to configure something if not needed
  • Add attributes so skinners can run the script like they could with logo-downloader, i.e. RunScript(script.artwork.downloader,mediatype=tvshow,showthumb=landscape.jpg)

First request should be obsolete if the second is implemented because there are no settings needed.

[Image: xp1080.png]
find quote
Martijn Online
Team-XBMC
Posts: 7,698
Joined: Jul 2011
Reputation: 114
Location: Dawn of time
Post: #13
`Black Wrote:I don't want to use the gui mode in my skin. I have buttons in settings where you can download e.g. landscape thumbs for the tv guide or extra fanart for all movies / tv shows if enabled. In the video info I have a custom dialog with get thumb / get fanart buttons from XBMC and additionally (if enabled) extra fanart, for tv shows also banner, logo and showthumb. Can't do this with artwork downloader or did I miss something?

So my requests are:
  • Don't force the user to configure something if not needed
  • Add attributes so skinners can run the script like they could with logo-downloader, i.e. RunScript(script.artwork.downloader,mediatype=tvshow,showthumb=landscape.jpg)

First request should be obsolete if the second is implemented because there are no settings needed.

First one is already taken care of Smile

Second one will be implemented. TV next Aired will also need this Wink
Would it be ok if you could use something like this?:
Quote:RunScript(script.artwork.downloader,mode=custom,mediatype=tvshow,showthumb=true)​
or
RunScript(script.artwork.downloader,mode=custom,mediatype=tvshow,showthumb)
with multiple items
RunScript(script.artwork.downloader,mode=custom,mediatype=tvshow,extrafanart,ext​rathumbs)
Only specify the ones you do need.
So without the filename and it will use the standard ones or would you like to specify it your self?

Always read the XBMC online-manual, FAQ and search the forums before posting.
Do NOT e-mail Team-XBMC members asking for support. Read/follow the forum rules.
For troubleshooting and bug reporting, make sure you read this first


For your mediacenter artwork go to
[Image: fanarttv.png]
(This post was last modified: 2011-12-02 23:37 by Martijn.)
find quote
`Black Offline
Skilled Skinner
Posts: 2,002
Joined: Apr 2009
Reputation: 49
Location: Germany
Post: #14
Thanks. Smile

Second & third example is absolutely fine, I think filenames should always be default, keeps things consistent. What would you like to have for tv show next aired?

[Image: xp1080.png]
(This post was last modified: 2011-12-03 00:09 by `Black.)
find quote
Martijn Online
Team-XBMC
Posts: 7,698
Joined: Jul 2011
Reputation: 114
Location: Dawn of time
Post: #15
`Black Wrote:Thanks. Smile

Second & third example is absolutely fine, I think filenames should always be default, keeps things consistent.

Think so to about filenames. That way you won't have tons of different file laying around.

Will work on it. Will give you a bump to try it out.

Always read the XBMC online-manual, FAQ and search the forums before posting.
Do NOT e-mail Team-XBMC members asking for support. Read/follow the forum rules.
For troubleshooting and bug reporting, make sure you read this first


For your mediacenter artwork go to
[Image: fanarttv.png]
find quote
Martijn Online
Team-XBMC
Posts: 7,698
Joined: Jul 2011
Reputation: 114
Location: Dawn of time
Post: #16
`Black Wrote:Thanks. Smile

Second & third example is absolutely fine, I think filenames should always be default, keeps things consistent. What would you like to have for tv show next aired?

By popular demand:

Code:
RunScript(script.artwork.downloader,mode=custom,mediatype=tvshow,extrafanart,ban​ner)
RunScript(script.artwork.downloader,mode=custom,mediatype=movie,extrafanart,extr​athumbs)
or
Code:
RunScript(script.artwork.downloader,mode=custom,mediatype=tvshow,medianame=$INFO​[ListItem.TVShowTitle],extrafanart,banner)
RunScript(script.artwork.downloader,mode=custom,mediatype=movie,medianame=$INFO[ListItem.Title],extrafanart,extrathumbs)
Optional script arg (will only show pop-up on start/finish independent of add-on settings ):
Code:
silent=true

Specify as many artwork types as you like. When available of course.
How to use: see "/resources/dosc/runscript.txt" (forgot to add the silent=true in there)


script.artwork.downloader-Eden(1.0.1)-RC1.zip

Find any bugs let me know.

Always read the XBMC online-manual, FAQ and search the forums before posting.
Do NOT e-mail Team-XBMC members asking for support. Read/follow the forum rules.
For troubleshooting and bug reporting, make sure you read this first


For your mediacenter artwork go to
[Image: fanarttv.png]
(This post was last modified: 2011-12-03 03:23 by Martijn.)
find quote
`Black Offline
Skilled Skinner
Posts: 2,002
Joined: Apr 2009
Reputation: 49
Location: Germany
Post: #17
Thanks, I'll try it as soon as I can.

[Image: xp1080.png]
find quote
Martijn Online
Team-XBMC
Posts: 7,698
Joined: Jul 2011
Reputation: 114
Location: Dawn of time
Post: #18
`Black Wrote:Thanks, I'll try it as soon as I can.

ronie also updated TV Show Next Aired in combination with this. It's in his SVN

I tested it out on my setup and it should work Rolleyes

Always read the XBMC online-manual, FAQ and search the forums before posting.
Do NOT e-mail Team-XBMC members asking for support. Read/follow the forum rules.
For troubleshooting and bug reporting, make sure you read this first


For your mediacenter artwork go to
[Image: fanarttv.png]
(This post was last modified: 2011-12-03 04:41 by Martijn.)
find quote
Martijn Online
Team-XBMC
Posts: 7,698
Joined: Jul 2011
Reputation: 114
Location: Dawn of time
Post: #19
clear...

Always read the XBMC online-manual, FAQ and search the forums before posting.
Do NOT e-mail Team-XBMC members asking for support. Read/follow the forum rules.
For troubleshooting and bug reporting, make sure you read this first


For your mediacenter artwork go to
[Image: fanarttv.png]
(This post was last modified: 2011-12-03 04:41 by Martijn.)
find quote
Jeroen Offline
Skilled Skinner
Posts: 1,882
Joined: Feb 2008
Reputation: 4
Location: The Netherlands
Post: #20
A couple of things. I'm confused as to whether the script fetches logo images (not clearlogo). The readme mentions that it does, however in the runscript.txt at available options it isn't mentioned. I haven't been able to get logo images using:

PHP Code:
<onclick>RunScript(script.artwork.downloader,mode=custom,silent="true",mediatype=tvshow,logo)</onclick

Also, could the "finished" popup be turned into a notification? I really think it's redundant to have to confirm a successful operation.

Last, is it possible to have the user select the images from the results when more than one is found?
(This post was last modified: 2011-12-03 11:24 by Jeroen.)
find quote
Post Reply