[RELEASE] Artwork Downloader - Skin support

  Thread Rating:
  • 3 Votes - 4.67 Average
  • 1
  • 2
  • 3
  • 4
  • 5
Post Reply
Martijn Offline
Team-XBMC
Posts: 11,066
Joined: Jul 2011
Reputation: 158
Location: Dawn of time
Post: #31
`Black Wrote:Ok setting is not needed then. Smile

Edit: What do I do if I want to download i.e. extrafanart for both, movies and tv shows?

Edit2: Solo mode should always either download the artwork (if only 1 was found) or ask the user which to download (if more than 1 was found). No customgui mode necessary imo.

I now know why ronie needs so much beer Wink
Gonna get mee some more cases i think.

Well here you go:
script.artwork.downloader-Eden(1.0.1)-RC4.zip

PHP Code:
XBMC.RunScript(script.artwork.downloader,mode=custom,silent=trueextrafanart
Downloads for movies and tvshows. Same rules still apply. You can use multiple artwork. You can even specify 'clearlogo' because the movie section will just skip that.

When new fanart.tv site goes live it is possible that new artwork will become available.

Your edit2 will be worked on maybe tomorrow. I think i have to clean up the code some more because it's becoming a big mess

Always read the XBMC online-manual, FAQ and search the forums before posting.
Do NOT e-mail Team-XBMC members asking for support. Read/follow the forum rules.
For troubleshooting and bug reporting, make sure you read this first

For your mediacenter artwork go to
[Image: fanarttv.png]
(This post was last modified: 2011-12-03 14:20 by Martijn.)
find quote
`Black Offline
Team-XBMC Member
Posts: 2,396
Joined: Apr 2009
Reputation: 66
Location: Germany
Post: #32
Thanks and no hurry, take your time. Smile

[Image: xp1080-21.png]
find quote
Martijn Offline
Team-XBMC
Posts: 11,066
Joined: Jul 2011
Reputation: 158
Location: Dawn of time
Post: #33
`Black Wrote:Thanks and no hurry, take your time. Smile

Hope you like what we've done so far Rolleyes
It has come a long way sinds we first started it 3 months ago (and i had to learn python from scratch)

Always read the XBMC online-manual, FAQ and search the forums before posting.
Do NOT e-mail Team-XBMC members asking for support. Read/follow the forum rules.
For troubleshooting and bug reporting, make sure you read this first

For your mediacenter artwork go to
[Image: fanarttv.png]
find quote
Jeroen Offline
Skilled Skinner
Posts: 2,484
Joined: Feb 2008
Reputation: 22
Location: The Netherlands
Post: #34
Well, the learning paid off Smile Thanks, no rush!
find quote
`Black Offline
Team-XBMC Member
Posts: 2,396
Joined: Apr 2009
Reputation: 66
Location: Germany
Post: #35
Machine-Sanctum Wrote:Hope you like what we've done so far Rolleyes
It has come a long way sinds we first started it 3 months ago (and i had to learn python from scratch)

Of course I like it. Smile

There seems to be a problem with extrafanarts for tv shows, script doesn't download any, for movies it's working.

Another thing... I would like to run the custom mode for a single movie in the movie information dialog which is working fine but it should also ask if more than 1 artworks are found (except for extrafanart).

That should be all for now I think. Big Grin

[Image: xp1080-21.png]
(This post was last modified: 2011-12-03 15:10 by `Black.)
find quote
Martijn Offline
Team-XBMC
Posts: 11,066
Joined: Jul 2011
Reputation: 158
Location: Dawn of time
Post: #36
`Black Wrote:Of course I like it. Smile

There seems to be a problem with extrafanarts for tv shows, script doesn't download any, for movies it's working.
how did you start the script so i can reproduce?

Quote:Another thing... I would like to run the custom mode for a single movie in the movie information dialog which is working fine but it should also ask if more than 1 artworks are found (except for extrafanart).

That should be all for now I think. Big Grin
So like Jeroen asked if you run it for let's say 'clearlogo' it pop-up the dialog when it finds more than one? If only one just download

Always read the XBMC online-manual, FAQ and search the forums before posting.
Do NOT e-mail Team-XBMC members asking for support. Read/follow the forum rules.
For troubleshooting and bug reporting, make sure you read this first

For your mediacenter artwork go to
[Image: fanarttv.png]
(This post was last modified: 2011-12-03 15:27 by Martijn.)
find quote
`Black Offline
Team-XBMC Member
Posts: 2,396
Joined: Apr 2009
Reputation: 66
Location: Germany
Post: #37
RunScript(script.artwork.downloader,mode=custom,mediatype=tvshow,medianame=$INFO​[ListItem.TVShowTitle],extrafanart)

This is working for movies with mediatype = movie.

Machine-Sanctum Wrote:So like Jeroen asked if you run it for let's say 'clearlogo' it pop-up the dialog when it finds more than one? If only one just download

Exactly.

[Image: xp1080-21.png]
find quote
Martijn Offline
Team-XBMC
Posts: 11,066
Joined: Jul 2011
Reputation: 158
Location: Dawn of time
Post: #38
`Black Wrote:RunScript(script.artwork.downloader,mode=custom,mediatype=tvshow,medianame=$INFO​[ListItem.TVShowTitle],extrafanart)

No it wasn't working Wink
That was only because you had enabled it in add-on settings Blush
Should be fixed now so if you could try.

script.artwork.downloader-Eden(1.0.1)-RC5.zip

Always read the XBMC online-manual, FAQ and search the forums before posting.
Do NOT e-mail Team-XBMC members asking for support. Read/follow the forum rules.
For troubleshooting and bug reporting, make sure you read this first

For your mediacenter artwork go to
[Image: fanarttv.png]
find quote
`Black Offline
Team-XBMC Member
Posts: 2,396
Joined: Apr 2009
Reputation: 66
Location: Germany
Post: #39
Works like a charm, thanks.

[Image: xp1080-21.png]
find quote
Martijn Offline
Team-XBMC
Posts: 11,066
Joined: Jul 2011
Reputation: 158
Location: Dawn of time
Post: #40
`Black Wrote:Works like a charm, thanks.

thank god Cool

Will see about the solomode thingy when i find some time.

Will do some more testing and cleaning before doing PR to repo

Always read the XBMC online-manual, FAQ and search the forums before posting.
Do NOT e-mail Team-XBMC members asking for support. Read/follow the forum rules.
For troubleshooting and bug reporting, make sure you read this first

For your mediacenter artwork go to
[Image: fanarttv.png]
(This post was last modified: 2011-12-03 17:31 by Martijn.)
find quote
Martijn Offline
Team-XBMC
Posts: 11,066
Joined: Jul 2011
Reputation: 158
Location: Dawn of time
Post: #41
Repo update:
Version 1.0.1 should be in there with 'mode=custom' goodies.

Without
Quote:So like Jeroen asked if you run it for let's say 'clearlogo' it pop-up the dialog when it finds more than one? If only one just download

I will take some time for this to make it properly coded.

Always read the XBMC online-manual, FAQ and search the forums before posting.
Do NOT e-mail Team-XBMC members asking for support. Read/follow the forum rules.
For troubleshooting and bug reporting, make sure you read this first

For your mediacenter artwork go to
[Image: fanarttv.png]
find quote
fmronan Offline
Fan
Posts: 600
Joined: Dec 2010
Reputation: 4
Post: #42
I try to add your script to my skin "Glass", all works well for tvshow but not for movies.
I use
Code:
                    <control type="button" id="193">
                        <description>Run Logo Downloader</description>
                        <include>ButtonMediaSubCommonValues</include>
                        <label>Download extrafanarts</label>
                        <onclick condition="Container.Content(movies)">XBMC.RunScript(script.artwork.downloader,mode=custom, mediatype=movie, medianame=$INFO[ListItem.Title],extrafanart)</onclick>
                        <onclick>SetFocus(50)</onclick>
                        <visible>Container.Content(movies)+system.hasaddon(script.artwork.downloader)+!StringC​ompare(ListItem.Label,..)</visible>
                    </control>
Where is the problem? the script run , but it don't find extrafanart

[Image: 1323016778-screenshot002.png]

[Image: 1323016878-screenshot003.png]
find quote
`Black Offline
Team-XBMC Member
Posts: 2,396
Joined: Apr 2009
Reputation: 66
Location: Germany
Post: #43
That was a bug and should be fixed now.

[Image: xp1080-21.png]
find quote
fmronan Offline
Fan
Posts: 600
Joined: Dec 2010
Reputation: 4
Post: #44
I have the last revision 1.0.1
find quote
Martijn Offline
Team-XBMC
Posts: 11,066
Joined: Jul 2011
Reputation: 158
Location: Dawn of time
Post: #45
fmronan Wrote:I have the last revision 1.0.1

I copy/paste you script run and it's working fine for me.
Got 29 for avatar.

Even with all add-on settings to off (tvshow/movie/limiter)

EDIT:
I'm no skinner so I only test this modifying DialogVideoInfo.xml

Always read the XBMC online-manual, FAQ and search the forums before posting.
Do NOT e-mail Team-XBMC members asking for support. Read/follow the forum rules.
For troubleshooting and bug reporting, make sure you read this first

For your mediacenter artwork go to
[Image: fanarttv.png]
(This post was last modified: 2011-12-04 19:19 by Martijn.)
find quote
Post Reply