[RELEASE] Artwork Downloader - Skin support

  Thread Rating:
  • 3 Votes - 4.67 Average
  • 1
  • 2
  • 3
  • 4
  • 5
Post Reply
Sharpe Offline
Skilled Skinner
Posts: 1,030
Joined: Jul 2006
Reputation: 13
Location: North West England
Post: #61
Right - sorry that's what I meant for my situation when I use the artwork downloader to grab TV images. I think your issue is something similar though - another script perhaps.
find quote
Martijn Offline
Team Kodi
Posts: 11,441
Joined: Jul 2011
Reputation: 165
Location: Dawn of time
Post: #62
The automatic GUI pop-up for the custom mode is almost done. So should be available soon.

Always read the XBMC online-manual, FAQ and search the forums before posting.
Do NOT e-mail Team-XBMC members asking for support. Read/follow the forum rules.
For troubleshooting and bug reporting, make sure you read this first

For your mediacenter artwork go to
[Image: fanarttv.png]
find quote
Martijn Offline
Team Kodi
Posts: 11,441
Joined: Jul 2011
Reputation: 165
Location: Dawn of time
Post: #63
If all is well you are now getting the image list so the user can select the image when there are multiple available. When only one it will just download.
This will only happen when ONE arttype and the tvshow/movie title is provided . When multiple are provide for example (clearlogo,banner) is will just do a normal download.

script.artwork.downloader-Eden(1.0.2)-RC3.zip

If you find any bug let me know. If no one has any issue after testing it can go to repo.

EDIT:
Replaced the url because there was a flaw in the code.

Always read the XBMC online-manual, FAQ and search the forums before posting.
Do NOT e-mail Team-XBMC members asking for support. Read/follow the forum rules.
For troubleshooting and bug reporting, make sure you read this first

For your mediacenter artwork go to
[Image: fanarttv.png]
(This post was last modified: 2011-12-10 04:01 by Martijn.)
find quote
`Black Offline
Team-Kodi Member
Posts: 2,436
Joined: Apr 2009
Reputation: 72
Location: Germany
Post: #64
Thanks, works great.

[Image: xp1080-21.png]
find quote
Martijn Offline
Team Kodi
Posts: 11,441
Joined: Jul 2011
Reputation: 165
Location: Dawn of time
Post: #65
`Black Wrote:Thanks, works great.

That's great.

Make sure you test all the options because we also did some code shuffle.
I'll wait for others to have tested it and hope there will be no bugreports.

Always read the XBMC online-manual, FAQ and search the forums before posting.
Do NOT e-mail Team-XBMC members asking for support. Read/follow the forum rules.
For troubleshooting and bug reporting, make sure you read this first

For your mediacenter artwork go to
[Image: fanarttv.png]
find quote
fmronan Offline
Fan
Posts: 600
Joined: Dec 2010
Reputation: 4
Post: #66
for me the script run but it find nothing
Code:
Artwork Downloader: ## Solo mode: Movie...
11:41:02 T:2730576752   DEBUG: Artwork Downloader: Using JSON for retrieving movie info
11:41:02 T:2730576752   DEBUG: RunQuery took 2 ms for 27 items query: select * from movieview
11:41:02 T:2730576752   DEBUG: Artwork Downloader: Retrieving fanart for: Avatar
11:41:02 T:2730576752   DEBUG: Artwork Downloader: ########################################################
11:41:02 T:2730576752  NOTICE: Artwork Downloader: Processing media: Avatar
11:41:02 T:2730576752   DEBUG: Artwork Downloader: ID: 499549
11:41:02 T:2730576752   DEBUG: Artwork Downloader: Path: /media/Disq500GO/Mes videos/FILM/Avatar
11:41:02 T:2730576752   DEBUG: Artwork Downloader: API: http://api.themoviedb.org/2.1/Movie.getImages/en/xml/4be68d7eab1fbd1b6fd8a3b80a65a95e/499549
11:41:03 T:2730576752   DEBUG: Artwork Downloader: Error getting data from TMDB (499549 not found): skipping
11:41:03 T:2730576752   DEBUG: Artwork Downloader: ########################################################
11:41:03 T:2730576752   DEBUG: Artwork Downloader: Nothing to download
11:41:03 T:2730576752   DEBUG: Artwork Downloader: ########################################################
11:41:03 T:2730576752   DEBUG: Artwork Downloader: Cleaning up temp files
11:41:03 T:2730576752   DEBUG: Artwork Downloader: Deleted temp directory: /home/guevel/.xbmc/userdata/addon_data/script.artwork.downloader/temp
find quote
`Black Offline
Team-Kodi Member
Posts: 2,436
Joined: Apr 2009
Reputation: 72
Location: Germany
Post: #67
The ID is wrong... which scraper do you use? I believe only imdb or themoviedb will work because of the ID! 19995 would be the correct ID for Avatar (2009).

[Image: xp1080-21.png]
find quote
Martijn Offline
Team Kodi
Posts: 11,441
Joined: Jul 2011
Reputation: 165
Location: Dawn of time
Post: #68
It is probably a themoviedb ID because we only search on tmdb. We can add it though.

Always read the XBMC online-manual, FAQ and search the forums before posting.
Do NOT e-mail Team-XBMC members asking for support. Read/follow the forum rules.
For troubleshooting and bug reporting, make sure you read this first

For your mediacenter artwork go to
[Image: fanarttv.png]
find quote
Jeroen Offline
Skilled Skinner
Posts: 2,499
Joined: Feb 2008
Reputation: 23
Location: The Netherlands
Post: #69
Thanks for making the artwork user selectable, working great Smile

I don't like to keep nagging about this, but could the "finished" dialogs be turned into a notification as well? Imo these messages are purely to notify the user of an either successful or failed download attempt. No choices have to be made by the user, so I think a notification is the proper way to give this information. The same goes for the "canceled by user" dialog.

In any case, great work Nod
find quote
Martijn Offline
Team Kodi
Posts: 11,441
Joined: Jul 2011
Reputation: 165
Location: Dawn of time
Post: #70
Jeroen Wrote:Thanks for making the artwork user selectable, working great Smile

I don't like to keep nagging about this, but could the "finished" dialogs be turned into a notification as well? Imo these messages are purely to notify the user of an either successful or failed download attempt. No choices have to be made by the user, so I think a notification is the proper way to give this information. The same goes for the "canceled by user" dialog.

In any case, great work Nod

I could make it to display the notification when run custom for one tvshow/movie.

Problem is that a notification has only two line and we wanted to display the the providers to get more users to those sites like logo downloader did.
[Image: screenshot053w.png]

The notification dialog only support 2 text lines instead of 4.
We could display it on those 2 lines but then we have to increase the display time or make two notification after each other.
Any ideas?

Always read the XBMC online-manual, FAQ and search the forums before posting.
Do NOT e-mail Team-XBMC members asking for support. Read/follow the forum rules.
For troubleshooting and bug reporting, make sure you read this first

For your mediacenter artwork go to
[Image: fanarttv.png]
find quote
Martijn Offline
Team Kodi
Posts: 11,441
Joined: Jul 2011
Reputation: 165
Location: Dawn of time
Post: #71
fmronan Wrote:for me the script run but it find nothing
Code:
Artwork Downloader: ## Solo mode: Movie...
11:41:02 T:2730576752   DEBUG: Artwork Downloader: Using JSON for retrieving movie info
11:41:02 T:2730576752   DEBUG: RunQuery took 2 ms for 27 items query: select * from movieview
11:41:02 T:2730576752   DEBUG: Artwork Downloader: Retrieving fanart for: Avatar
11:41:02 T:2730576752   DEBUG: Artwork Downloader: ########################################################
11:41:02 T:2730576752  NOTICE: Artwork Downloader: Processing media: Avatar
11:41:02 T:2730576752   DEBUG: Artwork Downloader: ID: 499549
11:41:02 T:2730576752   DEBUG: Artwork Downloader: Path: /media/Disq500GO/Mes videos/FILM/Avatar
11:41:02 T:2730576752   DEBUG: Artwork Downloader: API: http://api.themoviedb.org/2.1/Movie.getImages/en/xml/4be68d7eab1fbd1b6fd8a3b80a65a95e/499549
11:41:03 T:2730576752   DEBUG: Artwork Downloader: Error getting data from TMDB (499549 not found): skipping
11:41:03 T:2730576752   DEBUG: Artwork Downloader: ########################################################
11:41:03 T:2730576752   DEBUG: Artwork Downloader: Nothing to download
11:41:03 T:2730576752   DEBUG: Artwork Downloader: ########################################################
11:41:03 T:2730576752   DEBUG: Artwork Downloader: Cleaning up temp files
11:41:03 T:2730576752   DEBUG: Artwork Downloader: Deleted temp directory: /home/guevel/.xbmc/userdata/addon_data/script.artwork.downloader/temp

It's indeed a problem with the ID
It should be
PHP Code:
tt0499549 
http://www.imdb.com/title/tt0499549/

`Black Wrote:The ID is wrong... which scraper do you use? I believe only imdb or themoviedb will work because of the ID! 19995 would be the correct ID for Avatar (2009).

At the moment we only search by IMDB ID so would it be a good idea to also search by TMDB ID when no IDMB ID is found?

Always read the XBMC online-manual, FAQ and search the forums before posting.
Do NOT e-mail Team-XBMC members asking for support. Read/follow the forum rules.
For troubleshooting and bug reporting, make sure you read this first

For your mediacenter artwork go to
[Image: fanarttv.png]
(This post was last modified: 2011-12-11 15:04 by Martijn.)
find quote
Jeroen Offline
Skilled Skinner
Posts: 2,499
Joined: Feb 2008
Reputation: 23
Location: The Netherlands
Post: #72
Martijn Wrote:I could make it to display the notification when run custom for one tvshow/movie.
That would be enough as far as I'm concerned Smile

Quote:Problem is that a notification has only two line and we wanted to display the the providers to get more users to those sites like logo downloader did.
[Image: screenshot053w.png]

The notification dialog only support 2 text lines instead of 4.
We could display it on those 2 lines but then we have to increase the display time or make two notification after each other.
Any ideas?
I see. Increasing the display time seems cleaner to me. Maybe the first and second line could be combined? Something like:

"Artwork Downloader: 1 downloaded"

That would still leave 2 lines, but those could be combined. By combining the first lines at least any scrolling would be kept to a minimum.
(This post was last modified: 2011-12-11 15:13 by Jeroen.)
find quote
Martijn Offline
Team Kodi
Posts: 11,441
Joined: Jul 2011
Reputation: 165
Location: Dawn of time
Post: #73
@Jeroen (and others)

Could you try this one?
script.artwork.downloader-Eden(1.0.2)-RC5.zip

Do only notify on finished custom/gui mode

Always read the XBMC online-manual, FAQ and search the forums before posting.
Do NOT e-mail Team-XBMC members asking for support. Read/follow the forum rules.
For troubleshooting and bug reporting, make sure you read this first

For your mediacenter artwork go to
[Image: fanarttv.png]
(This post was last modified: 2011-12-11 17:48 by Martijn.)
find quote
`Black Offline
Team-Kodi Member
Posts: 2,436
Joined: Apr 2009
Reputation: 72
Location: Germany
Post: #74
Martijn Wrote:At the moment we only search by IMDB ID so would it be a good idea to also search by TMDB ID when no IDMB ID is found?

TMDB scraper uses IMDB ID.

[Image: xp1080-21.png]
find quote
Martijn Offline
Team Kodi
Posts: 11,441
Joined: Jul 2011
Reputation: 165
Location: Dawn of time
Post: #75
`Black Wrote:TMDB scraper uses IMDB ID.

I think most scrapers use IMDB ID.
Why the scraper he used removed the 'tt0' of 'tt0499549' is bit strange.

Always read the XBMC online-manual, FAQ and search the forums before posting.
Do NOT e-mail Team-XBMC members asking for support. Read/follow the forum rules.
For troubleshooting and bug reporting, make sure you read this first

For your mediacenter artwork go to
[Image: fanarttv.png]
find quote
Post Reply