[RELEASE] Demand 5 (Video) Addon - UK Channel 5 on demand

I can't speak for nibor but given that this plugin works perfectly in Dharma I would hazard a guess that it is more than likely a problem with Eden rather than the plugin itself (updated libraries?).

I have spent quite a while trying to fix it but without success but for any coders looking in it appears to be a problem with the encoding of the pyamf.remoting.Envelope

One thing I have noticed in Eden is that whilst the plugin is downloading an episode it also streams other episodes correctly (to allow this you need to comment out the final while loop in the download code), as soon as the download completes then it starts giving scripts errors.

OK, I think I've cracked the script error in Eden Beta 2

in .xbmc/addons/plugin.video.demand5/pyamf/xml.py around line 72

add a try / except block around the call thus:



Modified copy here
Also, for convenience a default.py with spoyser's fixed episode parsing.

zuccster Wrote:OK, I think I've cracked the script error in Eden Beta 2

in .xbmc/addons/plugin.video.demand5/pyamf/xml.py around line 72

add a try / except block around the

Code:

t = _get_etree_type(etree)

call thus:

Code:

try:
            t = _get_etree_type(etree)
        except TypeError:
            continue

Modified copy here
Also, for convenience a default.py with spoyser's fixed episode parsing.

Good one!!

Weird thing is I was just looking at that line, put a try/except in to see what was going on and lo and behold found that it then worked!

Not sure if it is a bug in the pyamf libraries themselves (surely they have been tested to death by now!) or the way they are being used by the plugin, or why it is only in Eden, but who cares it works. I can finally upgrade the living room XBMC to Eden (my 6 year old wouldn't let me until Milkshake worked!!)

zuccster Wrote:Modified copy here
Also, for convenience a default.py with spoyser's fixed episode parsing.

Dude, for a high gaf (like waf, but living in sin!) demand5 is essential. This is a solid fix and you have my thanks!

+thanks to Spoyser for the parsing fix, too.

Anyone let Nibor know about the fixes? Haven't seen any activity on his repo...

Jim

I've just PM'ed him.

Cool fix man, thank you!

Any reason why this fix wouldn't work in Linux? Just tried it and it won't play anything at all now.

tdw197 Wrote:Any reason why this fix wouldn't work in Linux? Just tried it and it won't play anything at all now.

Works OK for me on Linux. OS should make no difference. Is there anything in the log?

zuccster Wrote:Works OK for me on Linux. OS should make no difference. Is there anything in the log?

Will have a look once I can get the wife away from it...

Is there any chance you any would upload a compiled fix copy of the plugin . Since I only have a iPad, no windows I can't download the py file