2005-05-06, 21:22
i've noticed that when playing videos from my xbms share on my network, after i'd watch one it would disappear from the list. i quickly realized that this was because the items in the directory were sorted by time and it was just moving to the end of the list.
xbmsdirectory.cpp sets the item's m_sttime member to the last access time of the file. this is inconsistent with smbdirectory and a local directory, where they use the last modification time. (i believe xns directories also do this, but i didn't check the server source). the modification would have be simple in xbmc/filesystems/xbmsdirectory.cpp starting on line 173 just replacing <access> with <modification> and </access> with </modification>. there are 3 total lines which would have to be updated.
i think this should be done to maintain consistency, as well as be in line with what ls --sort=time or dir /od outputs. is there any reason not to do this?
xbmsdirectory.cpp sets the item's m_sttime member to the last access time of the file. this is inconsistent with smbdirectory and a local directory, where they use the last modification time. (i believe xns directories also do this, but i didn't check the server source). the modification would have be simple in xbmc/filesystems/xbmsdirectory.cpp starting on line 173 just replacing <access> with <modification> and </access> with </modification>. there are 3 total lines which would have to be updated.
i think this should be done to maintain consistency, as well as be in line with what ls --sort=time or dir /od outputs. is there any reason not to do this?
