pecinko Wrote:Ability to define minimal XBMC version by skin:
There are many posts by users installing skin for nightly builds on stable release and running into all kinds of problem. It is not obvious if skin problems are related to this and users do not offer enough info for troubleshooting.
If skin could specify minimal XBMC version requirement which will prevent add-on install on unsupported XBMC builds, this situation could be avoided.
Discussed this a while ago here, not sure what's happened since though.
Hitcher Wrote:I tried using <minversion app="xbmc">177d3cb</minversion> in my addon.xml because that's the how the nightly is labelled (xbmc-r177d3cb-master.exe) and that's also the build found in the system info but when I tested this using Dharma the skin still updated.
What's the correct method now?
jmarshall Wrote:Neither. The tag is completely useless, and really should not be there at all.
Instead, we should be bumping the API version when things are added. I haven't as yet as we haven't agreed on how this should be done during the "things are in flux and might change quite a bit" phase of development.
I'll see if I can start a discussion about this and come up with some guidelines.
jmarshall Wrote:Ok, had a quick chat with Cory - I think the plan for now is:
1. Check the versioning stuff does what it should do.
2. Bump the version and ensure that the user is informed as to why they can't load/install the skin (The dependency check is currently done after load unfortunately).
3. Look at when we should bump versions. This will probably become apparent after a while.
Other things to help is that we'll be looking at getting the buildbot to build my branch (or perhaps master + guilib branch merged) as I need it so that you guys can test out new code before it gets in - that way we should hopefully get more places where the feature goes in complete with version bump.
Unfortunately I suspect the version checks aren't done at all in Dharma, so it probably won't help with users attempting to install your skin there - never know though, we might be lucky!