Posts: 26,215
Joined: Oct 2003
Reputation:
187
one of the new devs (spiff) is looking into rar support at the moment. i'll leave him to comment on his progress.
it would perhaps be handy if you could suggest how you think the rarred vobsubs stuff should go? i'm thinking along the lines of when to check for rarred subs, and how the naming of the unrarred subs should go etc.
as you say, the patch on sf is a little dated now as the subtitle loading system was rewritten a fair amount between then and now, but if you have spent time integrating it in the past, you're probably the one with the most recent knowledge on it.
cheers,
jonathan
Posts: 12,706
Joined: Nov 2003
Reputation:
129
spiff
Team-Kodi Member
Posts: 12,706
hi,
i'm working on the rar support, based on stgcoli's work.
i've got it working as a "share" at the moment. the plan is to make .rar's completely transparent to xbmc's underlieing file routines.
might sound a bit strange to make .rar's be shares, but it is the best way to implement them..
compressed vobsubs will come as a bonus (that part of stg's patch was outdated as you said) once i've got everything else as i'd like.. (not my top priority iotw).
spiff
Posts: 26,215
Joined: Oct 2003
Reputation:
187
butcher implemented vmm code for vobsubs ages ago, so once they're unrarred to disk, it's no problem at all.
Posts: 39
Joined: Jan 2004
Reputation:
0
sergej
Junior Member
Posts: 39
great if spiff is working on it!
as for rarred subs i think it would be best to add .rar as second possibility (first being unrarred .sub) together with an idx, rar has to be the same name as the avi (and the idx of course), the .sub file inside the rar usually has the same name, too, but can be different (windows vobsub supports that). if extracting to hd you of course have to consider that the .sub filename inside the rar could be > 42 chars.
i don't think there is any point if i write another simple subtitle unrar routine if something fancier is on the way.
my knowledge of the unrar library doesn't go very deep, so i doubt i could help a lot with a complex unrar functionality, but i can always try to help...
i don't think vmm is necessary since the unrar library can extract big rars without a problem, so you can just extract it to a temp space on the disk. most of the .sub files aren't very big either, so the time it takes to extract probably is negligible. and big .sub's already are loaded dynamically i think...
Posts: 12,706
Joined: Nov 2003
Reputation:
129
spiff
Team-Kodi Member
Posts: 12,706
finally got around to adding it. sorry for the wait
supports idx+rar, idx+(sub in rar) and rar with (idx+rar).
spiff
Posts: 12,706
Joined: Nov 2003
Reputation:
129
spiff
Team-Kodi Member
Posts: 12,706
donj,
within the .rar they can be called whatever. outside they have to have the 'same name'. will see what i can cook up later
edit: typo
Posts: 530
Joined: May 2005
Reputation:
5
DonJ
Retired Team-Kodi Member
Posts: 530
sounds good :thumbsup:
thx for your great work spiff!
Posts: 23
Joined: Apr 2004
Reputation:
0
great work spiff!
what would be nice is a progress bar to see loading progress.
but i do of course understand if you don't have the time or just don't want to do it!
Posts: 12,706
Joined: Nov 2003
Reputation:
129
spiff
Team-Kodi Member
Posts: 12,706
hi,
uncompression should really not take a very long time.. adding a progress dialog there might be possible, since rar supports callbacks, just not sure they are enabled in the xbox version. i can have a look.
also the high loading times are not caused by uncompression, but by initialization of the vobsub-reader. a bit of profiling is on my todo list