[skimshady]

Hi all!

Code:

<videolibrary>
<cleanonupdate>true</cleanonupdate>
</videolibrary>

Could this setting be made more robust? At the moment I have been informed that this can cause the whole Library DB to be wiped out, if connection to the Media NAS is incidentally down when library updates itself.

Normally, I would always want to securely remove media from the library that has been deleted from the Media Source.

Can I suggest for the Team to implement a pre-check to verify that the source connection is working and that some of the current files at the source are found? If this pre-check fails -> don't perform the cleanup.

If it is made secure like this, it can maybe become the default behaviour too for all library updates, and not an "advanced setting".

[mkortstiege]

There's a good reason it's not in the GUI. How should XBMC know that the source is your NAS and that it is offline and not just a random network source that's not available any longer?

[GreenEyez]

There's a good reason it's not in the GUI. How should XBMC know that the source is your NAS and that it is offline and not just a random network source that's not available any longer?

An option to specify that the source can be offline at certain times when adding that certain source to the library would fit the bill.

That way XBMC will only wipe out that source path only if you remove your source totally from the video sources menu

[skimshady]

An option to specify that the source can be offline at certain times when adding that certain source to the library would fit the bill.

That way XBMC will only wipe out that source path only if you remove your source totally from the video sources menu

Yes, cleaning without wiping is a much needed feature Gets tiresome to clean manually!

[mkortstiege]

Please file a new feature request ticket. Maybe we can address it after the upcoming Eden release.

[ghostelement]

+1 for this request. @bthusby let me know if you need any help putting in the request ticket.

[skimshady]

+1 for this request. @bthusby let me know if you need any help putting in the request ticket.

Yes, I have never made a ticket. Can you at least point me in the direction?

[ghostelement]

Yes, I have never made a ticket. Can you at least point me in the direction?

Just go here and follow the directions. http://trac.xbmc.org/

[skimshady]

Ticket #12597

[Ozymandyaz]

I am hugely in favor of this request but would offer these suggestions:

1 - I agree that there should be an allowance for off-line sources (or perhaps even if more then 50% of the source is missing), and by default I would ignore off-line sources and not delete any data from the database if the source for the data is not accessible.

2 - In order to allow for off-line sources, add a GUI warning that states "the source <source name> is not available. Would you like to ignore this source during clean up or remove all entries in the database that reference this source? [Delete data] [Ignore Source]

2.1 - OR - In cases where a lot of data will change, i.e. more then 50% (or some other amount) of content will be removed from the database related to that source, give a similar warning:"A significant number of items are no longer found in the source <source name>. Would you still like to clean up this source, or ignore it this time? [Ignore this source] [Continue to clean this source]

3 - Possibly add an additional cleanup verification. At the end of the clean-up, show a list of all items that will be deleted from the library and a warning that lists all of the items to be removed. Give the option to either remove all or ignore all. Though this may be difficult to implement, a little confusing to users and is probably unnecessary if the above items are added.

And finally, because some people will love this and some people will hate it, add some advancedsettings.xml overrides:

<videolibrary>
<cleanonupdate>true</cleanonupdate>
<IgnoreBrokenSourceOnClean>{YES,no,ask}<IgnoreBrokenSourceOnClean>
<WarnOnLargeCleanup>{YES,no,ask}<WarnOnLargeCleanup>
<ShowItemsToClean>{YES,no}<ShowItemsToClean>
</videolibrary>

[skimshady]

Very good and relevant additions to my proposal

[pjgm]

I have last Eden (with mq3)

My movies are on a Qnap NAS and every time I want to delete one or two movies from it I can't use the clean library feature... because whole Library gets wiped out.

cleaning one by one it sucks...

So I need this too

cheers
pjgm

[Khendon]

should be able to do a scipt that will check if the NAS is connected, if it is then runs the clean command, if not, nothing

[zag]

A simple check for the source to be online before the clean function would fix this.

[DJVege]

zag2me, unless I'm missing something, that would be a great, simple fix.