[PATCH] Fix for all RAR and ZIP subtitles getting loaded

  Thread Rating:
  • 0 Votes - 0 Average
  • 1
  • 2
  • 3
  • 4
  • 5
Post Reply
devkid Offline
Senior Member
Posts: 197
Joined: Jul 2011
Reputation: 5
Post: #1
Hey guys,

this is meant as a patch for this ticket:
http://trac.xbmc.org/ticket/12719

I added the patch to the ticket. Thats my first patch to XBMC sources so handle with care Wink Comment are welcome.

Seeing this patch still making it into Eden would be awesome because this bug is bothering me for quite a while...
find quote
jmarshall Offline
Team-XBMC Developer
Posts: 26,230
Joined: Oct 2003
Reputation: 177
Post: #2
Cheers - mind doing a pull req for this so that it gets out to the devs who deal with this code quickly?

Always read the XBMC online-manual, FAQ and search the forum before posting.
Do not e-mail XBMC-Team members directly asking for support. Read/follow the forum rules.
For troubleshooting and bug reporting please make sure you read this first.


[Image: badge.gif]
find quote
devkid Offline
Senior Member
Posts: 197
Joined: Jul 2011
Reputation: 5
Post: #3
I am quite a git noob. I tried to do it and I hope I have it right now.
I cloned the repository on github and commited my patch into my new repo. Then I created a pull request from my repo to the original xbmc repo. Is this correct?

Btw there is a "merge" that is part of my pull request. No idea why, I am sorry for that Frown

https://github.com/xbmc/xbmc/pull/746
find quote
jmarshall Offline
Team-XBMC Developer
Posts: 26,230
Joined: Oct 2003
Reputation: 177
Post: #4
Have commented on the pull req as to how to avoid it in future (and fix it now) Smile

Always read the XBMC online-manual, FAQ and search the forum before posting.
Do not e-mail XBMC-Team members directly asking for support. Read/follow the forum rules.
For troubleshooting and bug reporting please make sure you read this first.


[Image: badge.gif]
find quote
DDDamian Offline
Team-XBMC Developer
Posts: 3,030
Joined: Sep 2011
Reputation: 254
Location: Canada
Post: #5
Congrats devkid Smile

System: XBMC HTPC with HDMI WASAPI & AudioEngine - Denon AVR-3808CI - Denon DVD-5900 Universal Player - Denon DCM-27 CD-Changer
- Sony BDP-S580 Blu-Ray - X-Box 360 - Android tablet wireless remote - 7.1 Streem/Axiom/Velodyne Surround System
If I have been able to help feel free to add to my reputation +/- below - thanks!
find quote
devkid Offline
Senior Member
Posts: 197
Joined: Jul 2011
Reputation: 5
Post: #6
Wow, I even thought it was a cool idea to merge the xbmc's master in again before I did that pull request. Well, it was not Cool

I had to google a bit to find out what that "rebase" stuff means, but I feel enlightened now Smile And I think I have it right now. Big thanks gentlemen!
find quote
jmarshall Offline
Team-XBMC Developer
Posts: 26,230
Joined: Oct 2003
Reputation: 177
Post: #7
Yup, looks good.

Always read the XBMC online-manual, FAQ and search the forum before posting.
Do not e-mail XBMC-Team members directly asking for support. Read/follow the forum rules.
For troubleshooting and bug reporting please make sure you read this first.


[Image: badge.gif]
find quote
mad-max Offline
Posting Freak
Posts: 1,479
Joined: Jul 2010
Reputation: 57
Location: Germany
Post: #8
Looks better now with the commit...
Had same problems with my PR a few days ago...
Got it sorted with the awesome help ( and patience ) from jmarshall...

[Image: obi3o55x.jpg]
[Image: 7c8w3bu8.png]

- - - Tribute to Metallica - - -

If I managed to help you, please click my reputation
find quote