[PATCH] Fix for all RAR and ZIP subtitles getting loaded

devkid · 2012-02-29 00:07

Hey guys,

this is meant as a patch for this ticket:
http://trac.xbmc.org/ticket/12719

I added the patch to the ticket. Thats my first patch to XBMC sources so handle with care Wink

Comment are welcome.

Seeing this patch still making it into Eden would be awesome because this bug is bothering me for quite a while...

**jmarshall** · 2012-02-29 00:20

Cheers - mind doing a pull req for this so that it gets out to the devs who deal with this code quickly?

devkid · 2012-03-01 22:57

I am quite a git noob. I tried to do it and I hope I have it right now.
I cloned the repository on github and commited my patch into my new repo. Then I created a pull request from my repo to the original xbmc repo. Is this correct?

Btw there is a "merge" that is part of my pull request. No idea why, I am sorry for that Frown

https://github.com/xbmc/xbmc/pull/746

**jmarshall** · 2012-03-01 23:11

Have commented on the pull req as to how to avoid it in future (and fix it now) Smile

**DDDamian** · 2012-03-01 23:14

Congrats devkid Smile

devkid · 2012-03-02 00:06

Wow, I even thought it was a cool idea to merge the xbmc's master in again before I did that pull request. Well, it was not Cool

I had to google a bit to find out what that "rebase" stuff means, but I feel enlightened now Smile

And I think I have it right now. Big thanks gentlemen!

**jmarshall** · 2012-03-02 00:10

Yup, looks good.

mad-max · 2012-03-02 00:11

Looks better now with the commit...
Had same problems with my PR a few days ago...
Got it sorted with the awesome help ( and patience ) from jmarshall...

devkid Senior Member Posts: 147 Joined: Jul 2011 Reputation: 4	2012-02-29 00:07 Post: #1 Hey guys, this is meant as a patch for this ticket: http://trac.xbmc.org/ticket/12719 I added the patch to the ticket. Thats my first patch to XBMC sources so handle with care Comment are welcome. Seeing this patch still making it into Eden would be awesome because this bug is bothering me for quite a while...
	find quote

jmarshall Team-XBMC Developer Posts: 24,523 Joined: Oct 2003 Reputation: 138	2012-02-29 00:20 Post: #2 Cheers - mind doing a pull req for this so that it gets out to the devs who deal with this code quickly? Always read the XBMC online-manual, FAQ and search the forum before posting. Do not e-mail XBMC-Team members directly asking for support. Read/follow the forum rules. For troubleshooting and bug reporting please make sure you read this first.
	find quote

devkid Senior Member Posts: 147 Joined: Jul 2011 Reputation: 4	2012-03-01 22:57 Post: #3 I am quite a git noob. I tried to do it and I hope I have it right now. I cloned the repository on github and commited my patch into my new repo. Then I created a pull request from my repo to the original xbmc repo. Is this correct? Btw there is a "merge" that is part of my pull request. No idea why, I am sorry for that https://github.com/xbmc/xbmc/pull/746
	find quote

jmarshall Team-XBMC Developer Posts: 24,523 Joined: Oct 2003 Reputation: 138	2012-03-01 23:11 Post: #4 Have commented on the pull req as to how to avoid it in future (and fix it now) Always read the XBMC online-manual, FAQ and search the forum before posting. Do not e-mail XBMC-Team members directly asking for support. Read/follow the forum rules. For troubleshooting and bug reporting please make sure you read this first.
	find quote

DDDamian Team-XBMC Developer Posts: 3,023 Joined: Sep 2011 Reputation: 252 Location: Canada	2012-03-01 23:14 Post: #5 Congrats devkid System: XBMC HTPC with HDMI WASAPI & AudioEngine - Denon AVR-3808CI - Denon DVD-5900 Universal Player - Denon DCM-27 CD-Changer - Sony BDP-S580 Blu-Ray - X-Box 360 - Android tablet wireless remote - 7.1 Streem/Axiom/Velodyne Surround System If I have been able to help feel free to add to my reputation +/- below - thanks!
	find quote

devkid Senior Member Posts: 147 Joined: Jul 2011 Reputation: 4	2012-03-02 00:06 Post: #6 Wow, I even thought it was a cool idea to merge the xbmc's master in again before I did that pull request. Well, it was not I had to google a bit to find out what that "rebase" stuff means, but I feel enlightened now And I think I have it right now. Big thanks gentlemen!
	find quote

jmarshall Team-XBMC Developer Posts: 24,523 Joined: Oct 2003 Reputation: 138	2012-03-02 00:10 Post: #7 Yup, looks good. Always read the XBMC online-manual, FAQ and search the forum before posting. Do not e-mail XBMC-Team members directly asking for support. Read/follow the forum rules. For troubleshooting and bug reporting please make sure you read this first.
	find quote

mad-max Posting Freak Posts: 1,476 Joined: Jul 2010 Reputation: 52 Location: Germany	2012-03-02 00:11 Post: #8 Looks better now with the commit... Had same problems with my PR a few days ago... Got it sorted with the awesome help ( and patience ) from jmarshall... - - - Tribute to Metallica - - - If I managed to help you, please click my reputation
	find quote