Posts: 115
Joined: Jan 2006
Reputation:
0
epoke
Senior Member
Posts: 115
I have tested this patch. Nice on confluence skin. But, every skin have different osd position. In Aeon Nox, this skin have osd on top of the screen, move up subtitle is not good choice.
Posts: 6
Joined: Mar 2012
Reputation:
0
2012-03-04, 18:12
(This post was last modified: 2012-03-04, 18:17 by eyebeeyou.)
I'm not familiar with the skins.
Do you think this can be in some way part of the skin?
Or can I get the skin info from the place I wrote the code? I can move the subs down if they are on the top in relevant skins.
I can also have this as an option, I can add in the place of the configuration of the subtitles position an option for "fixed+", where now the default is "fixed", and only in this case move the subtitles.
Posts: 26,215
Joined: Oct 2003
Reputation:
187
Yeah, this isn't going to fly as-is.
To be honest I don't really get why this is much of a problem: how often do you have the OSD up while you're wanting to read the subtitles anyway?
Posts: 508
Joined: Aug 2010
Sometimes when the mouse moves by accident it just blocks the subtitles for a few seconds.
What should be done to do "make it fly"?
Posts: 26,215
Joined: Oct 2003
Reputation:
187
The only solution that will work completely is making sure that the OSD doesn't come on ever.
The solution that will work most (but not all) the time is making sure that the OSD is at the top of the screen rather than the bottom. There's nothing that stops subtitles being displayed at the top of the screen (or in the middle of the screen), however.
A nice patch for the issue may be that in order for the mouse to come alive a mouse click must be made - currently a mouse move is enough to awaken it. This would be an advancedsetting.
Cheers,
Jonathan
Posts: 508
Joined: Aug 2010
2012-03-05, 23:14
(This post was last modified: 2012-03-06, 14:35 by john.doe.)
.
Posts: 672
Joined: Aug 2010
Reputation:
13
pieh
Retired Team-Kodi Member
Posts: 672
You can also investigate when we activate mouse - currently we check if mouse movement is bigger than 2 pixels (exactly to not show mouse cursor if movement wasn't intentional) - see CMouseStat::MovedPastThreshold in xbmc/input/MouseStat.cpp
Always read the XBMC online-manual, FAQ and search the forums before posting.
Do NOT e-mail Team-XBMC members asking for support. Read/follow the forum rules.
For troubleshooting and bug reporting, make sure you read this first
My previous forum/trac nickname: grajen3
Posts: 26,215
Joined: Oct 2003
Reputation:
187
No, your current code will not be accepted as an advancedsetting.
Code to disable the mouse movement causing the OSD to pop up, however, likely would be acceptable - you can possibly just do this in GUIDialogVideoOSD.cpp (and MusicOSD.cpp for consistency).
Cheers,
Jonathan