[PATCH]Move subtitles so the OSD wont block them

  Thread Rating:
  • 0 Votes - 0 Average
  • 1
  • 2
  • 3
  • 4
  • 5
Post Reply
pieh Offline
Team-XBMC Member
Posts: 665
Joined: Aug 2010
Reputation: 13
Location: Poland
Post: #11
You can also investigate when we activate mouse - currently we check if mouse movement is bigger than 2 pixels (exactly to not show mouse cursor if movement wasn't intentional) - see CMouseStat::MovedPastThreshold in xbmc/input/MouseStat.cpp

Always read the XBMC online-manual, FAQ and search the forums before posting.
Do NOT e-mail Team-XBMC members asking for support. Read/follow the forum rules.
For troubleshooting and bug reporting, make sure you read this first

My previous forum/trac nickname: grajen3
find quote
jmarshall Offline
Team-XBMC Developer
Posts: 24,523
Joined: Oct 2003
Reputation: 138
Post: #12
No, your current code will not be accepted as an advancedsetting.

Code to disable the mouse movement causing the OSD to pop up, however, likely would be acceptable - you can possibly just do this in GUIDialogVideoOSD.cpp (and MusicOSD.cpp for consistency).

Cheers,
Jonathan

Always read the XBMC online-manual, FAQ and search the forum before posting.
Do not e-mail XBMC-Team members directly asking for support. Read/follow the forum rules.
For troubleshooting and bug reporting please make sure you read this first.


[Image: badge.gif]
find quote
eyebeeyou Offline
Junior Member
Posts: 6
Joined: Mar 2012
Reputation: 0
Post: #13
O.K. I get it, I'll try the mouse thing.
I still hope to find a way to fix the subtitle in an acceptable way.
Thanks for the support Smile
find quote
eyebeeyou Offline
Junior Member
Posts: 6
Joined: Mar 2012
Reputation: 0
Post: #14
Sorry for the late replay, my HDD died and it took a while to get everything running again.
I implemented the option in the advanced settings to disable the OSD on mouse move and I added the sources to the ticket http://trac.xbmc.org/ticket/12753
I hope this code is acceptable.
find quote
Post Reply