[RELEASE] Artist Slideshow 1.3.0 addon (with skin and addon integration)

**Martijn** · 2012-03-27 20:48

(2012-03-27 20:16)pkscuot Wrote:
(2012-03-27 18:32)Martijn Wrote: Using T!

Is T! a skin? I'll download it and try. All I can say for now is that I agree, the script is definitely stopping. I can't seem to manually walk a circumstance where you would get the log entries you got and not at least one more line, so I'll need to look into it some more.

hehe ronie is not gonna like you any more Wink

pkscuot · 2012-03-27 21:59

(2012-03-27 20:48)Martijn Wrote:
(2012-03-27 20:16)pkscuot Wrote:
(2012-03-27 18:32)Martijn Wrote: Using T!

Is T! a skin? I'll download it and try. All I can say for now is that I agree, the script is definitely stopping. I can't seem to manually walk a circumstance where you would get the log entries you got and not at least one more line, so I'll need to look into it some more.

hehe ronie is not gonna like you any more

I see why now. He's going to hate me even more when I tell you I can't figure out how to get Artist Slideshow to even start using Transparency! If I rip out the condition of the onload in MusicVisualization.xml, Artist Slideshow runs when I go full screen while listening to music, and I see in the debug log that it is working, but it never displays any images.

EDIT: I found where to enable Artist Slideshow. And with it enabled it's running as expected on both my OSX development machine and Windows production machine.

Could someone else check with Transparency! to see if it works for them. At least then we'll know whether it's me or Martijn who is going crazy. Wink

**Martijn** · 2012-03-27 22:55

(2012-03-27 21:59)pkscuot Wrote: Could someone else check with Transparency! to see if it works for them. At least then we'll know whether it's me or Martijn who is going crazy.

Crazy already, I am Rofl

Seems my test setup is some what messed up.
Works fine on my normal HTPC. Still weird though

pkscuot · 2012-03-27 23:52

(2012-03-27 22:55)Martijn Wrote: Seems my test setup is some what messed up.
Works fine on my normal HTPC. Still weird though

Very strange to be sure. It's starting the script for sure. After that it's almost like the object gets destroyed before it gets to the first conditional statement when it figures out if there's music playing and then finishes the script. It's the only way I can figure you would get that set of log entries without something like "no music playing" or "first song started" in the log as well.

Or you're not holding your tongue the right way when you start the music visualization. Either is equally plausible. Big Grin

NisseDILLIGAF · 2012-03-30 19:30

@pkscuot

have a look at my last commit...
https://github.com/NisseDILLIGAF/script....4cf2587e6d

sometimes last.fm has no album image, then it just shows http://cdn.last.fm/flatness/catalogue/no...medium.png

pkscuot · 2012-03-30 22:06

(2012-03-30 19:30)NisseDILLIGAF Wrote: @pkscuot

have a look at my last commit...
https://github.com/NisseDILLIGAF/script....4cf2587e6d

sometimes last.fm has no album image, then it just shows http://cdn.last.fm/flatness/catalogue/no...medium.png

Seems a harmless enough fix. Do a pull request and I'll get it integrated into the main branch.

**Martijn** · 2012-03-30 22:11

(2012-03-27 23:52)pkscuot Wrote: Or you're not holding your tongue the right way when you start the music visualization. Either is equally plausible.

I think it was my left foot Tongue

Btw do you know a quick way to alter the script so the images get stored in folders named by artist? (Ofcourse i haven't looked at the code yet)
That way i could mass download new backdrops to beef up the fanart.tv site

pkscuot · 2012-03-31 02:24

(2012-03-30 22:11)Martijn Wrote: Btw do you know a quick way to alter the script so the images get stored in folders named by artist? (Ofcourse i haven't looked at the code yet)
That way i could mass download new backdrops to beef up the fanart.tv site

On line 274 replace:

Code:

CacheName = xbmc.getCacheThumbName(self.NAME).replace('.tbn', '')

with:

Code:

CacheName = self.NAME

I think that should do it. The files themselves will still have hashed names with .tbn as the extension, but changing them to .jpg should be fine. If I recall, the fanart.tv folks were very picky about image size and quality, so you'll probably want to set artist slideshow to only download stuff that's 1920x1080 or larger.

**Martijn** · 2012-03-31 02:27

Thx will try it tomorrow.
If i add .replace('.png','.jpg') that will solve the extention. Maybe need some other tweaking to make nicer filenames for better sorting.

Yeah I know they are very picky on quality Big Grin

Luckily I am one of the admins on fanart.tv overseeing the process at the moment Wink

So i know what we need.

**ronie** · 2012-03-31 02:30

(2012-03-31 02:27)Martijn Wrote: Luckily I am one of the admins on fanart.tv overseeing the process at the moment
So i know what we need.

more beer, right?

NisseDILLIGAF Junior Member Posts: 17 Joined: Jan 2009 Reputation: 0	2012-03-30 19:30 Post: #45 @pkscuot have a look at my last commit... https://github.com/NisseDILLIGAF/script....4cf2587e6d sometimes last.fm has no album image, then it just shows http://cdn.last.fm/flatness/catalogue/no...medium.png
	find quote