Boolean conditions for skins to determine if it's a pvr build

Big_Noid · 2012-03-17 00:48

Could be useful if you made a typo, but with PVR builds in mind I'd rather see it go. Then again, if there was a System.PVR in both pvr and normal builds we could use that instead of reading guisettings. All other pvr related settings are normally loaded in pvr xml's and are never loaded in regular builds, so no errors will be generated. In that case the error logging could stay.

**jmarshall** · 2012-03-17 01:00

I'll make pvrmanager.enabled a valid setting in Eden (returning false, ofcourse). Sound good?

Big_Noid · 2012-03-17 01:09

That doesn't work to hide the LiveTV settings in regular builds (otherwise the settings will be hidden for everybody, because the setting to set pvrmanager.enabled to true is in the livetv settings), but could be useful for skins that have that as a visiblitiy condition in the home window.

**jmarshall** · 2012-03-17 01:23

Right, you mean a settings category on the main settings screen - will discuss with opdenkamp.

**jmarshall** · 2012-03-17 04:52

Ok, the setting pvrmanager.enabled will return false (and not spam the log) in Eden.

Also, system.haspvr is now available (infobool) in Eden for switching items off that don't belong.

6e91544 has the goodies.

Cheers,
Jonathan

**Jezz_X** · 2012-03-17 05:18

Just a thought but this will have to be merged back into the pvr branch before it would work on there too ? or did you do that in 1 hit

**Martijn** · 2012-03-17 05:42

Opdenkamp will take care of that tomorrow IIRC

Big_Noid · 2012-03-17 09:29

Great! It's most appreciated, thx.

**opdenkamp** · 2012-03-17 12:18

yeah, will do this evening or tomorrow morning

Hitcher · 2012-03-17 12:20

(2012-03-17 04:52)jmarshall Wrote: Ok, the setting pvrmanager.enabled will return false (and not spam the log) in Eden.

Also, system.haspvr is now available (infobool) in Eden for switching items off that don't belong.

6e91544 has the goodies.

Cheers,
Jonathan

Any chance of a Windows build so I can make the changes to XeeBo?

Thanks.

jmarshall Team-XBMC Developer Posts: 24,523 Joined: Oct 2003 Reputation: 138	2012-03-17 01:00 Post: #12 I'll make pvrmanager.enabled a valid setting in Eden (returning false, ofcourse). Sound good? Always read the XBMC online-manual, FAQ and search the forum before posting. Do not e-mail XBMC-Team members directly asking for support. Read/follow the forum rules. For troubleshooting and bug reporting please make sure you read this first.
	find quote

Big_Noid Skilled Skinner Posts: 2,627 Joined: Jul 2010 Reputation: 68 Location: Below sea level	2012-03-17 01:09 Post: #13 That doesn't work to hide the LiveTV settings in regular builds (otherwise the settings will be hidden for everybody, because the setting to set pvrmanager.enabled to true is in the livetv settings), but could be useful for skins that have that as a visiblitiy condition in the home window.
	find quote

jmarshall Team-XBMC Developer Posts: 24,523 Joined: Oct 2003 Reputation: 138	2012-03-17 01:23 Post: #14 Right, you mean a settings category on the main settings screen - will discuss with opdenkamp. Always read the XBMC online-manual, FAQ and search the forum before posting. Do not e-mail XBMC-Team members directly asking for support. Read/follow the forum rules. For troubleshooting and bug reporting please make sure you read this first.
	find quote

Jezz_X Team-XBMC Skinner Posts: 5,264 Joined: Jun 2006 Reputation: 55 Location: Earth	2012-03-17 05:18 Post: #16 Just a thought but this will have to be merged back into the pvr branch before it would work on there too ? or did you do that in 1 hit Skins I have done.... And others in the past... Want to know what I'm working on currently? Check me out on Google+
	find quote

Martijn Team-XBMC Posts: 7,704 Joined: Jul 2011 Reputation: 114 Location: Dawn of time	2012-03-17 05:42 Post: #17 Opdenkamp will take care of that tomorrow IIRC Always read the XBMC online-manual, FAQ and search the forums before posting. Do NOT e-mail Team-XBMC members asking for support. Read/follow the forum rules. For troubleshooting and bug reporting, make sure you read this first For your mediacenter artwork go to
	find quote

Big_Noid Skilled Skinner Posts: 2,627 Joined: Jul 2010 Reputation: 68 Location: Below sea level	2012-03-17 09:29 Post: #18 Great! It's most appreciated, thx.
	find quote

Hitcher Skilled Skinner Posts: 9,927 Joined: Aug 2007 Reputation: 67 Location: Eastleigh, UK	2012-03-17 12:20 Post: #20 (2012-03-17 04:52)jmarshall Wrote: Ok, the setting pvrmanager.enabled will return false (and not spam the log) in Eden. Also, system.haspvr is now available (infobool) in Eden for switching items off that don't belong. 6e91544 has the goodies. Cheers, Jonathan Any chance of a Windows build so I can make the changes to XeeBo? Thanks.
	find quote