XBMC MAL Updater Plugin

That's not to say it won't update something done manually, it won't revert an update done manually is more accurate - to some extent. If the number of watched episodes listed in MAL is greater than the number listed in XBMC, then XBMAL won't update. However, if the number of watched episodes listed in XBMC is greater than the number of watched episodes listed in MAL, then it will update.

So, if you have Naruto/Bleach set to ~200 in MAL, but none of them are marked as watched in XBMC until you start testing (meaning that only 1, 2, 3, etc. are being marked as watched), then XBMAL will refuse to update MAL because it doesn't want to revert everything.

Although I'm not sure what seems to still be broken, could you be more specific? Also, even if you update the plugin, sometimes you'll still be running the previous version, because of the way xbmal is loaded into xbmc. When xbmc starts, xbmal is loaded into xbmc, and doesn't stop running unless it errors out (although it really doesn't do anything in the meantime). This means when xbmal is updated, it's still running, as xbmc doesn't unload a running plugin (as far as I can tell) when it updates it. So in order to kill the service and start the new one, a restart may still be necessary, although I'm not 100% sure.

Your expatiation seems valid
I will test with smaller numbers
( I only have around 3 seasons actually available atm for XBMC)

when I have done plugin updates i have deinstalled / closed / opened / reinstalled
or just scraped .xbmc and started fresh


once I move over to XBMC fully this Plugin will be God send for me
( Pending an FM2 main board release so I can play 10 bit anime
( currently ATOM-ION HTPC Windows Pc with pot player / MAL Updater)

looks like i will have to tinker with my files so I can get XBMC to match with MAL
( only recently changed media system 99% of my Anime files are on the old file server )

HDD flood prices stopped me from the full rebuild I wanted to do

Alright, that's probably the best way to re-install the plugin for testing.

I'm glad to hear it'll be useful, though! I'm not sure if XBMC supports 10-bit on it's own right now, you may need to compile ffmpeg and tell xbmc to use an external ffmpeg in order for it to work.

You shouldn't have to tinker too terribly much, particularly if all of your files are listed the same as in your earlier example. It just depends on how you have xbmc scraping and what scraper you use. It should work even with remote stuff, as xbmal doesn't care where the files themselves are, just what the show, season, and episode are.

HDD flood prices also stopped me from getting a new backup drive. Curse you water! Why do you have to go and flood things?

First do we need to download and install python on the system. If so which version do you recommend.

Second when ever I try to run the script I get this error message:
Error
Script Failed! : script.xbmal

The log shows this:
15:53:41 T:1624 NOTICE: -->Python Interpreter Initialized<--
15:53:41 T:1624 ERROR: Error Type: <type 'exceptions.ImportError'>
15:53:41 T:1624 ERROR: Error Contents: No module named jsonrpclib
15:53:41 T:1624 ERROR: Traceback (most recent call last):
File "...\AppData\Roaming\XBMC\addons\script.xbmal\default.py", line 16, in <module>
import myanimelist, xbmal
File "...\AppData\Roaming\XBMC\addons\script.xbmal\resources\lib\xbmal.py", line 4, in <module>
import simplejson, os, sys, itertools, math, jsonrpclib
ImportError: No module named jsonrpclib

Good morning, sir!

For your first question, python should not need to be installed, as XBMC has a built-in python interpreter. Should you want to install one for whatever reason, as far as this script goes, I would recommend the latest 2.X version. I use python 2.7.3.

As for your second question, the error means that you don't have a module I'm calling, however, I don't believe I use that module anymore. I have it there for testing and debugging purposes, and I think I forgot to remove it when I pushed the code to github. I have just removed it, though I didn't do a version bump for it. If you installed from the zip file, it should be ready to be updated within 20 minutes or so now. If you cloned the git repository, you can simply run a git pull and get the fixed version.

I apologize! It should work now. Of course, this is still somewhere in the alpha-beta range, so there may still be some bugs. Let me know if you have any more issues!

I had trouble updating through xbmc so I just cloned the new files into place.

Got another issue but the script ran for longer this time. I got a pop up saying xbmal setup. It said four percent then a pop up with script failed.

Here is the relevant log:
13:48:33 T:2972 NOTICE: -->Python Interpreter Initialized<--
13:48:34 T:2972 ERROR: Error Type: <type 'exceptions.AttributeError'>
13:48:34 T:2972 ERROR: Error Contents: ElementTree instance has no attribute 'iterfind'
13:48:34 T:2972 ERROR: Traceback (most recent call last):
File "...\AppData\Roaming\XBMC\addons\script.xbmal\default.py", line 141, in <module>
w = MainDiag()
File "...\AppData\Roaming\XBMC\addons\script.xbmal\default.py", line 89, in __init__
mappings = lg.generateList(pDialog)
File "...\AppData\Roaming\XBMC\addons\script.xbmal\default.py", line 41, in generateList
if self.config.showInConfig(season[0]['tvshowid'], season[0]['season']) == False:
File "...\AppData\Roaming\XBMC\addons\script.xbmal\resources\lib\xbmal.py", line 38, in showInConfig
for item in self.tree.iterfind('show'):
AttributeError: ElementTree instance has no attribute 'iterfind'

Ok, so I may have overestimated what version of python XBMC is using. That's my guess, anyway. Based on your error, iterfind hasn't yet been added to the interpreter, which indicates it's pre-2.7. I believe Eden is post-2.4, so that at least narrows my range.

Anyway, I added an un-tested update to the appropriate file in both master and working, though I haven't updated the zip yet. Could you clone that into place and see if it works? I'm not sure if there is anywhere else I use things added in python 2.7, so there's the distinct possibility it will fail again. I apologize for the inconvenience, but think, you're making it easier for everyone else!

I can't test it myself for two reasons - right now, I don't have any of my devices running xbmc at my disposal, but more importantly, it seems all three of my devices are using python 2.7.

Anyway, let me know if it works, or of any other bugs you encounter. Hopefully we can get this ironed out.

We're getting closer. The script ran through my library fine. It displayed the "select a show to fix mapping" menu and I could map and search MAL correctly.

When I went to save got a script failed error.

Log:
16:39:25 T:2556 NOTICE: -->Python Interpreter Initialized<--
16:39:35 T:2556 WARNING: Trying to add unsupported control type 1
16:40:56 T:2556 WARNING: Previous line repeats 12 times.
16:40:56 T:2556 NOTICE: ### [XBMAL] - Writing new mappings file
16:40:56 T:2556 ERROR: Error Type: <type 'exceptions.TypeError'>
16:40:56 T:2556 ERROR: Error Contents: write() got an unexpected keyword argument 'xml_declaration'
16:40:56 T:2556 ERROR: Traceback (most recent call last):
File "...\AppData\Roaming\XBMC\addons\script.xbmal\default.py", line 141, in <module>
w = MainDiag()
File "...\AppData\Roaming\XBMC\addons\script.xbmal\default.py", line 122, in __init__
lg.config.writeConfig()
File "...\AppData\Roaming\XBMC\addons\script.xbmal\resources\lib\xbmal.py", line 64, in writeConfig
self.tree.write(self.xmlFile, encoding="UTF-8", xml_declaration=True)
TypeError: write() got an unexpected keyword argument 'xml_declaration'

It is not an inconvenience. I have written software too, (all in java so no help with python) and I know how things are supposed to work but somewhere along the line implementation is non ideal so it doesn't work.

Good! At least we're part way there.

I'm guessing the xml_decleration has the same compatibility problem, though if that's true it's not well documented. I wrapped it in a try except, so hopefully that'll fix the issue for not-2.7. Just clone master again and hopefully all will be well.

Also good to know you've developed as well! That should make things a bit easier.

Well, let me know if it works.

It mostly works. Thanks for everything. I was able to save the mapping, and the script started listening. I watched a show in its entirety and it correctly updated in mal.

There are some things I still have fetter out the cause then I can list a more detailed description. After finishing some shows the pop up said two shows were edited. Recently it said zero shows were updated, but I fast forwarded through everything in order to test. Also when I re watched some shows the script said it updated an episode but it did not update MAL (a setting I really like)