GlobalSearch - tiny changes

**ronie** · 2012-03-20 21:47

i've just pushed a new version to the addon repo.

if your skin includes script-globalsearch-contextmenu.xml, please note that a small update is in order.

i've added 1 extra button to the context menu (id 1003)
and changed the script code for position the dialog (so double-check if it still pops up where you want it to be)

Big_Noid · 2012-03-20 22:31

Although I don't agree with handling positions of the dialog in the script, thx for the heads up Smile

**ronie** · 2012-03-20 22:37

(2012-03-20 22:31)Big_Noid Wrote: Although I don't agree with handling positions of the dialog in the script, thx for the heads up

it was handling them before, but much less now :-)

the script has to do some calculations as the height of the dialog varies
depending on the numbers of buttons available on the context menu.

Hitcher · 2012-03-20 22:47

Revenge is sweet. Wink

(2012-03-19 02:35)ronie Wrote: grumble.. i suppose i could... and for about 6 other scripts as well...grumble

;-)

**jmarshall** · 2012-03-20 22:55

Heh

Big_Noid · 2012-03-20 22:58

Yeah for height I knew and understand, but posx calculation is new as far as i can tell.

**ronie** · 2012-03-20 23:05

heh, if you want to get to the bottom of this ;-)
the initial dialog code was a straight copy of nuka's dialog for the amt script.
it had some hardcoded posx calculations, which i've removed now:
https://code.google.com/p/ronie/source/d...py&old=126

Hitcher · 2012-03-20 23:21

Is it me or are the mirrors down for everyone?

**ronie** · 2012-03-20 23:24

(2012-03-20 23:21)Hitcher Wrote: Is it me or are the mirrors down for everyone?

most likely a side-effect of the Artwork Downloader update.
people are standing in line to get their hands on that one.

**Martijn** · 2012-03-20 23:28

(2012-03-20 23:24)ronie Wrote:
(2012-03-20 23:21)Hitcher Wrote: Is it me or are the mirrors down for everyone?

most likely a side-effect of the Artwork Downloader update.
people are standing in line to get their hands on that one.

neah who wants that...

Side note:
ronie had like 7 script updated at the same time....
on the other hand the http://fanart.tv site is also having issues Tongue

Big_Noid Skilled Skinner Posts: 2,627 Joined: Jul 2010 Reputation: 68 Location: Below sea level	2012-03-20 22:31 Post: #2 Although I don't agree with handling positions of the dialog in the script, thx for the heads up
	find quote

Hitcher Skilled Skinner Posts: 9,922 Joined: Aug 2007 Reputation: 67 Location: Eastleigh, UK	2012-03-20 22:47 Post: #4 Revenge is sweet. (2012-03-19 02:35)ronie Wrote: grumble.. i suppose i could... and for about 6 other scripts as well...grumble ;-)
	find quote

jmarshall Team-XBMC Developer Posts: 24,523 Joined: Oct 2003 Reputation: 138	2012-03-20 22:55 Post: #5 Heh Always read the XBMC online-manual, FAQ and search the forum before posting. Do not e-mail XBMC-Team members directly asking for support. Read/follow the forum rules. For troubleshooting and bug reporting please make sure you read this first.
	find quote

Big_Noid Skilled Skinner Posts: 2,627 Joined: Jul 2010 Reputation: 68 Location: Below sea level	2012-03-20 22:58 Post: #6 Yeah for height I knew and understand, but posx calculation is new as far as i can tell.
	find quote

Hitcher Skilled Skinner Posts: 9,922 Joined: Aug 2007 Reputation: 67 Location: Eastleigh, UK	2012-03-20 23:21 Post: #8 Is it me or are the mirrors down for everyone?
	find quote