[xbmcfanboy0]

Updated per your suggestions. Thank you very much.

Code:

bool CFileItemList::UpdateItem(const CFileItem *item)
{
  if (!item) return false;

  for (int i = 0; i < Size(); i++)
  {
    CFileItemPtr pItem = m_items[i];
    if (pItem->IsSamePath(item))
    {
      *pItem = *item;
      return true;
    }
  }
  return false;
}

[xbmcfanboy0]

Should I make this change so m_items isn't directly accessed in the function?

Code:

CFileItemPtr pItem = m_items[i];

Code:

CFileItemPtr pItem = Get(i);

[jmarshall]

No that doesn't matter at all. You can access m_items directly (though you might want to check if you need to hold the critical section - can't recall if there is one there or not). It probably makes sense to use m_items.size() in that case with an unsigned int or iterator.

[xbmcfanboy0]

The pull request has been updated. Let me know what you think.
https://github.com/xbmc/xbmc/pull/843