(2012-03-27 03:06)jingai Wrote: Stoli,
I fixed everything I mentioned with the exception of fixing up the PictureGrid view. I'll get on that next.
Sending you a pull request in a moment.
-j
Updates merged into trunk - thanks for your work!
stoli
Skilled Skinner Joined: Nov 2008 Reputation: 31 Location: Florida |
2012-03-27 21:08
Post: #1
(2012-03-27 03:06)jingai Wrote: Stoli, Updates merged into trunk - thanks for your work! |
| find quote |
jingai
Skilled Skinner Posts: 888 Joined: Mar 2010 Reputation: 8 |
2012-03-29 14:01
Post: #2
No problem at all. Glad to be of some help.
I just added a SlideShow.xml (the one in the repository was commented out) as well, which is pull request #52. Next up I want to get some use out of the bottom section for Pictures, like displaying some of the more useful EXIF tags and such. Finally, I'll update/replace the PictureGrid view with something that fits the theme a bit better. As I get time I'll look through your current issues as posted on github too ![]() -j |
| find quote |
jingai
Skilled Skinner Posts: 888 Joined: Mar 2010 Reputation: 8 |
2012-04-02 03:45
Post: #3
Pull requests 54-56 finish the outstanding issues I talked about besides the new PictureGrid view. I'll get on that tomorrow
![]() -j |
| find quote |
jingai
Skilled Skinner Posts: 888 Joined: Mar 2010 Reputation: 8 |
2012-04-05 21:47
Post: #4
I've worked up a new PictureGrid view. I think you're out of town (Stoli) so I'll hold off on sending a pull request until I'm sure I'm happy with it. It's the branch "picgrid" in my fork (https://github.com/jingai/Metropolis/tree/picgrid) if anyone wants to have a look and maybe provide some feedback.
-j
(This post was last modified: 2012-04-05 21:48 by jingai.)
|
| find quote |
stoli
Skilled Skinner Joined: Nov 2008 Reputation: 31 Location: Florida |
2012-04-11 19:41
Post: #5
Great work on all of the updates jingai! All of your pull requests have been merged.
|
| find quote |
jingai
Skilled Skinner Posts: 888 Joined: Mar 2010 Reputation: 8 |
2012-04-11 20:14
Post: #6
Not a problem
![]() I've pretty much got the new Picture Grid view finished, but for some reason when I set the aspect ratio to "keep" it doesn't scale the same on all of my machines. I am not sure if this is an issue with XBMC or something I'm doing wrong. I'm going to have a look at adding the ability to hide unwanted view types next. Since I'll be touching CustomSettings.xml, if you can tell me what you meant in Issue #13 I can possibly address that at the same time. FYI, you can close Issues 47 and 31 if you're satisfied with my fixes. #6 could probably also be closed since it should "just work" once that feature is added to XBMC. -j Probably could close Issue 21 too, and open two new issues to "Add support for Random Items" and "Add support for Watchlist", since those two things apply to both Home styles. As for adding Media Stats to the Home2 style, I have no idea where you'd even put that info. There just isn't enough room. -j
(This post was last modified: 2012-04-11 20:23 by jingai.)
|
| find quote |
jingai
Skilled Skinner Posts: 888 Joined: Mar 2010 Reputation: 8 |
2012-04-12 04:34
Post: #7
Issues 16 and (probably) 13 are taken care of with pull request 66.
(This post was last modified: 2012-04-12 04:37 by jingai.)
|
| find quote |
thewarm
Senior Member Joined: Apr 2011 Reputation: 2 Location: Seattle |
2012-04-12 15:39
Post: #8
Thanks for all of your hard work guys!
Every time the GIT updates, I lose all of the theme options. Only 1 theme available. But I do have 6 color choices. I have to add the separate xbt files back into the media folder! Can you incorporate all of the other textures into the main "textures.xbt" file please... |
| find quote |
jingai
Skilled Skinner Posts: 888 Joined: Mar 2010 Reputation: 8 |
2012-04-12 16:58
Post: #9
For the textures.xbt issue see http://forum.xbmc.org/showthread.php?tid...pid1073899
|
| find quote |
stoli
Skilled Skinner Joined: Nov 2008 Reputation: 31 Location: Florida |
2012-04-12 19:21
Post: #10
(2012-04-12 15:39)thewarm Wrote: Thanks for all of your hard work guys! Are you updating direct via Git or through the Passion Repo? If it's the Passion Repo, I'll have to get with ppic to see why the xbt files are being dropped. |
| find quote |