[PATCH] Enable HLS passthrough to FFMPEG

ksosez · 2012-07-06 02:41

I dont believe the NHL stream is https encrypted. I know for sure that MLS isnt (which I believe uses the same underlying tech).

ksosez · 2012-07-08 04:18

I went ahead and updated to 12.04 on Ubuntu and tried the MLS streaming links, they work perfectly with VLC but XBMC every 10 seconds or so gives a "working" dialog before reloading. Sucks because otherwise my addon is ready to go.

micahg · 2012-07-08 19:09

ksosez, this is because XBMC is handling the playlist internally, instead of passing it back to ffmpeg to handle as HLS. You'll notice it always runs from the start of the stream too even for live events.

micahg · 2012-07-10 20:03

Is there any other way to submit this so it gets accepted (or at least reviewed). I kind of feel its just sitting here doing nothing.

hippojay · 2012-07-11 13:05

Have you created a pull request for it? At least then it will appear on the [increasingly long] list of pulls in the repository.

micahg · 2012-07-12 04:34

hippojay, I read through the wiki and it didn't say anything about git pull requests for the main code base. What list do those go on?

TIA

bossanova808 · 2012-07-12 04:55

Basically, when you do a patch this is th process:

you fork the main xbmc repo, clone it to you local system, add add the upstream remote which is the main xbmc repo, make your changes to your local branch & test as much as you can, then commit locally to your branch, then push them back *to your own fork* (NOT xbmc master) on github (first git fetch and git merge any changes to mainline that have occurred in the interim), then use the pull request button on github to make a pull request, which is a request that one of the main xbmc debs pulls it back into the main codebase (review your code on the way through jsut to be sure it's PRing what you intended).

It's actually pretty easy...once you've done it once...

RockerC · 2012-07-12 21:39

(2012-07-12 04:55)bossanova808 Wrote: Basically, when you do a patch this is th process:

you fork the main xbmc repo, clone it to you local system, add add the upstream remote which is the main xbmc repo, make your changes to your local branch & test as much as you can, then commit locally to your branch, then push them back *to your own fork* (NOT xbmc master) on github (first git fetch and git merge any changes to mainline that have occurred in the interim), then use the pull request button on github to make a pull request, which is a request that one of the main xbmc debs pulls it back into the main codebase (review your code on the way through jsut to be sure it's PRing what you intended).

It's actually pretty easy...once you've done it once...

http://wiki.xbmc.org/index.php?title=HOW...it_a_patch

Maybe XBMC's wiki needs updating with a more step-by-step for Git and GitHub? Wink

**Martijn** · 2012-07-12 21:43

Enough how-to's on the web

micahg · 2012-07-13 04:26

OK, thanks all - two pull requests in (one for the master branch and one for the Eden branch).

ksosez Senior Member Posts: 167 Joined: Nov 2010 Reputation: 3	2012-07-06 02:41 Post: #11 I dont believe the NHL stream is https encrypted. I know for sure that MLS isnt (which I believe uses the same underlying tech).
	find quote

ksosez Senior Member Posts: 167 Joined: Nov 2010 Reputation: 3	2012-07-08 04:18 Post: #12 I went ahead and updated to 12.04 on Ubuntu and tried the MLS streaming links, they work perfectly with VLC but XBMC every 10 seconds or so gives a "working" dialog before reloading. Sucks because otherwise my addon is ready to go.
	find quote

micahg Member Posts: 87 Joined: Sep 2011 Reputation: 1	2012-07-08 19:09 Post: #13 ksosez, this is because XBMC is handling the playlist internally, instead of passing it back to ffmpeg to handle as HLS. You'll notice it always runs from the start of the stream too even for live events.
	find quote

micahg Member Posts: 87 Joined: Sep 2011 Reputation: 1	2012-07-10 20:03 Post: #14 Is there any other way to submit this so it gets accepted (or at least reviewed). I kind of feel its just sitting here doing nothing.
	find quote

hippojay Fan Posts: 301 Joined: Mar 2008 Reputation: 13 Location: Sheffield, UK	2012-07-11 13:05 Post: #15 Have you created a pull request for it? At least then it will appear on the [increasingly long] list of pulls in the repository.
	find quote

micahg Member Posts: 87 Joined: Sep 2011 Reputation: 1	2012-07-12 04:34 Post: #16 hippojay, I read through the wiki and it didn't say anything about git pull requests for the main code base. What list do those go on? TIA
	find quote

Martijn Team-XBMC Posts: 7,714 Joined: Jul 2011 Reputation: 115 Location: Dawn of time	2012-07-12 21:43 Post: #19 Enough how-to's on the web Always read the XBMC online-manual, FAQ and search the forums before posting. Do NOT e-mail Team-XBMC members asking for support. Read/follow the forum rules. For troubleshooting and bug reporting, make sure you read this first For your mediacenter artwork go to
	find quote

micahg Member Posts: 87 Joined: Sep 2011 Reputation: 1	2012-07-13 04:26 Post: #20 OK, thanks all - two pull requests in (one for the master branch and one for the Eden branch).
	find quote