[PATCH] Enable HLS passthrough to FFMPEG

  Thread Rating:
  • 0 Votes - 0 Average
  • 1
  • 2
  • 3
  • 4
  • 5
Post Reply
micahg Offline
Senior Member
Posts: 140
Joined: Sep 2011
Reputation: 1
Post: #16
hippojay, I read through the wiki and it didn't say anything about git pull requests for the main code base. What list do those go on?

TIA
find quote
bossanova808 Offline
Donor
Posts: 2,206
Joined: Sep 2009
Reputation: 33
Location: Melbourne, Australia
Post: #17
Basically, when you do a patch this is th process:

you fork the main xbmc repo, clone it to you local system, add add the upstream remote which is the main xbmc repo, make your changes to your local branch & test as much as you can, then commit locally to your branch, then push them back *to your own fork* (NOT xbmc master) on github (first git fetch and git merge any changes to mainline that have occurred in the interim), then use the pull request button on github to make a pull request, which is a request that one of the main xbmc debs pulls it back into the main codebase (review your code on the way through jsut to be sure it's PRing what you intended).

It's actually pretty easy...once you've done it once...

My XBMC stuff:
find quote
RockerC Offline
Fan
Posts: 318
Joined: May 2011
Reputation: 3
Post: #18
(2012-07-12 04:55)bossanova808 Wrote:  Basically, when you do a patch this is th process:

you fork the main xbmc repo, clone it to you local system, add add the upstream remote which is the main xbmc repo, make your changes to your local branch & test as much as you can, then commit locally to your branch, then push them back *to your own fork* (NOT xbmc master) on github (first git fetch and git merge any changes to mainline that have occurred in the interim), then use the pull request button on github to make a pull request, which is a request that one of the main xbmc debs pulls it back into the main codebase (review your code on the way through jsut to be sure it's PRing what you intended).

It's actually pretty easy...once you've done it once...
http://wiki.xbmc.org/index.php?title=HOW...it_a_patch

Maybe XBMC's wiki needs updating with a more step-by-step for Git and GitHub? Wink
find quote
Martijn Offline
Team Kodi
Posts: 11,224
Joined: Jul 2011
Reputation: 162
Location: Dawn of time
Post: #19
Enough how-to's on the web

Always read the XBMC online-manual, FAQ and search the forums before posting.
Do NOT e-mail Team-XBMC members asking for support. Read/follow the forum rules.
For troubleshooting and bug reporting, make sure you read this first

For your mediacenter artwork go to
[Image: fanarttv.png]
find quote
micahg Offline
Senior Member
Posts: 140
Joined: Sep 2011
Reputation: 1
Post: #20
OK, thanks all - two pull requests in (one for the master branch and one for the Eden branch).
find quote
sdsnyr94 Offline
Fan
Posts: 476
Joined: Aug 2009
Reputation: 2
Location: Greensboro, NC
Post: #21
(2012-07-13 04:26)micahg Wrote:  OK, thanks all - two pull requests in (one for the master branch and one for the Eden branch).

Well, It looks like your patch finally got merged:
https://github.com/xbmc/xbmc/commit/8f04...cdaeff40f/

Hopefully we can look forward to some real good add-ons from this.
find quote
micahg Offline
Senior Member
Posts: 140
Joined: Sep 2011
Reputation: 1
Post: #22
It did indeed Smile I should probably go tell the gamecenter people...
find quote
sdsnyr94 Offline
Fan
Posts: 476
Joined: Aug 2009
Reputation: 2
Location: Greensboro, NC
Post: #23
(2012-08-10 20:31)micahg Wrote:  It did indeed Smile I should probably go tell the gamecenter people...

I let the dev for the MLBMC (MLB.TV) add-on know. It would be nice to get HLS feeds across all platforms.
find quote
micahg Offline
Senior Member
Posts: 140
Joined: Sep 2011
Reputation: 1
Post: #24
I think MLB.TV uses HTTPS, which isn't supported by FFMPEG.
find quote
sdsnyr94 Offline
Fan
Posts: 476
Joined: Aug 2009
Reputation: 2
Location: Greensboro, NC
Post: #25
(2012-08-11 02:53)micahg Wrote:  I think MLB.TV uses HTTPS, which isn't supported by FFMPEG.

See posts 9 and 10 in this thread ...... Smile
find quote
Post Reply