[PRE-RELEASE] Mute Profanity

"I manually copied the plugin to the addons folder"

Install the zipped script from the addon manager - it may have dependencies that need installing etc.

So I installed this a few days ago but I have been unable to get it working and I believe it is because I have my xbmc setup for multiple head units and because of this I use smb paths for all my files. Even if I download an srt file manually the addon will not find it and will fail trying to download the srt. Here is the data from the xbmc.log file:

23:32:12 T:2608 NOTICE: -->Python Interpreter Initialized<--
23:32:12 T:2608 NOTICE: movieid: 364
23:32:12 T:2608 NOTICE: movie details call response: {"id":1,"jsonrpc":"2.0","result":{"moviedetails":{"file":"smb://HTPC/Movies/Knight and Day/Knight and Day (2010).mkv","label":"Knight and Day","movieid":364,"title":"Knight and Day"}}}
23:32:12 T:2608 NOTICE: details: {'title': 'Knight and Day', 'movieid': 364, 'file': 'smb://HTPC/Movies/Knight and Day/Knight and Day (2010).mkv', 'label': 'Knight and Day'}
23:32:14 T:2608 NOTICE: head: smb://HTPC/Movies/Knight and Day/Knight and Day (2010)
23:32:14 T:2608 NOTICE: No srt file!
23:32:16 T:2608 NOTICE: Downloading
23:32:16 T:2608 NOTICE: Contacting http://www.opensubtitles.org (smb://HTPC/Movies/Knight and Day/Knight and Day (2010).mkv)
23:32:16 T:2608 NOTICE: Traceback (most recent call last):
File "C:\Users\StephenM\AppData\Roaming\XBMC\addons\plugin.video.mute-profanity\addon.py", line 126, in <module>
dl.FindSubtitles(fileLoc,"eng")
File "C:\Users\StephenM\AppData\Roaming\XBMC\addons\plugin.video.mute-profanity\resources\lib\SubDownloader.py", line 22, in FindSubtitles
data = GetSubtitles(videoname);
File "C:\Users\StephenM\AppData\Roaming\XBMC\addons\plugin.video.mute-profanity\resources\lib\SubDownloader.py", line 42, in GetSubtitles
moviebytesize = os.path.getsize(moviepath)
File "C:\Program Files (x86)\XBMC\system\python\Lib\genericpath.py", line 49, in getsize
return os.stat(filename).st_size
WindowsError: [Error 123] The filename, directory name, or volume label syntax is incorrect: 'smb://HTPC/Movies/Knight and Day/Knight and Day (2010).mkv'

I might try to dig into the code when I get some time to help but python is not my strong suit so I might not be of much help. Let me know if you want me to try something.

Thanks for this good start!

Stephen

jcolby,
Sorry for not replying earlier. Since I don't have your logs, I can only guess what's going on with your setup, but here it goes:

1. I never tested any ISO files, but as long as there is an external subtitle srt file I can't think of any reason why it wouldn't work. I will test this when I can. (Need to confirm XBMC will handle edl files for ISO media)
2. The name of the srt file is very strict. It must be in the same folder with the same name as the movie, except a different extension (.srt)
3. XBMC will automatically use the .edl file you created as long as it follows the same strict naming convention above (same name as movie, but extension is .edl)

Thanks to mathmansteve, I realized that I don't support smb paths, if that's what you've got setup, it might not work either. I'll work on a fix for that soon.

Thanks everyone for the posts and I'll try to respond sooner!

---

As always, log files are always invaluable with fixing bugs. Anyone using this plugin that's running into unexpected errors, please include the relevant lines in xbmc.log, or use pastebin, etc.

I think this is a great idea. I'm eager to try it out. Have you made any progress on this? I'd be happy to help test it out if you need testers

No additional progress; it's been a busy summer. However, feel free to test now and let me know what bugs you find. Unless you're using smb shares, you should be able to try it out now.

The other bug reported was a user not being able to find the subtitle file. Does anyone know exactly how XBMC determines which subtitle file to use for any given movie? Or better yet, is there a way to call into that function from the python side? I'd hate to duplicate an already existing function in XBMC, but I don't think it's part of the python API yet.

I stumbled across your add-on about a month ago after spending about 3-4 days creating a script of my own that did similar stuff. My process was much more cumbersome and I was pretty stoked to find what you had done.
I noticed that your filter words had to be padded with spaces to keep from picking up words that have the same letters inside. I tweaked your script a little to use word boundaries when searching for the word in a given line. Not sure how to attach it to this post though. I've got some other ideas that your add-on could do and I'd like to help on it if you're interested.

(2012-08-17 17:25)fauxpaux Wrote:  I stumbled across your add-on about a month ago after spending about 3-4 days creating a script of my own that did similar stuff. My process was much more cumbersome and I was pretty stoked to find what you had done.
I noticed that your filter words had to be padded with spaces to keep from picking up words that have the same letters inside. I tweaked your script a little to use word boundaries when searching for the word in a given line. Not sure how to attach it to this post though. I've got some other ideas that your add-on could do and I'd like to help on it if you're interested.

That's awesome! I'd love to add whatever improvements you're willing work on (or anyone else). There's a couple of ways to get me the changes:

The correct way: Use github. Fork my repo, make your changes, commit, then click on 'Pull Request'. I'll see your request, and pull in your changes.
The quick way: Email me a diff. If you used git, run 'git diff > git_diff.out'. Or without git: 'diff original new > diff.out'
The ugly way: Email me a zip with your files you've changed (or the entire thing).

Anyone else interested in contributing, PM me for my email.

I've followed what you detailed for github. You should have a Pull Request waiting for you.

Anyone else wanting to submit any features or bugs, please visit github and add any issues there. This thread can still be used for discussion or specific questions though.

https://github.com/brazilbrown/mute-profanity/

BARBARA STREISAND!!!!!