Posts: 168
Joined: Jan 2008
Reputation:
1
Hi i think i found 3 bugs:
Compiled newest build (80e7c22d9e) and deleted database and let it build it up again:
- it downloads the actors photos (for movies database) although i have disable that in the config -> Video meu
- if you press the info button on a mvie in your databes, you now don't see the plot anymore
- tv shows is COMPLETELY messed up: it founds them, but it oesn't download fanrt or banner anymore...you have to do that yurself or it does it veeeeeeeeeeeeeeeeeeery slowly, when you select a show
BTW: i use thetvdb.com and themoviedb.com, both scraper working fine with and older nightly (3 days ago).
Dind't know where too post this, so did it here.
Posts: 168
Joined: Jan 2008
Reputation:
1
Just asking because i think this is a serious problem for library management in XBMC (newest nightly build 80e7c22d9e and after that perhaps).
Posts: 26,215
Joined: Oct 2003
Reputation:
187
1. It's important to be specific. It only happens if you're in the video info dialog, correct? If you'd told me that I wouldn't have just spent 20 minutes trying to reproduce it elsewhere. This is now fixed.
3. a. No idea what you're talking about. Again, be specific. Make sure you explain any problems clearly.
b. Thanks - found and fixed.
Cheers,
Jonathan
Posts: 26,215
Joined: Oct 2003
Reputation:
187
All artwork is fetched offthread now during scan. Movies, Shows, Episodes and Music Videos. It's exactly the same as it was before (i.e. the same logic is used to obtain the image URLs) the difference is the art is downloaded in a separate thread. This makes scanning finish much more quickly, and as you view the scanned items, if no art is downloaded yet (i.e. it's still queued up) it'll be downloaded at that point (jumping the queue).
Eden would only fail to scrape if the info could not be downloaded - not if art could not be downloaded.
Thus, reliability has not changed at all. What has changed is you now have a much faster scanner.
Cheers,
Jonathan
Posts: 26,215
Joined: Oct 2003
Reputation:
187
This is incorrect. You're welcome to read the code yourself if you wish. VideoInfoScanner.cpp - see GetArtwork, and note that it only ever calls CTextureCache::BackgroundCacheImage(), which does exactly what it says it does.
Posts: 168
Joined: Jan 2008
Reputation:
1
not that i don't trust you, don't get me wrong here. Only trying to help (since i did with a few other bugs).
But yeah i can do that.
Anyway: this is what i get (fresh xbmc, no userdata or whatsoever):
- Movies: everythings fetched directly, no background work
- tv-shows: backgrounded/queued, but only if they are shown (big list (confluence skin), 3 pages long, 1 page of the list being shown)
I let it scrape, after 30 mins he was still there where i left the tv-show library (my connection is good, 16mbit, no downloads or whatsoever running parellely, tested it with eden on other pc, scraped everything directly, was done in less then 2 mins)!
Don't trust me: try it yourself (fresh install, scrape a few movies, then a few empty folders (tv-shows))
Posts: 168
Joined: Jan 2008
Reputation:
1
I'll check that (it wasn't necessary till now, since it obviously didn't)!
30mins vs. 2mins: doesn't make any sense to me.