[phil65]

another one...
we had to apply this commit https://github.com/BigNoid/Aeon-Nox/comm...a6548da191
to avoid that the include got executed several times (and resets the settings by doing this)
we´re using

Code:

<include condition="!Skin.HasSetting(Nox.firstrun)">AutoConfig</include>

already which should be enough, but it still gets included several times ( Nox.Firstrun is set to true when autoconfig ends)
can be replicated (at least on my machiine) when starting nox 3.0.0 for the first time (don´t know for sure if this always happens), entering settings, changing color for settings, and returning to home.
you can see that the include onloads got triggered when you see the notification pop-up.
i had a similar problem before, also for home window. seems that the include conditions do not get checked properly there in all cases.
hope that´s clear enough. if not, ask for more info.
thx

[phil65]

bump. anyone?

[pieh]

Finally got time to track issue here

@jmarshall
When we load skin, we test if loading Home.xml window is ok: https://github.com/xbmc/xbmc/blob/master....cpp#L1815 . This can actually cause several issues:
a) window will stay in memory and next time we will show it we won't resolve our includes as window is already loaded
b) it will trigger home's window <onload> actions (which technically is correct as we load that window, but I doubt anyone want that)

Also this test really checks only if Home.xml exist and if root element of that file is <window> - maybe add CGUIWindow::Test() method that will do just that, without really parsing and loading that window?

[jmarshall]

Probably just testing if Home.xml exists is enough.

[pieh]

fixed in https://github.com/xbmc/xbmc/commit/5096...d47dc80541

[phil65]

thx. greatly appreciated.