Suggestions for Weather Changes

  Thread Rating:
  • 0 Votes - 0 Average
  • 1
  • 2
  • 3
  • 4
  • 5
Post Reply
Nuka1195 Offline
Skilled Python Coder
Posts: 3,910
Joined: Dec 2004
Reputation: 18
Post: #1
I'd like to start a discussion on some changes for weather that would effect addons.

1. XBMC to not localize anything. I think it's best left for the addon.
2. Have skinners only refer to Window(Weather).Property(<property>) and eliminate all the duplicate code in weather.cpp
3. Have XBMC read 'Locations' and all 'Location#' from addons settings to allow better handling of the location spinner.
4. XBMC send an additional param to addon. ForceRefresh bool. True if user presses refresh button. Allows addon to better handle caching data.
5. Current.OutlookIcon -> Current.ConditionIcon to match what it is.
6. Night#.property same as day#.
7. WeatherProviderIcon property, I guess skinners could use the addons icon, but those are usually modified.

I have some other properties that weather.com supports so maybe have a list here that we should follow.

Any suggestions.

For python coding questions first see http://mirrors.xbmc.org/docs/python-docs/
(This post was last modified: 2012-06-07 18:46 by Nuka1195.)
find quote
Nuka1195 Offline
Skilled Python Coder
Posts: 3,910
Joined: Dec 2004
Reputation: 18
Post: #2
some string additions

Code:
diff --git a/language/English/strings.po b/language/English/strings.po
index b665ba8..223c6d0 100644
--- a/language/English/strings.po
+++ b/language/English/strings.po
@@ -283,7 +283,43 @@ msgctxt "#87"
msgid "VAR"
msgstr ""

-#empty strings from id 88 to 97
+msgctxt "#88"
+msgid "North"
+msgstr ""
+
+msgctxt "#89"
+msgid "Northeast"
+msgstr ""
+
+msgctxt "#90"
+msgid "East"
+msgstr ""
+
+msgctxt "#91"
+msgid "Southeast"
+msgstr ""
+
+msgctxt "#92"
+msgid "South"
+msgstr ""
+
+msgctxt "#93"
+msgid "Southwest"
+msgstr ""
+
+msgctxt "#94"
+msgid "West"
+msgstr ""
+
+msgctxt "#95"
+msgid "Northwest"
+msgstr ""
+
+msgctxt "#96"
+msgid "Variable"
+msgstr ""
+
+#empty strings from id 97 to 97

msgctxt "#98"
msgid "View: Auto"
@@ -1585,7 +1621,15 @@ msgctxt "#434"
msgid "From %s at %i %s"
msgstr ""

-#empty strings from id 435 to 436
+#. From the <wind dir.> at <speed> <unit>
+msgctxt "#435"
+msgid "From the %s at %i %s"
+msgstr ""
+
+#. Gust to <speed> <unit>
+msgctxt "#436"
+msgid "Gust to %i %s"
+msgstr ""

msgctxt "#437"
msgid "Removable disk"
@@ -3328,8 +3372,49 @@ msgctxt "#1423"
msgid "Mist"
msgstr ""

+#empty strings from id 1424 to 1439
+
+msgctxt "#1440"
+msgid "Moon"
+msgstr ""
+
+msgctxt "#1441"
+msgid "Waning"
+msgstr ""
+
+msgctxt "#1442"
+msgid "Waxing"
+msgstr ""
+
+msgctxt "#1443"
+msgid "Full"
+msgstr ""
+
+msgctxt "#1444"
+msgid "New"
+msgstr ""
+
+msgctxt "#1445"
+msgid "First"
+msgstr ""
+
+msgctxt "#1446"
+msgid "Last"
+msgstr ""
+
+msgctxt "#1447"
+msgid "Quarter"
+msgstr ""
+
+msgctxt "#1448"
+msgid "Crescent"
+msgstr ""
+
+msgctxt "#1449"
+msgid "Gibbous"
+msgstr ""
+
#strings through to 1450 reserved for weather translation
-#empty strings from id 1424 to 1449

msgctxt "#1450"
msgid "Put display to sleep when idle"
@@ -8928,7 +9013,23 @@ msgctxt "#33038"
msgid "%s day"
msgstr ""

-#empty strings from id 33039 to 33048
+#empty strings from id 33039 to 33044
+
+msgctxt "#33045"
+msgid "mile"
+msgstr ""
+
+msgctxt "#33046"
+msgid "miles"
+msgstr ""
+
+msgctxt "#33047"
+msgid "kilometer"
+msgstr ""
+
+msgctxt "#33048"
+msgid "kilometers"
+msgstr ""

msgctxt "#33049"
msgid "Alert"

For python coding questions first see http://mirrors.xbmc.org/docs/python-docs/
find quote
Hitcher Offline
Skilled Skinner
Posts: 10,793
Joined: Aug 2007
Reputation: 100
Location: Eastleigh, UK
Post: #3
(2012-06-07 18:45)Nuka1195 Wrote:  I'd like to start a discussion on some changes for weather that would effect addons.

1. XBMC to not localize anything. I think it's best left for the addon.
2. Have skinners only refer to Window(Weather).Property(<property>) and eliminate all the duplicate code in weather.cpp
3. Have XBMC read 'Locations' and all 'Location#' from addons settings to allow better handling of the location spinner.
4. XBMC send an additional param to addon. ForceRefresh bool. True if user presses refresh button. Allows addon to better handle caching data.
5. Current.OutlookIcon -> Current.ConditionIcon to match what it is.
6. Night#.property same as day#.
7. WeatherProviderIcon property, I guess skinners could use the addons icon, but those are usually modified.

I have some other properties that weather.com supports so maybe have a list here that we should follow.

Any suggestions.

All sound good to me, especially the WeatherProviderIcon.
find quote