CAddonDll::TransferSettings out of sync?

While working on a screensaver DLL addon, I noticed that I'm not getting a number of settings during TransferSettings (the SetSetting callback sequence). Browsing through the code, it looks like AddonDll.h (CAddonDll::TransferSettings) has a number of the XML tokens different from those in CGUIDialogAddonSettings::CreateControls).

For example, there is a "number" setting type used for numeric settings in CreateControls, but no such thing will transfer in AddonDll.h. Conversely, an "integer" type setting can be transferred, but will never get a control created in the dialog.

Assuming that CreateControls is the canonical listing of setting types, is there a reason that AddonDll.h differs? If not, would anyone object to me providing a patch to bring AddonDll.h back into sync?

On a related note, would there be any objection to adding a "stringtransfer" attribute to the "setting" element (that transfers the setting to the dll as a string instead of trying to cook it to another format)?

-pg

I'm sure noone would object to a patch assuming something is broken (which it sounds like it is)

Ok, there's a trac item (#13160) with the patch added as an attachment, and I've also created a pull request (#1132) for the commit.

Anything else I need to do? I'm not sure I've done the pull request entirely right, but it seems ok....

Thanks - just a couple of nits if you wouldn't mind taking care of them.

Cheers,
Jonathan