Fix Xbox 360 controller support

Now working on checking OSX. I'm using the driver recommended around town and found here:

http://tattiebogle.net/index.php/Project...iver#toc11

Update:
The good news is that the buttons do show up using the Joystick and Gamepad Tester for OSX found here:
http://alphaomega.software.free.fr/joyst...ester.html

The keys displayed there are:
http://pastebin.com/9qHPdZuV

Which of course are marginally different than our keymap. Particularly around the stick button/start+back+guide area. At least ABXY are the same.

The bad news is that the controller doesn't appear to show up at all in the debug log. The only attached devices are:
06:24:01 T:140735106126208 DEBUG: USB Device Attach:IR Receiver, -49217536
06:24:01 T:140735106126208 DEBUG: USB Device Attach:Apple Internal Keyboard / Trackpad, -99483648

I'm attaching my entire debug log, in case I'm looking in the wrong place.
http://pastebin.com/6JD2hWsW

shiretoko212: Yes I restarted xbmc after loading the xboxdrv driver. I was able to have a mouse with the right joystick but none of the buttons were working. Will do some more testing tonight.

maboivin: What distro and release are you using? In Ubuntu-based distros, at least in my testing, xboxdrv isn't even required for the xbox 360 controller to work, unless you want advanced functionality.

natethomas: Perhaps contacting the developer of that driver might help, if he's receptive. Looks like he updated the driver 2 months ago, so he's still active. It would be nice to add support for OSX, even though it isn't a built in official driver. Fixing support for Linux is probably higher priority though, since it has built in drivers for 360 controllers (at least in Ubuntu), and XBMC distributes its own version of it.



Jackpot! http://lxr.free-electrons.com/source/dri...ick/xpad.c See lines 120-170 for every xpad device name possible on Linux. Some of the names do overlap with Windows, so the XBMC linux version might need its own specific keymap version. I've updated the list in the parent post with all applicable 360 device names from that list, excluding dance mats and guitars. Since they classify whether it's xbox or 360, the xbox 1 keymap should probably gain some altnames from that list. Now if we could only see the source code for Microsoft's driver for all the device names they have... I wonder if that's asking for too much.

That's a lot of names. I hate to suggest it, but I'm beginning to wonder if we might want to take a deeper look altogether at controller support for Gotham. Dozens of keymap altnames feels awkward. Perhaps it might be better to try to emulate the USB-CEC adapter method, where an application intelligently figures out what controller is connected and adjusts the settings accordingly.

Just a thought for the future.

I went through the list, and there are only 8 device names for 360 controllers in xpad (a 9th for a catch all unknown category that 360 controllers sometimes show up as and a 10th for xboxdrv). The size of the list is inflated by dancepads and guitar hero devices that no one would use for controlling xbmc anyway. As far as expanding xbox 1 altname support, I'm sure it isn't more than a dozen more names. I do agree that a better system would be nice in the future, but I think we can make this happen in Frodo using the altname method, right? (If they make a better system in the future, they can always clean up the keymap modifications we make.) Now that we know all 10 linux device names, all we have to do is make a keymap that maps the same way as in Windows for consistency, and since it will be a separate keymap file per platform, the list won't look so long.

Seems right, though I'm not sure how to narrow keymap by platform in the case of name duplication.

natethomas: It may require a code and/or packaging change. However, of the known Windows device names, only Xbox 360 Wireless Receiver overlaps, and I don't know for sure that Xbox 360 Wireless Receiver is a Windows device name.

OK. I spent a few hours working with the keymaps on Xubuntu via both xpad and xboxdrv. xboxdrv is going to require its own keymap, as a few axes are different from xpad. That's okay, because it has a simple unique device name. A few of the button IDs are different for the thumbsticks and back/guide buttons compared to the Windows keymap (especially considering Windows can't use the guide button on the keymap), but both xpad and xboxdrv share everything other than a few axes.

In both xboxdrv and xpad, I can't find a button number for the Start button. I've tried mapping actions to button 0 through 42 and to the tag start, but the start button still does nothing. However, I can see from the xboxdrv output that start does respond to being pressed: "X1: 1086 Y1: -1103 X2: -3310 Y2: -1653 du:0 dd:0 dl:0 dr:0 back:0 guide:0 start:1 TL:0 TR:0 A:0 B:0 X:0 Y:0 LB:0 RB:0 LT: 0 RT: 0" I just can't find out what mapping is being triggered in xbmc when it's pressed. Not the end of the world but needs to be fixed somehow for crossplatform consistency. Button 8 maps to nothing on the controller, which is very strange. That should be where start is mapped, but it does nothing.

Last but not least, the following issue is critical, and until this is fixed, I consider Linux support for 360 controllers to be broken. One thing both xpad and xboxdrv have in common is broken triggers. Even if the triggers aren't mapped, pressing them at all even once causes all axis actions (thumbsticks) to malfunction for the duration of the xbmc session. This doesn't make sense, since xboxdrv reports the pressing of each trigger as a number between 0 and 255, LT and RT respectively. I can make one of them kind of function via axis 6 value -1/+1, but not perfectly (breaks other axes), and it still doesn't fix the malfunctions of the other axes. Something about the way xpad and xboxdrv report xbox 360 trigger actions sends xbmc on the fritz. It might be something requiring a fix on the code level.

Anyhow, here's the beta of each for people to play with on Linux to see if they can fix it. I fixed all the sections in v0.2. Since I populated the device list from the xpad source code (lines 120-170), there shouldn't be any missing 360 device names, at least in the case of Linux.

Edit: See parent post for the keymaps.

Nice work on that Shiretoko. I'm going to try to get the XBMCbuntu and OpenELEC guys to take a look at this thread to see if/what 360 driver is packaged in.

I've emailed the OSX driver writer. No response yet, but I'd probably give him at least a day to respond.

Thanks for your work Shiretoko

Out of curiosity what does your xbmc.xboxdrv file look like?

haywire: I left xboxdrv completely unaltered and default, latest version 0.8.4, installed from the Xubuntu 12.10 x64 repos. If you're looking for the keymap, see the parent post.