June Snapshot - Why is epsiode count now total, previously unwatched?

  Thread Rating:
  • 0 Votes - 0 Average
  • 1
  • 2
  • 3
  • 4
  • 5
Post Reply
bossanova808 Offline
Donor
Posts: 2,228
Joined: Sep 2009
Reputation: 34
Location: Melbourne, Australia
Post: #1
Ok so I am trying the June snapshot out - my normal view for TV shows is:

Media Info
Sort By: Episodes (Ascending)
Hide Watched Yes

This normally gives me a list from top to bottom of shows we're watching with the most frequent (thus minimum episodes remaining) at the top.

So maybe:
Falling Skies 1
Walking Dead 2
...and then shows with more unwatched episodes at the bottom etc.

But with the June nightly, it's now showing TOTAL number of episodes for that show (i.e. watched + unwatched), instead of the count of unwatched only - which is way less useful (to me!), so:

Falling Skies 15 (but we've watched all but one)
Walking Dead 26
...etc

Bug, or intentional? My guess is bug as I can't see why you'd want the count to reflect total with 'hide watched' in place.

My XBMC stuff:
find quote
jmarshall Offline
Team-XBMC Developer
Posts: 26,228
Joined: Oct 2003
Reputation: 177
Post: #2
The order of things was changed a bit, so it could well be a screwup. Drop Voyager-xbmc a PM and ask him to take a look.

Always read the XBMC online-manual, FAQ and search the forum before posting.
Do not e-mail XBMC-Team members directly asking for support. Read/follow the forum rules.
For troubleshooting and bug reporting please make sure you read this first.


[Image: badge.gif]
find quote
bossanova808 Offline
Donor
Posts: 2,228
Joined: Sep 2009
Reputation: 34
Location: Melbourne, Australia
Post: #3
Cool, done.

My XBMC stuff:
find quote
Voyager Offline
Team-Kodi Member
Posts: 357
Joined: Apr 2010
Reputation: 5
Location: Belgium
Post: #4
(2012-07-14 00:32)jmarshall Wrote:  The order of things was changed a bit, so it could well be a screwup. Drop Voyager-xbmc a PM and ask him to take a look.

Should not have changed that much. I took a quick look and from first sight it seems more like a refresh issue. The start value is the total number of episodes but gets updated in ApplyWatchedFilter. The season or show node itself doesn't get added or removed so there must be something causing it not to update. I'll have a more thorough look in the next few days.
(This post was last modified: 2012-07-16 13:59 by Voyager.)
find quote
bossanova808 Offline
Donor
Posts: 2,228
Joined: Sep 2009
Reputation: 34
Location: Melbourne, Australia
Post: #5
Thanks Voyager-xbmc.

My XBMC stuff:
find quote
Voyager Offline
Team-Kodi Member
Posts: 357
Joined: Apr 2010
Reputation: 5
Location: Belgium
Post: #6
been looking at it - it seems that the root cause is that watched/unwatched filtering, which is now part of overall filtering (thus called by OnFinalizeItems) is called AFTER FormatAndSort.
Previously, watched/unwatched was part of OnPrepareFileItems, which is called BEFORE (see CGUIMediaWindow::Update).

With that in mind, I've started to fix it and got promising result for the initial load of the list, I still need to fix it for the toggle after the list is loaded. Some refresh issue remains - I'll keep you posted when it's fixed.
find quote
bossanova808 Offline
Donor
Posts: 2,228
Joined: Sep 2009
Reputation: 34
Location: Melbourne, Australia
Post: #7
Great! (and explains why I couldn't find a simple solution in the skin files!)

My XBMC stuff:
find quote
Voyager Offline
Team-Kodi Member
Posts: 357
Joined: Apr 2010
Reputation: 5
Location: Belgium
Post: #8
pull request https://github.com/xbmc/xbmc/pull/1176 sent!
find quote
bossanova808 Offline
Donor
Posts: 2,228
Joined: Sep 2009
Reputation: 34
Location: Melbourne, Australia
Post: #9
Hey folks - just tried out the latest alpha4

It works in the sense of the count is right, but unfortunately it's still a bit broken - if you mark something as watched (or sometimes when you exit and re-enter the view) - the sort order is lost...it flicks back to alphabetical rather than episode sort order.

Any chance you could take another look at it??

My XBMC stuff:
find quote
Voyager Offline
Team-Kodi Member
Posts: 357
Joined: Apr 2010
Reputation: 5
Location: Belgium
Post: #10
Fixed it, https://github.com/xbmc/xbmc/pull/1288
find quote
bossanova808 Offline
Donor
Posts: 2,228
Joined: Sep 2009
Reputation: 34
Location: Melbourne, Australia
Post: #11
Bloody hell that was fast! Thanks!

My XBMC stuff:
find quote