Posts: 5
Joined: Jul 2012
Reputation:
1
Hi all,
I was taking a peek at the ISO9660 code and found something quite suspicious:
iso9660.cpp:531 memcpy( &m_info.isodir, m_info.iso.szRootDir, sizeof(m_info.isodir));
szRootDir is only 34 bytes and isodir is of type iso9660_Directory which is 545 bytes.
I would patch it but I don't know the exact intention.
Mike
Posts: 16,946
Joined: Feb 2011
Reputation:
256
2012-07-19, 10:25
(This post was last modified: 2012-07-19, 10:25 by Memphiz.)
Wow this really looks like bullshit. No clue either what was the intention.
AppleTV4/iPhone/iPod/iPad: HowTo find debug logs and everything else which the devs like so much:
click here
HowTo setup NFS for Kodi:
NFS (wiki)
HowTo configure avahi (zeroconf):
Avahi_Zeroconf (wiki)
READ THE IOS FAQ!:
iOS FAQ (wiki)
Posts: 2,745
Joined: Oct 2003
Reputation:
1
WiSo
Team-Kodi Developer
Posts: 2,745
Did you check if its still in use on win32? Windows can read those disc so we could use hdfile here. But I assume that the iso9660 protocol isn't use any more on win and could be removed.
Posts: 5
Joined: Jul 2012
Reputation:
1
2012-07-25, 04:32
(This post was last modified: 2012-07-25, 04:32 by jabbera.)
Sorry, that just means I was compiling for windows. I think it's a problem everywhere. I'm trying to figure out how to get xbmc to access an iso.
Posts: 328
Joined: Jul 2011
Reputation:
7
2012-07-25, 17:42
(This post was last modified: 2012-07-25, 17:43 by edrikk.)
Well, it wouldn't overflow 'cause it's only copying the correct number of bytes over.
IF the code is being used, my guess is that nobody's noticed because the members referenced in the copy (after the memcpy) are luckily in the first 32 bytes...
Posts: 16,946
Joined: Feb 2011
Reputation:
256
2012-07-25, 22:36
(This post was last modified: 2012-07-25, 22:36 by Memphiz.)
edrikk it would overflow the source buffer ... not the destination ... well not overflow - but bad access...
AppleTV4/iPhone/iPod/iPad: HowTo find debug logs and everything else which the devs like so much:
click here
HowTo setup NFS for Kodi:
NFS (wiki)
HowTo configure avahi (zeroconf):
Avahi_Zeroconf (wiki)
READ THE IOS FAQ!:
iOS FAQ (wiki)