[dhead]

Updates:
xvdr addon compiled to work with margro's eden pvr v4 build,
I would love to get some feedback about playing channels streams.
https://dl.dropbox.com/u/6902100/HT/pvr....4-rev1.rar
Here's the source files used: https://github.com/dhead666/xbmc-addon-x...2a6ef186b9
Known issue: Some channels are missing, this probably will disappear on later builds (I hope this is some pvr api mixup and not my commits).

My current tree includes changes made by margro to adapt pvr api changes, will not work with margro's eden pvr v4 build only with later builds (hopefully).
https://github.com/dhead666/xbmc-addon-xvdr



About my changes:
I wanted to have a nice vc++ project (adapted from margro's project) for xvdr addon.
My main concerns were to get the addon compile on windows,
to use the same tree structure as in pipelka's tree (and not as in margro's),
include some of margro's changes related to the pvr api,
and to push this to pipelka's tree with the hope margro will update his xbmc tree
and his later pvr builds will include a working xvdr addon.

Keep in mind that I'm not a developer and have no idea in c++,
but with a bit of googling anyone there's no limit.

[dhead]

I've pushed my changes to Github, so anyone who want to have a look here's the link: https://github.com/dhead666/xbmc-addon-xvdr

[dhead]

Update: I found the fault, now the plugin compiles with no errors.
I would appreciate if someone could try this with margro's Eden PVR v4 build.
https://dl.dropbox.com/u/6902100/HT/pvr....-test1.rar
http://www.scintilla.utwente.nl/~marcelg....html#eden

[dhead]

I've update the source files to include pvr api's adapt changes made by margro,
source can be found at https://github.com/dhead666/xbmc-addon-xvdr
I would love if anyone could compile an updated version of xbmc from margro tree.


Anyone who want to compile this addon to work with margro's Eden Pvr v4 build need to use commit 9e5ddede7b, commit's tree in https://github.com/dhead666/xbmc-addon-x...2a6ef186b9


The only change that I made and don't like is in src/xvdr/XBMCCallbacks.cpp

Old:

Code:

va_start(ap, &text);

New:

Code:

va_start(ap, level);

Just removing the & will break the addon.
Any suggestions?

[opdenkamp]

Any suggestions?

yes, I suggest you base your work on the official dev tree, not a derative

[dhead]

Any suggestions?

yes, I suggest you base your work on the official dev tree, not a derative

I'm not sure I'm following you,
Do you mean that some file's like XBMCCallbacks.cpp are derivatives and aren't supposed to be changed, meanings only the originals should be used (located in /xbmc/addons)

I'm trying to avoid forking the whole xbmc tree altogether,
Anyway, I'll probably have to get a closer look at the official dev tree later.