Subtitle support improved

What do you think about separating subtitles and audio settings in VideoFullScreen?

I was thinking about, say, VideoSubtitlesSettings.xml dialog that would be called from a dedicated button in OSD, which will integrate SubtitlesDownload add-on as well:



I forgot BROWSE button which should go between subtitle list and GET MORE/DOWNLOAD button that would fire up subtitles add-on.



Further improvement would be ability to choose between subtitles disabled or preferred subtitle language in XBMC settings with a fallback to first available one if preferred language is not available.

I will make a ticket if you would find suggestion worthwhile.

like this?

https://github.com/amet/xbmc/commit/0047...7e9479a72a

I have started working on this but we are still discussing the best approach. all ideas we came up with are increasing a number of clicks to get to subtitle download and/or are adding another button to a OSD screen.

idea was to somehow separate core addon function from the services, so that services maintainers can submit to official repo instead of submitting to XBMC Subtitles repo. we also started working on moving the search window into core but I think that I don't like that idea anymore


any ideas are welcome...

Well, yes, exactly like that!

Some ideas from my side:

IMHO, adding another button should be avoided if at all possible. That leave as with 1 button that would fire up subtitle settings. To reduce number of clicks, download should be at 1st (default focus) position. That is just 1 additional click and other features will more than compensate this "problem". If we put SUBS OFF as last item we could benefit from list wrapping - press up to go to last item.

OSDSubtitleSettings dialog could look like this:

- Download
- Browse
- Delay
- local sub 1
- local sub 2
...
- Turn Off Subs

If we would have ability to define preferred languages for audio and subtitles in XBMC settings, this would greatly reduce necessity to use OSDSubtitleSettings. Those user preferences could be made available to subtitle downloader add-on, so it would not be necessary to have them in add-on settings any more. I can't really comment on idea of splitting services and search functionality but it sounds to me it could be a bit confusing to download and install services as separate add ons. I use 4 of them to make sure Serbian or Czech subtitles are found (with fallback to English ones).

If above suggestions would be implemented, my use case would be:

Kids profile - 1st preferred audio track set to Serbian, second Czech. Preferred subtitles - OFF
Adults - Audio: English/Serbian/Czech Subs: Serbian/Czech/English

Hope this helps a bit.