Changes to the handling of DVD folders

dragonflight · 2012-10-03 23:44

I am perplexed by the current handling of DVD folders. In my IMHO both

name1/name2/VIDEO_TS/VIDEO_TS.IFO
name1/name2.iso

should be handled in the same way, in particular when scanning with the option "movies in folders" the name of the movie should be "name1" in both cases, yet the software makes special effort so that in the case of the DVD folder the name is "name2" regardless of the option? Can anyone explain why?

currently, my understanding is the following are the differences

Code:

.                               ISO                    DVD Folder

nfo's                          name1/name2.nfo        name1/name2/VIDEO_TS/VIDEO_TS.nfo

thumbs                         name1/name2.tbn        name1/name2/VIDEO_TS/VIDEO_TS.tbn

Movie name

  (with "movies in folders")   name1                  name2

episode matching                                      need to add expressions matching VIDEO_TS/VIDEO_TS.IFO

I have a patch which makes them the same. Is there any objection/interest in making it an advancedsetting.xml option?
(haven't looked at the last one yet)

mike

**jmarshall** · 2012-10-04 01:32

It doesn't make any such effort - the default is to take the name from the filename. Obviously, with a dvd folder, the filename is useless, so we go up to the non-useless foldername by default. Metadata is taken from both the VIDEO_TS files (for backward compatibility) and from the parent folder (folder.jpg/movie.nfo) which I personally prefer, as you shouldn't be messing with DVD file structures. I can't guarantee this always works in Eden (or even in Frodo nightlies - look at the code and you'll quickly see why!), but that's how it'll work in Frodo.

Cheers,
Jonathan

dragonflight · 2012-10-04 02:02

Jonathan,

I am glad to hear you say that. I emphatically believe you shouldn't be messing with the DVD file structure.

in FileItem.cpp GetBaseMoviePath gets the parent of the VIDEO_TS folder as the movie name regardless of the usefolder option and testGetBaseMoviePath indicates it is intentional.

There is another place where the comments state that the system will use the parent of VIDEO_TS as the movie name regardless of the state of the usefolder option, I just can't seem to find it at the moment.

As far as I can tell, the only place the preformatted label is used is when set by the scanner when it first looks at a DVD Folder and then that is used as the movie name regardless of the usefolder option.

Finally when you save the library into individual files it places the nfo and thumbs and .actor directory into the VIDEO_TS folder.

Last couple of time I tried to update to the Frodo nightlies (I must have screwed up) I couldn't get them to compile, so I am a couple of weeks behind.

I can separate the patches from the other stuff I've been playing with - excess debugging lines!, if you want to look them over.
As I posted I haven't look at why the regular expressions need to be modified to work with DVD Folders - I just copied the ones with video_ts.. in them and they seem to work

thanks
mike

**jmarshall** · 2012-10-04 03:51

Yeah, the export is planned to be outside the structure (I'm redoing that as part of the arbitrary art stuff).

The default regexps specifically target the file (see how we don't allow a directory separator after the matches). Otherwise they would work on the dvdfolder name.

Cheers,
Jonathan

dragonflight · 2012-10-04 04:10

Yeah I looked up the default matches, it seems to me that the decision to not treat a DVD Folder as a video item and instead treat the VIDEO_TS/VIDEO_TS.IFO file as the video item was unfortunate. I think it would clean a lot of stuff up if it were changed. It would take out a lot of exceptions and make sure that DVD Folders were treated just like an iso (or a rar/zip) file.

I guess you're also working on the export/import of data for TV shows. As you probably noticed I would like to be able to collapse the info from the episodes.nfo files into the tvshow.nfo.

mike

WarthogCC · 2012-10-21 09:30

I originally came across this thread with the same concern. But I thought I'd add a question that is somewhat relevant.

Movie info poster and fanart selection....

I noticed it adds the poster and fanart to the .IFO file. Which is cool.
But when I went back a couple of directories to see if it added them to the root folder, it only displayed the poster but not the fanart in the background.

It would kind of nice to see both displayed at the root level where I'm usually browsing all my DVD folders.

Any ideas?

dragonflight · 2012-10-22 23:06

I don't have fanart displayed in the background, but I tried it and with my changes it does display the fanart, but another good reason to change the way the system works.
As a matter of interest, do you usually use movies in folders and if so how do you name your dvd folders? movie/folder/VIDEO_TS or Movie/VIDEO_TS ?
In keeping with the theme DVD folders should be like DVD.iso I'm pushing for movie/folder/VIDEO_TS, which would be like movie/folder.iso

comments?

PS I'm still getting my library scanned and I want to play a little before I submit my changes, but if you wanted to test them I would be happy to supply them