Posts: 26,215
Joined: Oct 2003
Reputation:
187
Longer answer: You CAN specify it via the aspect attribute, however XBMC will not automatically detect it at scan time. It will, however, store the XML from the scrape in the database with that attribute, and hence once you set cdart on the movie item (e.g. via JSON-RPC) those cd-art items will be available for the user to select when they click on "cd-art" in the "Choose Art" dialog.
i.e. it works like this:
1. XBMC stores the <thumb> urls returned from the scraper.
2. XBMC automatically assigns the "poster", "banner", and "fanart" aspects to art (fanart is handled via <fanart> atm).
3. JSON-RPC can set arbitrary art types on videos via SetMovieDetails and the art property.
4. When the user clicks "Choose Art", then all art types available for the item in the database are listed.
5. The art type is then used to pick out the appropriate <thumb> urls to show.
Note: If you do this, then the cdart will not be available to choose in the filebrowser when the user clicks on "poster" or "banner" in the Choose Art dialog.
There's a question as to whether XBMC should read arbitrary aspect tags in the XML and assign those (first come first served). I'm open to that suggestion. It would basically mean that scrapers could automatically assign art that XBMC didn't support out of the box. Thoughts?
Cheers,
Jonathan
Posts: 2,180
Joined: Nov 2011
Reputation:
61
Thanks guys for your answers.
I'm not sure to fully understand it :S
Sorry for my english, but, you know, I'm French so ...
Main HTPC : Odroid-C2 running CoreELEC with Titan Bingie
Secondary HTPC : Freebox Mini 4K running Android TV with Titan Bingie
Posts: 1,052
Joined: Jul 2011
Reputation:
89
scudlee
Retired Team-Kodi Member
Posts: 1,052
Wouldn't a cleaner approach for the Choose Art dialog be to only automatically include posters, banners, and fanart, but allow the skin to manually include the art types it supports? So, if a skin doesn't support e.g. discart, the option won't be shown even if the item has discart set, and if the skin does support it, it'll still show an empty entry even if the item doesn't have any discart set.
If a skin asks for a specific art type to use in a view, surely the logical sequence for XBMC is:
1. Check the art table, return if found
2. Else check local folder, add to the art table and return if found
3. Else check scraped thumbs, add the first match to the art table and return
4. Else shrug and give up
You wouldn't then need to add the (potentially completely arbitrary) art types to the art table after/during the scrape, only upon skin request.
Posts: 26,215
Joined: Oct 2003
Reputation:
187
You have to do it during scrape, as if it's not in the database you simply don't have it available to the skin, to JSON-RPC or to anywhere else.
Posts: 26,215
Joined: Oct 2003
Reputation:
187
No. I've taken a look, and it's a non-trivial change. Thus, after Frodo.