Add discart to scraper : possible or not ?

Wouldn't a cleaner approach for the Choose Art dialog be to only automatically include posters, banners, and fanart, but allow the skin to manually include the art types it supports? So, if a skin doesn't support e.g. discart, the option won't be shown even if the item has discart set, and if the skin does support it, it'll still show an empty entry even if the item doesn't have any discart set.

If a skin asks for a specific art type to use in a view, surely the logical sequence for XBMC is:
1. Check the art table, return if found
2. Else check local folder, add to the art table and return if found
3. Else check scraped thumbs, add the first match to the art table and return
4. Else shrug and give up

You wouldn't then need to add the (potentially completely arbitrary) art types to the art table after/during the scrape, only upon skin request.

You have to do it during scrape, as if it's not in the database you simply don't have it available to the skin, to JSON-RPC or to anywhere else.

(2012-11-13 23:45)jmarshall Wrote:  There's a question as to whether XBMC should read arbitrary aspect tags in the XML and assign those (first come first served). I'm open to that suggestion. It would basically mean that scrapers could automatically assign art that XBMC didn't support out of the box. Thoughts?

Cheers,
Jonathan

that would be great. an additional "extra artwork" scraper would be the most user-friendly way i think.

(2012-11-15 00:24)jmarshall Wrote:  You have to do it during scrape, as if it's not in the database you simply don't have it available to the skin, to JSON-RPC or to anywhere else.

What if, then, you instead add every thumb or fanart scraped to the art table, and just add an extra field to keep them sorted per type per item, so when a skin or add-on requests a specific art type for an item, it's really just asking for the one marked number 1 among all those in the table. That way it's either there or it's not, and it doesn't matter how it got there, via scraper or through JSON-RPC. This would also allow an add-on like the artwork downloader to add multiple alternatives for each extra art type, not just one. The Choose art dialog could then just enumerate the entries from the table, and switching would just be a case of swapping out the order between the chosen art and the current.

No. I've taken a look, and it's a non-trivial change. Thus, after Frodo.

Sorry, didn't mean to imply I was expecting this for Frodo, I was always assuming it was far too late now for that.