Login at Kodi Home

**curtis-r** · (This post was last modified: 2013-01-06, 00:40 by curtis-r.)

Not being able to code python, unfortunately I'll have to rely on someone more knowledgable to mod the gui.py for this screensaver to allow EXIF data to be displayed. If anyone can help with that, I should have no trouble coding the script-python-slideshow.xml to display some of that data.

UPDATE: I tried to implement this EXIF.py but there is simply too much about python I do not know.

**ronie** · 2013-01-06, 01:00

i had a look at it last night.
the main problem i see is that it's only possible to read exif info from local files.

if you store your pictures on a remote share, you're out of luck.

0x15e · 2013-01-06, 03:23

(2013-01-06, 01:00)ronie Wrote: i had a look at it last night.
the main problem i see is that it's only possible to read exif info from local files.

if you store your pictures on a remote share, you're out of luck.

As for that EXIF.py thing, we should just be able to import EXIF and then use EXIF.process_file. It just wants an open file object. Something like:

EXIF.process_file(file_object, 'Orientation', details=False)

Getting that open file object can probably be done using the xbmcvfs.File object, right? I don't think it's a proper Python file but it should be a starting point. Maybe we could wrap it or modify EXIF.process_file to be able to use it directly.

Unfortunately none of this addresses getting image dimensions for the black bar compensation. It looks like you did some work on that with PIL but removed it in r528. Maybe there's a native Python way to do that or get Xbmc to tell us after the image has been loaded.

**curtis-r** · 2013-01-06, 20:19

(2013-01-06, 01:00)ronie Wrote: if you store your pictures on a remote share, you're out of luck.

Actually, my media except for my screensaver pictures are on a remote server. I didn't like my server having to spin up just for screensavers, so I have a local folder for screensaver pictures. Of course, that still leaves the glaring problem that I can't code python Sad

I appreciate everyone's effort. Hopefully someone can get 'this working.

xorcist83 · (This post was last modified: 2013-01-07, 01:03 by xorcist83.)

I'm having problems with some images displaying really blurry and pixelated. Happens regardless which effect I'm using (Pan&Zoom, Slide, Crossfade).

Running XBMC Frodo RC3, Slideshow 0.0.3 on OS X 10.8.2 @ 1920x1080 resolution.

Original:

Displayed as:

I have other jpgs in the same folder in the same resolution displaying fine. For example:

EDIT: Corrected url to blurry image

**ronie** · 2013-01-07, 00:49

(2013-01-06, 22:51)xorcist83 Wrote: I'm having problems with some images displaying really blurry and pixelated. Happens regardless which effect I'm using (Pan&Zoom, Slide, Crossfade).

Running XBMC Frodo RC3, Slideshow 0.0.3 on OS X 10.8.2 @ 1920x1080 resolution.

Original:
Displayed as:

I have other jpgs in the same folder in the same resolution displaying fine. For example:

can't help you with that i'm afraid.

image processing is handled by xbmc, not the addon.
it's weird though since the source image is 19280x1080
and matching your display, so there shouldn't be any scaling involved.

**ronie** · 2013-01-07, 01:49

(2013-01-06, 03:23)0x15e Wrote: As for that EXIF.py thing, we should just be able to import EXIF and then use EXIF.process_file. It just wants an open file object. Something like:

EXIF.process_file(file_object, 'Orientation', details=False)

Getting that open file object can probably be done using the xbmcvfs.File object, right? I don't think it's a proper Python file but it should be a starting point. Maybe we could wrap it or modify EXIF.process_file to be able to use it directly.

that's what i tried with PIL. but PIL requires file read, seek and tell methods.
xbmcvfs.File() provides read and seek, but not tell.

reading the EXIF.py code, it see it also needs tell.

(2013-01-06, 03:23)0x15e Wrote: Unfortunately none of this addresses getting image dimensions for the black bar compensation. It looks like you did some work on that with PIL but removed it in r528. Maybe there's a native Python way to do that or get Xbmc to tell us after the image has been loaded.

i've added a 'scale images fullscreen' option in the settings.
that should do what you're after i think.

**ronie** · (This post was last modified: 2013-01-07, 01:51 by ronie.)

screensaver.xbmc.slideshow-0.0.4.zip

please test and let me know what issues you find with this version.

0x15e · 2013-01-07, 04:58

Looks great! Much smoother all-around.

The crossfade can still be a little inconsistent but it's nothing like before. I really have to be watching for it to see a problem.

I also saw where one image came up black but I'd chalk that up to a bad pic.

I'll stay on the EXIF thing. Since .tell() just returns the current file position, I'll look into wrapping the xbmcfs.File object with something that will track the seeks and reads so it can return the proper value for tell.

**Raytestrak** · 2013-01-07, 18:32

Awesome! Love the full screen option!

**ronie** · 2013-01-07, 18:38

(2013-01-07, 04:58)0x15e Wrote: I'll stay on the EXIF thing. Since .tell() just returns the current file position, I'll look into wrapping the xbmcfs.File object with something that will track the seeks and reads so it can return the proper value for tell.

well i certainly agree on the exif stuff.
i'll add least make a request to add the tell method post frodo.

keep me posted if you get something going.

**ronie** · 2013-01-07, 19:50

(2013-01-07, 18:38)ronie Wrote:
(2013-01-07, 04:58)0x15e Wrote: I'll stay on the EXIF thing. Since .tell() just returns the current file position, I'll look into wrapping the xbmcfs.File object with something that will track the seeks and reads so it can return the proper value for tell.

well i certainly agree on the exif stuff.
i'll add least make a request to add the tell method post frodo.

keep me posted if you get something going.

heh, that turned to be pretty easy, just two minor changes to EXIF.py
and it seems to be working as a breeze now. Smile

**curtis-r** · 2013-01-07, 20:03

Is it possible to get a copy of your version w/ the exif-data capabilities for me to play with?

**ronie** · 2013-01-07, 20:42

(2013-01-07, 20:03)curtis-r Wrote: Is it possible to get a copy of your version w/ the exif-data capabilities for me to play with?

you can check out the addon from my svn repo:
http://code.google.com/p/ronie/source/browse/

0x15e · 2013-01-08, 03:46

(2013-01-07, 20:03)curtis-r Wrote: Is it possible to get a copy of your version w/ the exif-data capabilities for me to play with?

Not much to look at yet. Looks like it's just code to make sure the EXIF library will work for now. There's still no handling for rotating the image yet. I'm going to spend some time looking at that tonight.