Posts: 492
Joined: Dec 2006
Reputation:
5
Ok. Don't rebuild it yet. :-) I just found the issue.
Basically Finalize shouldn't be called (or at least shouldn't execute) multiple times but it looks like it is. Let me make a change and post back here with a link to a fix in my repo when it's ready.
Posts: 52
Joined: Mar 2010
Reputation:
0
Hurray! I didn't think of checking if finalize was only called once per initialize. Duh!
Posts: 492
Joined: Dec 2006
Reputation:
5
Finalize executes (and unloads python) 10 seconds after the last script closes. By default the 'script.common.plugin.cache' is always running now, so on my system Finalize never gets called during the normal course of running. This has caused other problems we didn't see before since Finalize stopped being called when this script was introduced.
I'm still not sure how it's being called for you since it's not supposed to be called while there's scripts running. In any case, the flag that determines whether or not we've been initialized is interrogated in the Finalize without the lock held. This MAY be an issue if Finalize can be called from any thread other than the main thread (which I'm not sure is actually possible). I can fix this and we can see if it addresses the issue but I tend to doubt it (might as well try though).
I'll be ready within an hour or so (I hope)
Posts: 492
Joined: Dec 2006
Reputation:
5
Thanks. Can you paste your entire log somewhere?
Posts: 492
Joined: Dec 2006
Reputation:
5
Zeflash, I think I managed to reproduce this on Linux (though it doesn't seem to want to do it in the debugger). For now, your system will get more stable if you have the default addon script.common.plugin.cache installed. I'm not sure why it's not there by default but you probably never cleared your user directory since switching to Frodo.
This is not a real solution but might provide a workaround until I figure out what's going on.
Posts: 458
Joined: May 2011
Reputation:
2
Is this commit already in the latest nightlies? I am still getting crashes when I try to do any of the following:
1) open "TV Show Next aired" addon (issue is not always but can be generated if try the this after leaving xbmc for a while)
2) Try to download subtitles (pretty much every time)
3) Open Navi-x sometimes sames as "TV show next aired addon"
Let me know and I can try and see if this is still there. I will get some debug logs too.
thanks
Intel® Quad Core i5 Sandybridge @3.40GHz | ASRock Z775 Mobo 8GB DDR3 Ram | Logitech K400 Keyboard |
| Logitec Harmony 550 Remote| 46' Samsung LCD TV | Onkyo TX-S605 w/ Bose 5.1 Surround