Login at Kodi Home

flyingrat · (This post was last modified: 2013-04-06, 22:09 by flyingrat.)

The IOS/ATV problem is now solved. The root cause was an address alignment problem related to the ARM optimizations in the libavcodec/arm asm files that requires a updated gas-preprocessor.pl to make the assemble process work properly.

FFmpeg does not supply a working gas-preprocessor.pl along with the standard distribution and another complicating factor is that the platform docs is pointing out an erroneous version (github.com/yuvi/gas-preprocessor). The only gas-preprocessor that for the moment works with ffmpeg 1.2 is github.com/mansr/gas-preprocessor, rev 76a72f00e (Dec 03, 2012) and this version is now added to the xbmc fork.

I've uploaded two new binaries that have been compiled with the updated gas-preprocessor.pl. I've tested the IOS version that seems to work quite well. Since I don't have access to an ATV I don't know how well that one works thus please test it and get back with some feedback, thanks!

1. org.xbmc.xbmc-ATV2-ffmpeg-1.2-20130406-rev-g88a6773.deb (Apple TV)
2. org.xbmc.xbmc-IOS-ffmpeg-1.2-20130405-rev-g88a6773.deb (iPhone/iPad)

flyingrat · 2013-04-06, 21:37

Issued pull request "[FFmpeg] version bump to n1.2 (rev e820e3a)"

Skank · 2013-04-06, 21:54

Great job! I hope it will be accepted

bjober · 2013-04-07, 00:02

(2013-04-06, 15:22)flyingrat Wrote: The IOS/ATV problem is now solved. The root cause was an address alignment problem related to the ARM optimizations in the libavcodec/arm asm files that requires a updated gas-preprocessor.pl to make the assemble process work properly.

FFmpeg does not supply a working gas-preprocessor.pl along with the standard distribution and another complicating factor is that the platform docs is pointing out an erroneous version (github.com/yuvi/gas-preprocessor). The only gas-preprocessor that for the moment works with ffmpeg 1.2 is github.com/mansr/gas-preprocessor, rev 76a72f00e (Dec 03, 2012) and this version is now added to the xbmc fork.

I've uploaded two new binaries that have been compiled with the updated gas-preprocessor.pl. I've tested the IOS version that seems to work quite well. Since I don't have access to an ATV I don't know how well that one works thus please test it and get back with some feedback, thanks!

1. org.xbmc.xbmc-ATV2-ffmpeg-1.2-20130406-rev-g88a6773.deb (Apple TV)
2. org.xbmc.xbmc-IOS-ffmpeg-1.2-20130405-rev-g88a6773.deb (iPhone/iPad)

Both streams and movie files on my NAS plays fine on the ATV2 now.
SVTplay works flawless in HD again.
Flyingrat and you others you are good sent.
Gonna stick with this build until your work is pulled into mains!
Thanks a lot!

Tell me if you need any info, logs etc.

Björn

**Memphiz** · 2013-04-07, 01:02

(2013-04-06, 15:22)flyingrat Wrote: The IOS/ATV problem is now solved. The root cause was an address alignment problem related to the ARM optimizations in the libavcodec/arm asm files that requires a updated gas-preprocessor.pl to make the assemble process work properly.

FFmpeg does not supply a working gas-preprocessor.pl along with the standard distribution and another complicating factor is that the platform docs is pointing out an erroneous version (github.com/yuvi/gas-preprocessor). The only gas-preprocessor that for the moment works with ffmpeg 1.2 is github.com/mansr/gas-preprocessor, rev 76a72f00e (Dec 03, 2012) and this version is now added to the xbmc fork.

I've uploaded two new binaries that have been compiled with the updated gas-preprocessor.pl. I've tested the IOS version that seems to work quite well. Since I don't have access to an ATV I don't know how well that one works thus please test it and get back with some feedback, thanks!

1. org.xbmc.xbmc-ATV2-ffmpeg-1.2-20130406-rev-g88a6773.deb (Apple TV)
2. org.xbmc.xbmc-IOS-ffmpeg-1.2-20130405-rev-g88a6773.deb (iPhone/iPad)

Nice is this the latest gas-preprocessor.pl from mans rullgard? Or is it a specific revision in between?

**vicbitter** · (This post was last modified: 2013-04-08, 23:59 by vicbitter.)

**DELETED**

flyingrat · 2013-04-07, 17:08

(2013-04-07, 01:02)Memphiz Wrote: Nice is this the latest gas-preprocessor.pl from mans rullgard? Or is it a specific revision in between?

Yep, that's the latest one (afaik).

kokangit · 2013-04-07, 18:29

Hands up for flyingrat!
Running the latest and greatest version for atv2 for 15 minutes now and it's smooooooth! Thanks a bunch for making svtplay work!

**negge** · (This post was last modified: 2013-04-08, 10:50 by negge.)

I just finished hacking together a proxy solution for SVT Play and was kind of saddened to see that the streams stop playing after a short while. I haven't had to time test this new ffmpeg version but I hope it fixes the whole issue. Good work!

moravec · 2013-04-08, 08:23

I just tried "XBMCSetup-20130321-fbdfa49-ffmpeg-n1.2.exe" and there are no PGS subtitles visible in a .mkv (bluray untouched).

bibi · 2013-04-08, 09:34

Thank you.

**jjd-uk** · 2013-04-08, 11:08

(2013-04-08, 08:23)moravec Wrote: I just tried "XBMCSetup-20130321-fbdfa49-ffmpeg-n1.2.exe" and there are no PGS subtitles visible in a .mkv (bluray untouched).

Might be worth someone checking if these fixes have been carried over

https://github.com/xbmc/xbmc/pull/1992

https://github.com/xbmc/xbmc/pull/2002

Discussion at http://forum.xbmc.org/showthread.php?tid=128935&page=5

The ffmpeg ones should now be part of ffmpeg 1.2 I would think

flyingrat · (This post was last modified: 2013-04-08, 18:55 by flyingrat.)

Some general questions regarding external ffmpeg libraries:

I'm just curious, why (and how) are external ffmpeg libraries needed?
Is there a "xbmc policy" regarding external ffmpeg libraries and the level of compatibility that's required?
Is there a separate maintainer for this kind of work?

**vicbitter** · (This post was last modified: 2013-04-08, 19:56 by vicbitter.)

(2013-04-08, 18:55)flyingrat Wrote: Some general questions regarding external ffmpeg libraries:

I'm just curious, why (and how) are external ffmpeg libraries needed?

Is there a "xbmc policy" regarding external ffmpeg libraries and the level of compatibility that's required?

Is there a separate maintainer for this kind of work?

OpenELEC builds with external ffmpeg... The initial refactor of the patches I gave you came from my OpenELEC dev system.

Basically, OpenELEC fetches each of the packages it requires from the original source and applies patches (as needed) on top. So for ffmpeg 1.2, it grabs the ffmpeg 1.2 source tar ball from ffmpeg.org then applies the XBMC patches along with some additional OpenELEC patches before building.

So although, you are applying the XBMC patches to ffmpeg 1.2 (and committing those changes as part of the PR) in lib/ffmpeg, OpenELEC (or I should say XBMC) ignores lib/ffmpeg altogether as XBMC is configured to be built with --enable-external-ffmpeg...

Hopes that helps?

flyingrat · 2013-04-08, 20:12

(2013-04-08, 19:25)vicbitter Wrote:
(2013-04-08, 18:55)flyingrat Wrote: Some general questions regarding external ffmpeg libraries:

I'm just curious, why (and how) are external ffmpeg libraries needed?

Is there a "xbmc policy" regarding external ffmpeg libraries and the level of compatibility that's required?

Is there a separate maintainer for this kind of work?

OpenELEC builds with external ffmpeg... The initial refactor of the patches I gave you came from my OpenELEC dev system.

Basically, OpenELEC fetches each of the packages it requires from the original source and applies patches (as needed) on top. So for ffmpeg 1.2, it grabs the ffmpeg 1.2 source tar ball from ffmpeg.org then applies the XBMC patches along with some additional OpenELEC patches before building.

So although, you are applying the XBMC patches to ffmpeg 1.2 (and committing those changes as part of the PR) in lib/ffmpeg, OpenELEC (or I should say XBMC) ignores lib/ffmpeg altogether as XBMC is configured to be built with --enable-external-ffmpeg...

Hopes that helps?

Great answer, thank you! I conclude that current PR works as expected with external ffmpeg libraries. Btw, are the additional OpenELEC patches platform specific (for RPI, etc)??