Login at Kodi Home

Koraljka · 2016-11-13, 19:59

The addon is fantastic. Can you add an option that when i select a movie (and press OK in remote); it directly plays the first trailer. I do not want to navigate one more time to press play. Thanks. (Or add a continuous play option, that it plays all the movie trailers in a consecutively )

tknorris · (This post was last modified: 2016-11-13, 23:05 by tknorris.)

(2016-11-13, 19:59)Koraljka Wrote: The addon is fantastic. Can you add an option that when i select a movie (and press OK in remote); it directly plays the first trailer. I do not want to navigate one more time to press play. Thanks. (Or add a continuous play option, that it plays all the movie trailers in a consecutively )

That would be more complicated than it sounds. I don't plan on adding it at the moment.

Edit: I changed my mind. I added a context menu item on the movie to play the most recent trailer. Also, I figured out a fix so that the 1080p trailer streams work in Kodi. Both changes are in 0.0.10.

quantum.hero · 2016-12-01, 15:45

Thanks for the awesome fork, works great

gillmacca · (This post was last modified: 2016-12-09, 16:00 by gillmacca.)

Great work on this add-on.
Is it possible to have categories (similar to your trailer source, or what HD-Trailer.net does) on the main view rather than in settings. Would make it look nicer, rather than a long list of movies

tknorris · 2016-12-09, 17:35

(2016-12-09, 12:30)gillmacca Wrote: Great work on this add-on.
Is it possible to have categories (similar to your trailer source, or what HD-Trailer.net does) on the main view rather than in settings. Would make it look nicer, rather than a long list of movies

No, that's not how apple releases them.

am2015 · 2016-12-11, 16:03

@tknorris: The plugin is great but it stopped working for me recently. I'm getting an error:

http://pastebin.com/MZnwcJXw

Can you help?

tknorris · 2016-12-12, 20:04

(2016-12-11, 16:03)am2015 Wrote: @tknorris: The plugin is great but it stopped working for me recently. I'm getting an error:

http://pastebin.com/MZnwcJXw

Can you help?

It's a unicode issue. I'll have a fix in the next build, but in the meantime you can work around it by either
a) setting the download folder to a different location
b) deleting all the files in the download folder location you have set
c) one of the files in your download folder has a non-ascii character, delete that file.

mercanbobbo · 2016-12-22, 01:20

Hi, this add-on was great but now I get the "Network error" message everytime I try to see one of the most recent trailers.
In the log file the error appears as follows:
23:37:01 T:5224 ERROR: XFILE::CDirectory::GetDirectory - Error getting plugin://plugin.video.itunes_trailers/movie/Wheeler/independent%2Fwheeler/show/
23:37:01 T:5224 ERROR: CGUIMediaWindow::GetDirectory(plugin://plugin.video.itunes_trailers/movie/Wheeler/independent%2Fwheeler/show/) failed
23:37:01 T:5224 DEBUG: CGUIMediaWindow::GetDirectory (plugin://plugin.video.itunes_trailers/)
23:37:01 T:5224 DEBUG: ParentPath = [addons://sources/video]
23:37:01 T:6484 DEBUG: XFILE::CPluginDirectory::StartScript - calling plugin Apple iTunes Trailers('plugin://plugin.video.itunes_trailers/','3','')
23:37:01 T:6484 DEBUG: XFILE::CPluginDirectory::WaitOnScriptResult - waiting on the Apple iTunes Trailers (id=13) plugin...

Any idea on the cause of this error and how to fix it?

bushbrother · 2016-12-23, 19:18

Thanks for this add-on. One question though, every time I go back to the main list of movies I get loading for another 30 seconds even though the list refreshed when opening up the plugin. Any thoughts?

**DarrenHill** · 2016-12-23, 23:34

Promotion of and reference to banned addons (wiki) repo removed.

bushbrother · 2016-12-23, 23:43

Sorry how was my post about Apple trailers and going back to the main list of movies trailers a reference to a banned repo?

**DarrenHill** · 2016-12-24, 00:19

(2016-12-23, 23:43)bushbrother Wrote: Sorry how was my post about Apple trailers and going back to the main list of movies trailers a reference to a banned repo?

Sorry, it wasn't, I didn't see it in the middle of the ones for binning.

I've restored it into this thread.

bushbrother · 2016-12-24, 15:56

(2016-12-24, 00:19)DarrenHill Wrote:
(2016-12-23, 23:43)bushbrother Wrote: Sorry how was my post about Apple trailers and going back to the main list of movies trailers a reference to a banned repo?

Sorry, it wasn't, I didn't see it in the middle of the ones for binning.

I've restored it into this thread.

NP. Thanks Smile

bushbrother · (This post was last modified: 2016-12-24, 16:02 by bushbrother.)

(2016-12-23, 19:18)bushbrother Wrote: Thanks for this add-on. One question though, every time I go back to the main list of movies I get loading for another 30 seconds even though the list refreshed when opening up the plugin. Any thoughts?

OK - I took debug logs, looks like default.py gets stuck and then aborts after a while? This is for when i push the back button to return to list of trailers after watching a trailer. Let me know if you need the full log?

As you can see its ~35 seconds from Init of DialogBusy to the DeInit. Any help much appreciated.

Code:
57:25.488 T:1962434880   DEBUG: OnKey: backspace (0xf008) pressed, action is Back

57:25.492 T:1962434880   DEBUG: CGUIMediaWindow::GetDirectory (plugin://plugin.video.apple_trailers/)

57:25.492 T:1962434880   DEBUG:   ParentPath = [plugin://]

57:25.532 T:1402991520   DEBUG: CAddonDatabase::SetLastUsed[plugin.video.apple_trailers] took 40 ms

57:25.538 T:1374679968   DEBUG: StartScript - calling plugin Apple Trailers('plugin://plugin.video.apple_trailers/','13','')

57:25.539 T:1474585504   DEBUG: Thread LanguageInvoker start, auto delete: false

57:25.539 T:1474585504    INFO: initializing python engine.

57:25.540 T:1474585504   DEBUG: CPythonInvoker(28, /storage/.kodi/addons/plugin.video.apple_trailers/default.py): start processing

57:25.621 T:1474585504   DEBUG: -->Python Interpreter Initialized<--

57:25.621 T:1474585504   DEBUG: CPythonInvoker(28, /storage/.kodi/addons/plugin.video.apple_trailers/default.py): the source file to load is "/storage/.kodi/addons/plugin.video.apple_trailers/default.py"

57:25.622 T:1474585504   DEBUG: CPythonInvoker(28, /storage/.kodi/addons/plugin.video.apple_trailers/default.py): setting the Python path to /storage/.kodi/addons/plugin.video.apple_trailers:/storage/.kodi/addons/script.module.tknorris.shared/lib:/usr/lib/python27.zip:/usr/lib/python2.7:/usr/lib/python2.7/plat-linux2:/usr/lib/python2.7/lib-tk:/usr/lib/python2.7/lib-old:/usr/lib/python2.7/lib-dynload:/usr/lib/python2.7/site-packages:/usr/lib/python2.7/site-packages/gtk-2.0

57:25.622 T:1474585504   DEBUG: CPythonInvoker(28, /storage/.kodi/addons/plugin.video.apple_trailers/default.py): entering source directory /storage/.kodi/addons/plugin.video.apple_trailers

57:25.622 T:1474585504   DEBUG: CPythonInvoker(28, /storage/.kodi/addons/plugin.video.apple_trailers/default.py): instantiating addon using automatically obtained id of "plugin.video.apple_trailers" dependent on version 2.1.0 of the xbmc.python api

57:25.912 T:1474585504   DEBUG: Apple Trailers: Calling cached method: |lib.trailer_scraper.Scraper.__get_url|(<lib.trailer_scraper.Scraper object at 0x58829510>, 'http://trailers.apple.com/trailers/home/xml/current.xml')|{}|

57:25.995 T:1962434880   DEBUG: ------ Window Init (DialogBusy.xml) ------

57:26.458 T:1474585504  NOTICE: Apple Trailers: Version: |0.0.11| Queries: |{'mode': 'main'}|

57:26.458 T:1474585504  NOTICE: Apple Trailers: Args: |['plugin://plugin.video.apple_trailers/', '13', '']|

57:26.458 T:1474585504  NOTICE: Apple Trailers: Calling |show_movies| for mode |main| with pos args |[]| and kwargs |{}|

57:26.459 T:1474585504   DEBUG: Apple Trailers: List Dict: : {}

57:26.459 T:1474585504   DEBUG: Apple Trailers: Calling cached function: |get_movies|(0, 0)|{}|

57:26.459 T:1474585504   DEBUG: Apple Trailers: Calling cached method: |lib.trailer_scraper.Scraper.__get_url|(<lib.trailer_scraper.Scraper object at 0x58829510>, 'http://trailers.apple.com/trailers/home/feeds/studios.json', None)|{}|

57:47.911 T:1962434880    INFO: CheckIdle - Closing session to http://trailers.apple.com (easy=0x4e63e078, multi=0x5a10eb78)

57:53.744 T:1962434880  NOTICE: NFS is idle. Closing the remaining connections.

57:55.539 T:1462760352   DEBUG: Thread JobWorker 1462760352 terminating (autodelete)

57:55.539 T:1416623008   DEBUG: Thread JobWorker 1416623008 terminating (autodelete)

57:55.540 T:1402991520   DEBUG: Thread JobWorker 1402991520 terminating (autodelete)

58:00.713 T:1474585504    INFO: CPythonInvoker(28, /storage/.kodi/addons/plugin.video.apple_trailers/default.py): script aborted

58:00.718 T:1962434880   DEBUG: ------ Window Deinit (DialogBusy.xml) ------

58:00.740 T:1474585504    INFO: Python script stopped

58:00.741 T:1474585504   DEBUG: Thread LanguageInvoker 1474585504 terminating

tknorris · 2016-12-24, 20:24

(2016-12-24, 15:57)bushbrother Wrote:
(2016-12-23, 19:18)bushbrother Wrote: Thanks for this add-on. One question though, every time I go back to the main list of movies I get loading for another 30 seconds even though the list refreshed when opening up the plugin. Any thoughts?

OK - I took debug logs, looks like default.py gets stuck and then aborts after a while? This is for when i push the back button to return to list of trailers after watching a trailer. Let me know if you need the full log?

As you can see its ~35 seconds from Init of DialogBusy to the DeInit. Any help much appreciated.

Code:
23:57:25.488 T:1962434880 DEBUG: OnKey: backspace (0xf008) pressed, action is Back 23:57:25.492 T:1962434880 DEBUG: CGUIMediaWindow::GetDirectory (plugin://plugin.video.apple_trailers/) 23:57:25.492 T:1962434880 DEBUG: ParentPath = [plugin://] 23:57:25.532 T:1402991520 DEBUG: CAddonDatabase::SetLastUsed[plugin.video.apple_trailers] took 40 ms 23:57:25.538 T:1374679968 DEBUG: StartScript - calling plugin Apple Trailers('plugin://plugin.video.apple_trailers/','13','') 23:57:25.539 T:1474585504 DEBUG: Thread LanguageInvoker start, auto delete: false 23:57:25.539 T:1474585504 INFO: initializing python engine. 23:57:25.540 T:1474585504 DEBUG: CPythonInvoker(28, /storage/.kodi/addons/plugin.video.apple_trailers/default.py): start processing 23:57:25.621 T:1474585504 DEBUG: -->Python Interpreter Initialized<-- 23:57:25.621 T:1474585504 DEBUG: CPythonInvoker(28, /storage/.kodi/addons/plugin.video.apple_trailers/default.py): the source file to load is "/storage/.kodi/addons/plugin.video.apple_trailers/default.py" 23:57:25.622 T:1474585504 DEBUG: CPythonInvoker(28, /storage/.kodi/addons/plugin.video.apple_trailers/default.py): setting the Python path to /storage/.kodi/addons/plugin.video.apple_trailers:/storage/.kodi/addons/script.module.tknorris.shared/lib:/usr/lib/python27.zip:/usr/lib/python2.7:/usr/lib/python2.7/plat-linux2:/usr/lib/python2.7/lib-tk:/usr/lib/python2.7/lib-old:/usr/lib/python2.7/lib-dynload:/usr/lib/python2.7/site-packages:/usr/lib/python2.7/site-packages/gtk-2.0 23:57:25.622 T:1474585504 DEBUG: CPythonInvoker(28, /storage/.kodi/addons/plugin.video.apple_trailers/default.py): entering source directory /storage/.kodi/addons/plugin.video.apple_trailers 23:57:25.622 T:1474585504 DEBUG: CPythonInvoker(28, /storage/.kodi/addons/plugin.video.apple_trailers/default.py): instantiating addon using automatically obtained id of "plugin.video.apple_trailers" dependent on version 2.1.0 of the xbmc.python api 23:57:25.912 T:1474585504 DEBUG: Apple Trailers: Calling cached method: |lib.trailer_scraper.Scraper.__get_url|(<lib.trailer_scraper.Scraper object at 0x58829510>, 'http://trailers.apple.com/trailers/home/xml/current.xml')|{}| 23:57:25.995 T:1962434880 DEBUG: ------ Window Init (DialogBusy.xml) ------ 23:57:26.458 T:1474585504 NOTICE: Apple Trailers: Version: |0.0.11| Queries: |{'mode': 'main'}| 23:57:26.458 T:1474585504 NOTICE: Apple Trailers: Args: |['plugin://plugin.video.apple_trailers/', '13', '']| 23:57:26.458 T:1474585504 NOTICE: Apple Trailers: Calling |show_movies| for mode |main| with pos args |[]| and kwargs |{}| 23:57:26.459 T:1474585504 DEBUG: Apple Trailers: List Dict: : {} 23:57:26.459 T:1474585504 DEBUG: Apple Trailers: Calling cached function: |get_movies|(0, 0)|{}| 23:57:26.459 T:1474585504 DEBUG: Apple Trailers: Calling cached method: |lib.trailer_scraper.Scraper.__get_url|(<lib.trailer_scraper.Scraper object at 0x58829510>, 'http://trailers.apple.com/trailers/home/feeds/studios.json', None)|{}| 23:57:47.911 T:1962434880 INFO: CheckIdle - Closing session to http://trailers.apple.com (easy=0x4e63e078, multi=0x5a10eb78) 23:57:53.744 T:1962434880 NOTICE: NFS is idle. Closing the remaining connections. 23:57:55.539 T:1462760352 DEBUG: Thread JobWorker 1462760352 terminating (autodelete) 23:57:55.539 T:1416623008 DEBUG: Thread JobWorker 1416623008 terminating (autodelete) 23:57:55.540 T:1402991520 DEBUG: Thread JobWorker 1402991520 terminating (autodelete) 23:58:00.713 T:1474585504 INFO: CPythonInvoker(28, /storage/.kodi/addons/plugin.video.apple_trailers/default.py): script aborted 23:58:00.718 T:1962434880 DEBUG: ------ Window Deinit (DialogBusy.xml) ------ 23:58:00.740 T:1474585504 INFO: Python script stopped 23:58:00.741 T:1474585504 DEBUG: Thread LanguageInvoker 1474585504 terminating

The problem is that for some reason the function cache isn't working properly and the addon is re-pulling the trailers every time you go back to the main listing in the addon. I'll try to reproduce it, but I doubt I can. If not, I may need to give you a debug version of tknorris.shared to get more info on why the cache isn't being used.