Posts: 1,155
Joined: Aug 2008
Right, i'm talking out from my ass again. it was video.fanart and movie.fanart that are most of the time the same, but according to your Github read me that's to be expected.
Posts: 1,292
Joined: Sep 2009
Reputation:
71
Read through your configuration. Everything you are doing looks 100% correct to me (which is why you're actually seeing images!).
On the addon side of things you are correct. The "Video.FanArt" property will display the same artwork as the Movie.FanArt or TV.FanArt property, depending on which it is displaying at the time. This is simply because on each property change a TV show and Movie is grabbed from the array. One of them is also copied to the Video field. This was simply to save on CPU so that two different movies or tv shows didn't have to be pulled during the same update cycle. Honestly I didn't envision someone doing what you are trying, I thought either movie/tv or the video property would be used, not all together.
On the music side of things I think I found a bug in the code. I'm using a JSON query to get the path to the music fanart. For each artist pulled there is a verify step to make sure the fanart path is not blank. I do believe this is broken and have uploaded a fix to github. Hopefully you'll start seeing music fanart now. I tried on my system and did not get 0 for the total artists pulled anymore.
In regards to a property that would display music, tv, or movies that could probably be done. If you can confirm the Music fanart is now displaying I'll work on adding an additional property field.
Posts: 1,155
Joined: Aug 2008
My idea was that when "videos" is focused in Confluence main menu it would cycle through movie and tvshows fanarts. Focusing movies would cycle movie fanarts and focusing tv, well, tv fanart.
Same idea could be used in the actual library views. Cycle between movie fanarts when browsing movie library views and so on.
The completely random fanarts could be used when you're not focusing either of those home menu items, or are not browsing movies, tvshows or music. So basically use random fanart when in settings, pictures, weather and so on.
I will test the updated add-on tonight, thanks.
Posts: 1,155
Joined: Aug 2008
Couldn't wait, had to test on the work PC, and music fanart now works.
Posts: 1,292
Joined: Sep 2009
Reputation:
71
Glad it works. I just pushed the changes for the 'Global' property. Due to differences in music and video types only Title and FanArt exist for this media type.
Both the Global and Video properties will still be the same as their respective Music, TV, or Movie counterpart. I guess I don't really see this as a problem. Since the artwork is changing fairly often, even while you are navigating through a menu it shouldn't be a big deal to see the same imagery under 'Video' as 'TV Shows' for a few seconds until it changes. In my opinion it would be a waste of resources to maintain separate arrays to make sure these are always different from each other. Since this is a service it is running all the time so trying to keep the processing to a minimum is somewhat important to me.
Posts: 828
Joined: Jan 2013
Reputation:
19
2013-11-22, 23:41
(This post was last modified: 2013-11-22, 23:46 by Rantanplan-1.)
thank you for this script. It does exactly what i was looking for.
Happy to test it!
Posts: 1,155
Joined: Aug 2008
Do you mind that i have the add-on available in my repo? I use the add-on as a dependency so i need it be available in some repository. If you upload it to the XBMC repo i'll remove it.
Posts: 1,155
Joined: Aug 2008
Uninstall CM and Grab Fanart then.. Or simply disable Grab Fanart, i guess that should stop the service from starting.
Posts: 1,126
Joined: Mar 2012
Reputation:
37
MassIV
Skilled Skinner
Posts: 1,126
First off, thnx for your work. I wanted to ask if this is supposed to work in MusicVisualisation.xml?
Works great in the library, but with the same code nothing is showing up in that window.
[RELEASE] Metroid
[RELEASE] IrcChat
Posts: 1,155
Joined: Aug 2008
It works in musicvis, i use it there as well.
Posts: 1,155
Joined: Aug 2008
(2013-11-24, 23:25)MilhouseVH Wrote: (2013-11-24, 23:19)SpaceMonkey Wrote: Uninstall CM and Grab Fanart then.. Or simply disable Grab Fanart, i guess that should stop the service from starting.
Of course that is one solution (and not really a very good one), as assuming this script is used by several skins it really only makes sense to start it when it's actually being used.
Well other service type add-ons work the same way, skin widgets for example, if you have it installed it will always run.
But you sort of have a point, most if not all skinners most likely want to override the add-on settings (mostly the refresh time for the background) so they are going to use runscript method of running it anyway. So to me it would be more logical to have it run only when requested.
But I'm happy either way.
Posts: 17,855
Joined: Jan 2011
Reputation:
1,055
Milhouse
Retired Team-Kodi Member
Posts: 17,855
2013-11-25, 08:53
(This post was last modified: 2013-11-25, 10:50 by Milhouse.)
I probably wouldn't have noticed were it not logging away every 10 seconds. At the very least it should log less, but it would also be very nice if stuff like this didn't start at all unless required by a particular skin.
Texture Cache Maintenance Utility: Preload your texture cache for optimal UI performance. Remotely manage media libraries. Purge unused artwork to free up space. Find missing media. Configurable QA check to highlight metadata issues. Aid in diagnosis of library and cache related problems.