Posts: 1,506
Joined: Nov 2013
why did you go through all the work of creating a screenshot of the PR instead of just posting the actual PR
your change is all good.
Posts: 5,208
Joined: Jul 2012
Reputation:
335
Well, 1 - I'm not a C programmer, so I just did what seems logical based on general programming knowledge; could be messed up, but more so 2 - so far I haven't been able to compile on VS2015, and it seemed not wise to PR something that I couldn't even test, potentially wasting people's time and effort.
So I was hopping by doing the preliminary work, someone could sanity check and submit a valid PR.
scott s.
.
Posts: 10,474
Joined: Oct 2011
Reputation:
628
jjd-uk
Team-Kodi Member
Posts: 10,474
2017-07-13, 11:54
(This post was last modified: 2017-07-13, 11:55 by jjd-uk.)
Do you have the change pushed to a fork of the XBMC projec n Github? as any Team member can kick off a build for you using our Jenkins build system if you wish to test before doing a PR.
Posts: 1,746
Joined: Nov 2014
Reputation:
160
docwra
Posting Freak
Posts: 1,746
Nice request! Get it PR'd up, at least then someone could take it over if its wrong in any way.
Posts: 1,506
Joined: Nov 2013
so much time wasted...
untested PR submitted;
https://github.com/xbmc/xbmc/pull/12495