Req Add sort method "DateAdded" for MusicVideo views
#1
Propose adding an additional sort method of "SortByDateAdded" for music video views in videos window. I think the applicable file is GUIViewStateVideo.cpp and could be PRed something like this?

Image

scott s.
.
maintainer of skin  Aeon MQ5 mods for post-Gotham Kodi releases:
Matrix see: Aeon MQ5 Mod Matrix release thread
Nexus see: Aeon MQ5 Mod Nexus release thread
Aeon MQ 5 skin and addon repo 11.1.0
Reply
#2
why did you go through all the work of creating a screenshot of the PR instead of just posting the actual PR Wink

your change is all good.
Reply
#3
Well, 1 - I'm not a C programmer, so I just did what seems logical based on general programming knowledge; could be messed up, but more so 2 - so far I haven't been able to compile on VS2015, and it seemed not wise to PR something that I couldn't even test, potentially wasting people's time and effort.

So I was hopping by doing the preliminary work, someone could sanity check and submit a valid PR.

scott s.
.
maintainer of skin  Aeon MQ5 mods for post-Gotham Kodi releases:
Matrix see: Aeon MQ5 Mod Matrix release thread
Nexus see: Aeon MQ5 Mod Nexus release thread
Aeon MQ 5 skin and addon repo 11.1.0
Reply
#4
Do you have the change pushed to a fork of the XBMC projec n Github? as any Team member can kick off a build for you using our Jenkins build system if you wish to test before doing a PR.
Reply
#5
Nice request! Get it PR'd up, at least then someone could take it over if its wrong in any way.
Reply
#6
so much time wasted...

untested PR submitted; https://github.com/xbmc/xbmc/pull/12495
Reply
#7
Scott there is a Win 32 Test Build at http://mirrors.kodi.tv/test-builds/windo...te-x86.exe if you want to test.
Reply

Logout Mark Read Team Forum Stats Members Help
Add sort method "DateAdded" for MusicVideo views0