[Announcement] - Changes in Subtitle Addons structure

  Thread Rating:
  • 0 Votes - 0 Average
  • 1
  • 2
  • 3
  • 4
  • 5
Post Reply
amet Offline
Retired Team-Kodi Member
Posts: 4,090
Joined: Jul 2009
Reputation: 41
Location: Novi Sad / Dubai
Post: #1
Hello,

As of Gotham, hopefully by end of November merge window, there will be some major changes in how subtitle addons will work in XBMC.

after over a year of thinking and playing with different options( this was aimed at Frodo release originally), we have settled for adding a new window in XBMC skin/core that will be called from OSD subtitle button, right now OSD subtitle button calls selected subtitle addon.

its a new feature and in needs to go in now and we can polish it in the next few weeks/months/years Smile

JM has done a load of work on it to help and PR is out there, as for the changes in addon structure it can be seen in in demo addon here and opensubtitles working addon is here. I will work on moving podnapisi, sublight and titlovi into new format, rest will need to be done by their respective authors and submitted to XBMC repo.

Sorry for a change, but many of you kind of knew about it for a while... this will make it much easier for all service authors to submit to XBMC repo directly without having to go through me and my github PR system first.I am not the best at explaining how things work, so if anything is unclear please ask here. Smile

lets keep this thread for technical discussion and for service maintainers to get a handle on how things need to change, any questions about current subtitle addon will be deleted/ignored. any ideas are welcome but note that some features have been left out intentionally as to not clutter XBMC settings page.

Cheers,
amet
find quote
Temhil Offline
Skilled Python Coder
Posts: 397
Joined: Apr 2008
Reputation: 1
Location: Canada
Post: #2
That is a great news, I am very happy to hear this will go through, I was really looking for something modular like you guys did.
Thank you very much for the hard work!

[Image: passionxbmc_signature.png]
_____________________________

Repositories Installer: select and install unofficial repositories / TAC.TV: watch videos on TAC.TV
Installer Passion-XBMC: Download and Install Add-ons (pre-Dharma only)

[Image: project_thin_badge.gif]
find quote
RockerC Offline
Fan
Posts: 353
Joined: May 2011
Reputation: 4
Post: #3
FYI, posted a new thread in the feature suggestion forum with a related idea to also move Music Lyrics Addon core handling to XBMC's core

http://forum.xbmc.org/showthread.php?tid=177752

That is, exact same concept as for these subtitles service plugins, if that code and GUI window(s) could be extended or reused for this too?

(2013-11-11 17:29)RockerC Wrote:  I like to suggest that (Music) Lyrics Addons core handling code be moved to XBMC's core. Ä

Since it have already been decided that the Subtitles Addon core handling will be moved to XBMC's core in Pull Request 3552, maybe that code could be extended to also support similar lyrics service plugins too?


Pull Request 3552 idea is to the GUI portion of the XBMC Subtitles Script into XBMC's core, and has the individual subtitle services run as plugins from there, which will allow better skin integration of downloading of subtitles. As better described on the xbmc.org home page here http://xbmc.org/making-subtitle-search-better/

So perhaps the same new UI window(s) and concept could be extend or reused to be used for lyrics service plugins?
(This post was last modified: 2013-11-17 13:49 by RockerC.)
find quote
amet Offline
Retired Team-Kodi Member
Posts: 4,090
Joined: Jul 2009
Reputation: 41
Location: Novi Sad / Dubai
Post: #4
take it elsewhere please, I said and asked nicely to keep discussion clean.. if you have nothing to add to this its better to say nothing

thanks
find quote
FREAKJAM Offline
Member
Posts: 95
Joined: Aug 2011
Reputation: 2
Post: #5
Thanks for the heads up! I tried the new change and tested in the latest nightlies. I have a few questions:

How does the new structure handle multiple languages? Let's say my primary language is Dutch, but if not available i prefer English subs. How does that work?
I also found service.subtitles.podnapisi on your github, installed it and tested if XBMC can handle multiple services, which works nicely.

If i now select the subtitle button, a small menu will popup called "download". When clicking it, it will execute the addon service. Why not directly execute it and skip the download button?

PS:
I like the new flags that xhaggi mentioned on the github page.
(This post was last modified: 2013-11-18 20:40 by FREAKJAM.)
find quote
amet Offline
Retired Team-Kodi Member
Posts: 4,090
Joined: Jul 2009
Reputation: 41
Location: Novi Sad / Dubai
Post: #6
(2013-11-18 20:33)FREAKJAM Wrote:  Thanks for the heads up! I tried the new change and tested in the latest nightlies. I have a few questions:

How does the new structure handle multiple languages? Let's say my primary language is Dutch, but if not available i prefer English subs. How does that work?

in subtitle settings in XBMC you set languages, there is still no way to specify which is your top priority

(2013-11-18 20:33)FREAKJAM Wrote:  I also found service.subtitles.podnapisi on your github, installed it and tested if XBMC can handle multiple services, which works nicely.

thx for testing, I am still working on it and there are some changes needed in core that will have effect on the services, thats why its still not in official repo

(2013-11-18 20:33)FREAKJAM Wrote:  If i now select the subtitle button, a small menu will popup called "download". When clicking it, it will execute the addon service. Why not directly execute it and skip the download button?

this is entirely up to skin and skinners, you can have a button that is just download or have a popup window...

(2013-11-18 20:33)FREAKJAM Wrote:  PS:
I like the new flags that xhaggi mentioned on the github page.

yeah, I do too... but again, its up to the skinners to decide what the window will look like... I simply included the ones I had
find quote
FREAKJAM Offline
Member
Posts: 95
Joined: Aug 2011
Reputation: 2
Post: #7
Quote:in subtitle settings in XBMC you set languages, there is still no way to specify which is your top priority

Found the subtitle settings in video - settings in the confluence skin. I can select multiple languages indeed for subtitles, which is nice!
I tested it again, and it now shows both dutch and english subitles when executing the addon, which works for me.

Quote:this is entirely up to skin and skinners, you can have a button that is just download or have a popup window...

fair enough, I already gave a heads up to the creator of the Arctic skin, he is aware of it now.
Let's hope more active skinners will follow.
find quote
ptiper21 Offline
Junior Member
Posts: 8
Joined: Nov 2013
Reputation: 0
Post: #8
I use latest gotham nightly builds in android ( only these support kit kat ) and i have added opensubtitles addon. Although i have set greek language as preffered language in subtitles setting, i receive no subtitles or other third language subtitles.Is there any solution? I can't use xbmc without subs. Podnapisi addon does the same...Thanks
find quote
hfmls Offline
Senior Member
Posts: 142
Joined: Sep 2008
Reputation: 0
Post: #9
hi guys, where do i add a language? i would like to serach english and portuguese subtitles.

[Image: benfica_sempre_logo_by_juniorneves-d4dqzjp.png]
find quote
sagiben Offline
Junior Member
Posts: 2
Joined: Jan 2011
Reputation: 0
Post: #10
Hi,

I would like to add a subtitles service.
I implemented the code, pushed it a github repo, how do I publish it ?

Thanks,
Sagi.
find quote
Martijn Offline
Team Kodi
Posts: 11,612
Joined: Jul 2011
Reputation: 167
Location: Dawn of time
Post: #11
(2013-11-26 07:26)sagiben Wrote:  Hi,

I would like to add a subtitles service.
I implemented the code, pushed it a github repo, how do I publish it ?

Thanks,
Sagi.

http://forum.xbmc.org/showthread.php?tid=151473

Always read the XBMC online-manual, FAQ and search the forums before posting.
Do NOT e-mail Team-XBMC members asking for support. Read/follow the forum rules.
For troubleshooting and bug reporting, make sure you read this first

For your mediacenter artwork go to
[Image: fanarttv.png]
find quote
annika Offline
Junior Member
Posts: 1
Joined: Dec 2013
Reputation: 0
Post: #12
Hello.
1 i am sorry fore my bath english.
I ym a new member from saterday.
I hafe a problem with the subtitles, when i watch a tv serie (warehouse 13)
i always geth the subs from a episode before.
i mean when i watch seizoen 1 episode.4 i geth the subs from seizoen 1.episode 3
ore i watch seizoen 1 episode 5 i geth the subs from seizoen 1 episode 4

hope someone cane help me.
find quote
Bram77 Offline
Skilled Python Coder
Posts: 1,373
Joined: Feb 2008
Reputation: 32
Location: Netherlands
Post: #13
That's strange, I've never had that problem in 7 years and I've downloaden hundreds of subtitles.
Do you scan your videos to the library?

[Image: widget]

Please add to my reputation if you find my posts usefull (+/- button below posts)
Ubuntu 12.10 minimal XBMC auto-install script :: XBMControl :: Xbmc XBOX Skins :: XBMControl for Android :: Owner of Sudo Systems
find quote
Wanilton Offline
Posting Freak
Posts: 1,272
Joined: Jun 2010
Reputation: 27
Location: Florianópolis - Brazil
Post: #14
@amet, it´s possible create one shortcut for request subtitle, via ActivateWindow(SubtitleSearch), maybe Json, before I use this in keyboard.xml for call function, when playing video.

Code:
<u>RunScript(script.xbmc.subtitles)</u>

http://www.xbmcbrasil.net - Youtube Channel
Admin
Windows 8.1 - XBMC Helix Custom Plus - Aeon MQ 5
My Room Entertaiment´s
About me
(This post was last modified: 2013-12-04 13:54 by Wanilton.)
find quote
amet Offline
Retired Team-Kodi Member
Posts: 4,090
Joined: Jul 2009
Reputation: 41
Location: Novi Sad / Dubai
Post: #15
<u>ActivateWindow(SubtitleSearch)</u> in keyboard is all you need
find quote
Post Reply