Question Regarding Gotham Library Cleaning
#1
I don't know the exact PR on github that merged this request in or I'd just try and sift through the code myself. I read on the XBMC Blog that a new Gotham feature is that library items are not removed when doing a clean and your media server is temporarily offline.

My guess is that the clean operation checks if you've actually removed a source from sources.xml, and then tests that the root directory of that source is accessible before determining if any files it contains are removed or not. Is this pretty close to how it functions?

My reason for asking is that the Library Update addon I maintain currently has a setting to "verify paths" before issueing the CleanLibrary() command that the user can setup via a timer. This was to eliminate the temporarily offline behavior. If the Clean function will now do this sort of thing I can remove this check for the Gotham version of the addon.

Thanks!
Reply
#2
I added the logic. XBMC remembers the parent path (path of the source) for every file. With the new behaviour, whenever it finds a file that doesn't exists anymore it checks if the parent path still exists. If it does, it assumes that the file was deleted intentionally. If the parent path is missing as well it lets the user choose whether to remove all items from that source or to keep them all).
Always read the online manual (wiki), FAQ (wiki) and search the forum before posting.
Do not e-mail Team Kodi members directly asking for support. Read/follow the forum rules (wiki).
Please read the pages on troubleshooting (wiki) and bug reporting (wiki) before reporting issues.
Reply
#3
Awesome. Thanks for the clarification. I'll add removing this to my list of Gotham changes. No need to verify sources independently if this logic is in place within the CleanLibrary() functionality.
Reply
#4
(2014-01-08, 17:29)Montellese Wrote: I added the logic. XBMC remembers the parent path (path of the source) for every file. With the new behaviour, whenever it finds a file that doesn't exists anymore it checks if the parent path still exists. If it does, it assumes that the file was deleted intentionally. If the parent path is missing as well it lets the user choose whether to remove all items from that source or to keep them all).

Hi,
I'm having problems with this feature..

with my folder structuure if I move a folder that contain a film always ask me for delete confirmation..

is there a way to disable this feature in gotham?

folder structure for example is:

FILM -> 0-9 -> 007 - Collection -> 007 - Skyfall -> 007 - Skyfall.mkv

if I move 007 - Collection folder to another drive library cleanup ask me to delete or keep every 007 film...
Reply
#5
(2014-05-15, 01:11)Bazzu85 Wrote:
(2014-01-08, 17:29)Montellese Wrote: I added the logic. XBMC remembers the parent path (path of the source) for every file. With the new behaviour, whenever it finds a file that doesn't exists anymore it checks if the parent path still exists. If it does, it assumes that the file was deleted intentionally. If the parent path is missing as well it lets the user choose whether to remove all items from that source or to keep them all).

Hi,
I'm having problems with this feature..

with my folder structuure if I move a folder that contain a film always ask me for delete confirmation..

is there a way to disable this feature in gotham?

folder structure for example is:

FILM -> 0-9 -> 007 - Collection -> 007 - Skyfall -> 007 - Skyfall.mkv

if I move 007 - Collection folder to another drive library cleanup ask me to delete or keep every 007 film...

What did you define as your source? "FILM", "0-9" or "007 - Collection"?
Always read the online manual (wiki), FAQ (wiki) and search the forum before posting.
Do not e-mail Team Kodi members directly asking for support. Read/follow the forum rules (wiki).
Please read the pages on troubleshooting (wiki) and bug reporting (wiki) before reporting issues.
Reply
#6
The source is Film..
Reply
#7
Please provide a Debug log (wiki) of when you are cleaning your library and run into this issue. It should only ask you if the whole source has gone missing. But TBH I've never tried that case because my movies are organized in
Code:
Movies
  -- Skyfall
     -- Skyfall.mkv
  -- Casino Royale
     -- Casino Royale.mkv
  -- ..
so there are no extra levels.
Always read the online manual (wiki), FAQ (wiki) and search the forum before posting.
Do not e-mail Team Kodi members directly asking for support. Read/follow the forum rules (wiki).
Please read the pages on troubleshooting (wiki) and bug reporting (wiki) before reporting issues.
Reply
#8
I have extra levels

Movies
---Animation
------Movie1
------Movie2
----General
------Movie3

Source is on Movies. So far i haven't experienced this although my source is rarely offline
Read/follow the forum rules.
For troubleshooting and bug reporting, read this first
Interested in seeing some YouTube videos about Kodi? Go here and subscribe
Reply
#9
From the problem description I guess it only happens when you would e.g. move "Animation" out of "Movies" or rename it to something else.
Always read the online manual (wiki), FAQ (wiki) and search the forum before posting.
Do not e-mail Team Kodi members directly asking for support. Read/follow the forum rules (wiki).
Please read the pages on troubleshooting (wiki) and bug reporting (wiki) before reporting issues.
Reply
#10
(2014-05-15, 08:10)Montellese Wrote: Please provide a Debug log (wiki) of when you are cleaning your library and run into this issue. It should only ask you if the whole source has gone missing. But TBH I've never tried that case because my movies are organized in
Code:
Movies
  -- Skyfall
     -- Skyfall.mkv
  -- Casino Royale
     -- Casino Royale.mkv
  -- ..
so there are no extra levels.

(2014-05-15, 08:12)Martijn Wrote: I have extra levels

Movies
---Animation
------Movie1
------Movie2
----General
------Movie3

Source is on Movies. So far i haven't experienced this although my source is rarely offline

(2014-05-15, 08:27)Montellese Wrote: From the problem description I guess it only happens when you would e.g. move "Animation" out of "Movies" or rename it to something else.

here's the debug log:
https://dl.dropboxusercontent.com/u/5224...140515.log

i have activated debugging mode in xbmc and started library cleanup (for first source not found I have choose to keep film) but in this log I can't find anything about clean library..

returning to your answer:

@Montellese
if you rename "Skyfall" folder to other name and clean library xbmc ask you to keep or delete "Skyfall" film!

for Martijn example if he move/rename "Animation" folder to another drive and he clean library he as to confirm delete for every folder under "Animation"..
Reply
#11
I propose..

Why don't you add a sub options of "Clean library" to let choose user what to do with these media?
"Auto delete" (like in Frodo) or "Ask" (like now)?


Another thing is that when you have to choose to delete or keep media..you can't abort library clean..if I press esc key he continue with next media..
Reply
#12
with tv show I've no problems because the structure is for example:

Anime (source) - Ranma 1/2 -> Season 01

if I rename Ranma 1/2 to Ranma the cleanup is automatic..
Reply
#13
Can you give me a feedback?

Do you plan to resolve this "problem"?
Reply
#14
You'll have to be a bit more patient.

My time to work on xbmc is limited and this is not at the top of the list.
Always read the online manual (wiki), FAQ (wiki) and search the forum before posting.
Do not e-mail Team Kodi members directly asking for support. Read/follow the forum rules (wiki).
Please read the pages on troubleshooting (wiki) and bug reporting (wiki) before reporting issues.
Reply
#15
Ok..
Let me know when you think to face the problem..
Reply

Logout Mark Read Team Forum Stats Members Help
Question Regarding Gotham Library Cleaning0