Bug Wrong code returned by CLangCodeExpander::ConvertToThreeCharCode
#1
When using language name to get 3-char code for Croatian, the function returns 'scr'. This function is used from ModuleXbmc.cpp, convertLanguage function when format = ISO_639_2.
According to Wikipedia, 'scr' is not ISO_639_2 code for Croatian, 'hrv' is.
The problem is there are two entries for Croatian in the g_iso639_2 array, first is scr, second is hrv. Putting hrv first, solves the problem.
Haven't checked, but there might be other languages with this problem. This problem causes OpenSubtitles service never to find Croatian subtitles.
Reply
#2
The problem is that those codes are not unique. According to http://www.loc.gov/standards/iso639-2/ph...hanges.php scr was used till 2008-06-28.

Quote:Haven't checked, but there might be other languages with this problem.

I will change that, but I really don't have the time to go through the whole list. So thanks for bringing this to our attention.
Reply
#3
See PR https://github.com/xbmc/xbmc/pull/4036
Reply
#4
@ace20022

Can you have a look at this thread... http://forum.xbmc.org/showthread.php?tid=182606

thanks.
Reply
#5
@uNiversal you should ask karlson2k.
Reply
#6
Can you ping him to look, pls? Ive made a inthread ping... But that wont work.
Reply
#7
done
Reply

Logout Mark Read Team Forum Stats Members Help
Wrong code returned by CLangCodeExpander::ConvertToThreeCharCode0